[Bug 15185] New: 3 subroutines are unused in C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Bug ID: 15185 Summary: 3 subroutines are unused in C4::Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44836&action=edit Bug 15185: Remove Check*Holidays subroutines in C4::Circulation These 3 subroutines are not used anymore: - CheckRepeatableHolidays - CheckSpecialHolidays - CheckRepeatableSpecialHolidays Moreover we have subroutines in Koha::Calendar to do this job. Test plan: git grep CheckRepeatableHolidays git grep CheckSpecialHolidays git grep CheckRepeatableSpecialHolidays should not return any results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44836|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44857&action=edit [SIGNED-OFF]Bug 15185: Remove Check*Holidays subroutines in C4::Circulation These 3 subroutines are not used anymore: - CheckRepeatableHolidays - CheckSpecialHolidays - CheckRepeatableSpecialHolidays Moreover we have subroutines in Koha::Calendar to do this job. Test plan: git grep CheckRepeatableHolidays git grep CheckSpecialHolidays git grep CheckRepeatableSpecialHolidays should not return any results. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Subroutines removed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44857|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44870&action=edit [PASSED QA] Bug 15185: Remove Check*Holidays subroutines in C4::Circulation These 3 subroutines are not used anymore: - CheckRepeatableHolidays - CheckSpecialHolidays - CheckRepeatableSpecialHolidays Moreover we have subroutines in Koha::Calendar to do this job. Test plan: git grep CheckRepeatableHolidays git grep CheckSpecialHolidays git grep CheckRepeatableSpecialHolidays should not return any results. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Subroutines removed Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org