https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42763 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42763 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199886&action=edit Bug 42763: ERM local title show page does not display link to local bibliographic record This patch adds the biblio_id field to the resourceAttrs array in EHoldingsLocalTitleResource.vue so that, when a local eHoldings title has a linked bibliographic record, a "Local bibliographic record" link is shown on the title's show page. The link was already implemented for EBSCO titles but was missing for local titles because the generic ResourceShow framework only renders fields explicitly declared in resourceAttrs. Test plan: 1. Go to E-resource management > eHoldings > Local > Titles and create a new title, checking the "Create bibliographic record" option. Save. 2. Result: No link to the local bibliographic record is shown anywhere on the page. 3. Apply patch, run yarn js:build, clear browser cache, and restart everthing (restart_all). 4. Open the show page of the title created in step 1. A "Local bibliographic record" link pointing to the catalogue detail page should now appear at the bottom of the fields list. 5. Open a local title that does NOT have a linked bibliographic record and verify that the "Local bibliographic record" row is not shown. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |adolfo.rodriguez@xercode.es Text to go in the| |This fixes local ERM release notes| |eHolding titles for local | |titles, so that a link to | |the local bibliographic | |record is shown if "Create | |bibliographic record" is | |selected when creating the | |title (ERM > eHoldings > | |Local > Titles). | | | |Before this, no link was | |shown on the local title | |page. Now a "Local | |bibliographic record" field | |is shown along with the | |bibliographic record ID | |linked to the record. --- Comment #3 from David Nind <david@davidnind.com> --- Thank you for the really good bug report! I think this may be a duplicate of bug 42522 and have put a note on that bug for the patch author to check. I think most developers use the community's development environment to prepare and submit patches: koha-testing-docker (https://gitlab.com/koha-community/koha-testing-docker). I am not a developer, so I would recommend asking about the right way to attach patches on the development channel in our Koha Community Chat (https://chat.koha-community.org/). I'm only mentioning this, as the patch did not appear the way normally expected for those of us signing off bugs, even though the details were in the patch (by clicking on the details link for the patch). I have: 1. Added you as the assignee for the bug 2. Reattached the patch as part of sign-off so that it appears the way expected. 3. Amended the commit message (see https://wiki.koha-community.org/wiki/Commit_messages) - Fixed the title: should start Bug XXXX: Title (note the colon instead of the hyphen) - Update the test plan slightly to show the result from step 1 4. I ran the qa script (just 'qa') in a koha-testing-docker shell - before I amended the commit message, it highlighted the bug title issue. Thanks again for the patch! David Nind New Zealand -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42763 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Adolfo, please confirm that the patch on bug 42522 fixes your issue. *** This bug has been marked as a duplicate of bug 42522 *** -- You are receiving this mail because: You are watching all bug changes.