[Bug 17132] New: Availability search broken when using Elastic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Bug ID: 17132 Summary: Availability search broken when using Elastic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Elastic appears to be indexing onloan as a string, but our code assumes it is a boolean. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 54490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54490&action=edit Bug 17132 - Availability search broken when using Elastic Elastic appears to be indexing onloan as a string, but our code assumes it is a boolean. Test Plan: 1) Ensure you are set up using Elastic as your search engine 2) Search only for available items from the advanced search 3) Note you get no results 4) Apply this patch 5) Re-run the search 6) You should now get results! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 J Schmidt <jschmidt@switchinc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jschmidt@switchinc.org --- Comment #2 from J Schmidt <jschmidt@switchinc.org> --- I went into the PTFS Sandbox (1) and did a search for 'the' to find items in the test database. I found some titles having status of available.. I then went to "Search the Catalog" and did numerous searches (e.g., The middle east and brazil)...I was able to bring up results (Success). I went under the Advanced Search area and did the same. I was able to again retrieve results successfully. Following the test plan below this bug appears to meet the status of signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@ptfs-europe.com --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 55262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55262&action=edit Bug 17132 - Availability search broken when using Elastic Elastic appears to be indexing onloan as a string, but our code assumes it is a boolean. Test Plan: 1) Ensure you are set up using Elastic as your search engine 2) Search only for available items from the advanced search 3) Note you get no results 4) Apply this patch 5) Re-run the search 6) You should now get results! Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 --- Comment #5 from J Schmidt <jschmidt@switchinc.org> --- I checked out Once upon a time 39999000016376... to patron aitken, bailey then performed searches as the title is not available and it was retrieved in basic and advanced search (I did a title search using 'the time')... listed correctly as on loan and retrieve other results. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- I can't recreate this, 'false' seems to be acceptable to elastic as a boolean value https://www.elastic.co/guide/en/elasticsearch/reference/current/boolean.html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55262|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57692&action=edit Bug 17132 - Availability search broken when using Elastic Elastic appears to be indexing onloan as a string, but our code assumes it is a boolean. Test Plan: 1) Ensure you are set up using Elastic as your search engine 2) Search only for available items from the advanced search 3) Note you get no results 4) Apply this patch 5) Re-run the search 6) You should now get results! Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17132 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org