[Bug 23772] New: Itemtype icons now showing in table and not checked when editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Bug ID: 23772 Summary: Itemtype icons now showing in table and not checked when editing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When looking at the new datatable for itemtypes, the itemtype icons are no longer displayed. The same happens, when editing an itemtype - the icon is no longer 'checked'. When you take a look at the db, the file names are there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23602 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Git bisect says the display problem (icons not showing up in the table) is caused by Bug 23602. Git bisect says the problem with the correct icon's radio button not being selected arose way back in Bug 20216. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 [Bug 23602] Library limitations should display in the item types table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20216 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 [Bug 20216] Editing itemtypes does not pull existing values correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Itemtype icons now showing |Itemtype icons not showing |in table and not checked |in table and not checked |when editing |when editing CC| |agustinmoyano@theke.io, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Quite some detective work there! Should we split this into 2 separate bugs then? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94011&action=edit Bug 23772: Revert to passing itemtype objects to the template This patch restores the methodology prior to bug 23602 of passing the full Koha::ItemType objects to the template and thus giving us the ability to use all the methods present within them. Test plan: 1) Ensure you have at least one itemtype with an assigned icon and the images enabled. 2) View the itemtypes admin page and note the icons display again 3) Ensure you have at least one itemtype with library limitations defined. 4) View the itemtypes admin page and note the library limitations still display. 5) Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 [Bug 23804] Itemtype not checked when editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Itemtype icons not showing |Itemtype icons not showing |in table and not checked |in table |when editing | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23804 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23804 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 [Bug 23804] Itemtype not checked when editing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94011|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94016&action=edit Bug 23772: Revert to passing itemtype objects to the template This patch restores the methodology prior to bug 23602 of passing the full Koha::ItemType objects to the template and thus giving us the ability to use all the methods present within them. Test plan: 1) Ensure you have at least one itemtype with an assigned icon and the images enabled. 2) View the itemtypes admin page and note the icons display again 3) Ensure you have at least one itemtype with library limitations defined. 4) View the itemtypes admin page and note the library limitations still display. 5) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94016|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94035&action=edit Bug 23772: Revert to passing itemtype objects to the template This patch restores the methodology prior to bug 23602 of passing the full Koha::ItemType objects to the template and thus giving us the ability to use all the methods present within them. Test plan: 1) Ensure you have at least one itemtype with an assigned icon and the images enabled. 2) View the itemtypes admin page and note the icons display again 3) Ensure you have at least one itemtype with library limitations defined. 4) View the itemtypes admin page and note the library limitations still display. 5) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 23602 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org