[Bug 23804] New: Itemtype not checked when editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Bug ID: 23804 Summary: Itemtype not checked when editing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: agustinmoyano@theke.io, gmcharlt@gmail.com, katrin.fischer@bsz-bw.de, koha-bugs@lists.koha-community.org, nick@bywatersolutions.com, testopia@bugs.koha-community.org Depends on: 23772, 20216, 23602 +++ This bug was initially created as a clone of Bug #23772 +++ When looking at the new datatable for itemtypes, the itemtype icons are no longer displayed. The same happens, when editing an itemtype - the icon is no longer 'checked'. When you take a look at the db, the file names are there. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20216 [Bug 20216] Editing itemtypes does not pull existing values correctly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23602 [Bug 23602] Library limitations should display in the item types table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 [Bug 23772] Itemtype icons not showing in table and not checked when editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23772 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23772 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 [Bug 23772] Itemtype icons not showing in table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94017&action=edit Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 94028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94028&action=edit Images showing two issues identified 1) Weird display of remote image after patch applied 2) Images not displayed in table When testing this patch (which worked), I identified two issues: 1) After the patch is applied the remote image display is weird - after the input box and image there is an empty input box and the image is shown again (see issue 1 in attachment - shows before and after patch applied). 2) Not related to this bug, but does affect master. Images are not displayed in the image column (see issue 2 in attachment - shows images not displayed for current master (is the same before and after patch is applied), and for 19.05.x where it works correctly). -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 --- Comment #3 from David Nind <david@davidnind.com> --- Argh! I see issue 2 is already a separate bug - 23772! (Issue 1 still applies though) -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94017|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94210&action=edit Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patch updated to remove the image when no url is set. Also, bug 23772 is now pushed to the first issue is also resolved now. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94210|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94211&action=edit Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94211|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94217&action=edit Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94217|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94225&action=edit Bug 23804: Correctly catch remote itemtype images Bug 20216 missed the mark and although it did start display a URL for the itemtype image in use, it was not limited to remote urls and as such broke the checked handling for displaying which local image was selected. Test plan: 1) Select a local image for an itemtype. 2) Check the correct image is displayed in the admin table. 3) Edit the itemtype checking that the correct image is checked. 4) Change to a remote image for the itemtype 5) Check the correct image is displayed in the admin table. 6) Edit the itemtype again and check that the URL still displays and is checked in the 'Remote image' tab. 7) Signoff Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 23602 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org