[Bug 20057] New: Auto-approve option for borrower modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Bug ID: 20057 Summary: Auto-approve option for borrower modifications Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: stefan.berndtsson@ub.gu.se QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We (Gothenburg University) allow patrons to change their own personal details at will. The need for either email verification (not everyone has a registered email address) or staff approval is an unnecessary obstacle. Here is a request (and code) for automatic approval of detail changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #1 from Stefan Berndtsson <stefan.berndtsson@ub.gu.se> --- Created attachment 70790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70790&action=edit Syspref for auto approval of patron profile changes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #2 from Stefan Berndtsson <stefan.berndtsson@ub.gu.se> --- Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70790|0 |1 is obsolete| | --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 70925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70925&action=edit Bug 20057 - Syspref for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 70926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70926&action=edit Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70926|0 |1 is obsolete| | Attachment #70926|1 |0 is patch| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #5 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 70927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70927&action=edit Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se --- Comment #6 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Looking at the earlier comments, shouldn't this bug have the status Signed off? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This needs a rebase - changing status to reflect. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70925|0 |1 is obsolete| | --- Comment #8 from David Gustafsson <glasklas@gmail.com> --- Created attachment 105075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105075&action=edit Bug 20057 - Syspref for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70927|0 |1 is obsolete| | --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- Created attachment 105076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105076&action=edit Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |glasklas@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, can you explain PatronSelfRegistrationVerifyByEmail in your test plan? This should only be valid for registrations, not for changes. So I think in your plan it should probably work with either setting of the pref? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105076|0 |1 is obsolete| | --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Created attachment 105142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105142&action=edit Bug 20057 - followup - add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "PatronSelfRegistrationVerifyByEmail" is set to "Don't require". 3. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #12 from David Gustafsson <glasklas@gmail.com> --- @Katrin Fischer. Sorry, just rebased, had some real nasty issues with git bz/am and the fastest way to get around them was to reconstruct the commits manually and forgot to change the author of the last commit. So I'm not the author of that one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #13 from David Gustafsson <glasklas@gmail.com> --- (Have now corrected the commit author). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #14 from David Gustafsson <glasklas@gmail.com> --- So regarding your question I'm not at all familiar with this patch and cannot give a direct answer. I can perhaps get back to it later, but right now don't have time to figure this out. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105075|0 |1 is obsolete| | Attachment #105142|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105303&action=edit Bug 20057: System preference for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via OPAC interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105304&action=edit Bug 20057: (follow-up) Add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105305&action=edit Bug 20057: Fix capitalization and rephrase system preference as a sentence This makes changes to strings involved in this feature: - Rephrases the system preference description into a sentence - Rephrases message shown in OPAC on submitting (library has not actively approved, so just say that the record has been modified) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've fixed up the patches to apply to standards (capitalization and commit messages). I can't make out why PatronSelfRegistrationVerifyByEmail should be relevant here, so I have removed it from the commit messages. I've also tested the workflow for self registrations. Please QA team, can you double check this? We use opac-memberentry.pl for a few too many things. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #18)
Please QA team, can you double check this? We use opac-memberentry.pl for a few too many things.
That seems correct to me. Maybe we should rename the pref to match "SelfModification", like "AutoApprovePatronSelfModification"? Idea of improvement: we could make it a list of patron's categories instead of a global switch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105303|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109288&action=edit Bug 20057: System preference for auto approval of patron profile changes Testplan for this patch: 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via OPAC interface again. 7. Expect modifications to have been approved automatically. Signed-off-by: Liz Rea <liz@catalyst.net.nz> This works, we may want some different text for this situation in the OPAC, it still says the librarian has to approve the change. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105304|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109289&action=edit Bug 20057: (follow-up) Add text for auto accepted changes 1. Apply patch. 2. Make sure syspref "AutoApprovePatronProfileSettings" is set to "Disable". 3. Edit patron personal details via opac interface. 4. Expect modifications to require manual approval by staff via link on main page. -> 4a. Text for patron says that changes are pending acceptance by the library 5. Set syspref "AutoApprovePatronProfileSettings" to "Enable". 6. Edit patron personal details via opac interface again. 7. Expect modifications to have been approved automatically. -> 7a. Text for patron says that changes have been submitted and accepted by the library. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105305|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109290&action=edit Bug 20057: Fix capitalization and rephrase system preference as a sentence This makes changes to strings involved in this feature: - Rephrases the system preference description into a sentence - Rephrases message shown in OPAC on submitting (library has not actively approved, so just say that the record has been modified) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds a new system release notes| |preference | |AutoApprovePatronProfileSet | |tings that allows to | |automatically approve any | |requests for patron detail | |modifications made by | |patrons from the OPAC. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20057 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org