[Bug 20356] New: Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Bug ID: 20356 Summary: Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org Our SMS gateway provider requires that only one specific email address is used in as sender for all emails. This patch adds a system preference for setting "from" address for all mails sent by the Email SMS send driver. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 72517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72517&action=edit Bug 20356 - Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1. Run tests in t/db_dependent/Letters.t 2. All tests should pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 72518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72518&action=edit Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72518|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75111&action=edit Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- Rebased against Koha master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #5 from Michal Denar <black23@gmail.com> --- Please rebase on master, I'll test it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72517|0 |1 is obsolete| | Attachment #75111|0 |1 is obsolete| | --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- Created attachment 79712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79712&action=edit Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79712|0 |1 is obsolete| | --- Comment #7 from Michal Denar <black23@gmail.com> --- Created attachment 79760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79760&action=edit Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should not it be defined at provider level instead (table sms_providers)? Just asking ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- Yes, I agree that would probably be better. I think I made just the minimal effort to fix the problem (for us) and thought that I might refactor this later to add the setting on provider level. Could set this to "needs work" and I might fix this later, or if any one else have the time to do so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The things is that it would be done later, but will require more work (remove the code, update the DB, etc.) Not a big deal anyway. I will let the status as "Needs QA" to let another QAer give their opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *could* be done -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #10)
The things is that it would be done later, but will require more work (remove the code, update the DB, etc.) Not a big deal anyway. I will let the status as "Needs QA" to let another QAer give their opinion.
As this is required by specific provider, it should be done on provider level I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79760|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 81875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81875&action=edit Bug 20356: Add EmailSMSSendDriverFromAddress system preference Add EmailSMSSendDriverFromAddress system preference for overriding Email SMS send driver from address. How to test: 1) Run tests in t/db_dependent/Letters.t 2) All tests should pass Sponsored-by: Gothenburg University Library Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Not a blocker for me. Very specific and small issue, easy to move to provider db on a new report. Please open one, David. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Keywords| |rel_18_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20356 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34979 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org