[Bug 38530] New: ILL request table won't load if libraries are in groups and staff doesn't have view_borrower_infos_from_any_libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Bug ID: 38530 Summary: ILL request table won't load if libraries are in groups and staff doesn't have view_borrower_infos_from_any_libraries Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@ptfs-europe.com, tomascohen@gmail.com To recreate: Create 2 library groups and assign one library each to them. Both groups should have Create an ILL request for a patron in group 1. Create a test staff member in group 2 Permissions for a test borrower: catalogue ill list_borrowers make sure they don't have: view_borrower_infos_from_any_libraries Log in as the test staff member and attempt to load the ILL page. Will say "processing" but never load the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |unspecified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 --- Comment #1 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 175270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175270&action=edit Bug 38530: ILL request table won't load This patch updates the js-patron-format include to show text if the library can't be fetched due to lack of permissions. To test: Before applying the patch 1. Create 2 library groups 2. Give both groups the "Limit patron visibility to libraries within this group for members." attribute 3. Assign 1 library to each group. 4. Turn on ILL in the system preferences 5. Create an ILL for a patron in group 1. 6. Create a staff member for the library in group 2 with only the following permissions: catalogue ill list_borrowers 7. Log in as the new staff member. 8. Observe the table never loads. 9. Apply the patch. 10. Refresh the page as the new staff member. 11. Observe the table loads and the patron says "A patron from another library" 12. Log back in as the superlibrarian and confirm you can still see the patron information. 13. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175270|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175293&action=edit Bug 38530: ILL request table won't load This patch updates the js-patron-format include to show text if the library can't be fetched due to lack of permissions. To test: Before applying the patch 1. Create 2 library groups 2. Give both groups the "Limit patron visibility to libraries within this group for members." attribute 3. Assign 1 library to each group. 4. Turn on ILL in the system preferences 5. Create an ILL for a patron in group 1. 6. Create a staff member for the library in group 2 with only the following permissions: catalogue ill list_borrowers 7. Log in as the new staff member. 8. Observe the table never loads. 9. Apply the patch. 10. Refresh the page as the new staff member. 11. Observe the table loads and the patron says "A patron from another library" 12. Log back in as the superlibrarian and confirm you can still see the patron information. 13. Sign off Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Status|Passed QA |Patch doesn't apply QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe the strings here show the same problem bug 38450 fixes. Please review! (also needs a rebase) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #3)
I believe the strings here show the same problem bug 38450 fixes. Please review! (also needs a rebase)
It is because I have bug 38450 ready to push on my branch before this one (explains the problem and the conflict). I wanted to push and come back to this, but have issues with the git repository. I am setting it back to PQA for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the interlibrary release notes| |loan (ILL) requests table | |so that it loads (instead | |of saying "Processing") | |when library groups are | |used, and: | |- the library | |group has the feature | |"Limit patron visibility to | |libraries within this group | |for members" (Limit patron | |data access by group) set | |- | |library staff don't have | |permission to view patron | |information from any | |libraries | |(view_borrower_infos_from_a | |ny_libraries). | | | |The ILL | |table now loads, and shows | |"A patron from another | |library" for the patron | |details. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38530 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org