https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #1 from Michael Adamyk <madamyk@ckls.org> --- +1 This would be great if it could be applied to all notices using Template Toolkit (particularly ISSUE and HOLD slips). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Thibault Keromnès <thibault.keromnes@univ-paris8.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibault.keromnes@univ-pari | |s8.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com Blocks|36270 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 [Bug 36270] Remove special handling for <<borrower-attribute:CODE>> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Annoyingly the extended_attributes accessor is also set to be a setter which means it won't pass through any filters you want to pass.. we should really rectify that. In my opinion we should have two simple accessors that both accept standard dbic query filters. * extended_attributes($where, $attr); * extended_attribute($where,$attr); We wrap our DBIx::Clas objects and thus remove the nice easy scalar handling of _rs on accessors which means we also have to deal with that in 'clever' ways at the TT level.. I can't remember the details for that off the top of my head though. We really need to document all this better somewhere in short. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

In my opinion we should have two simple accessors that both accept standard dbic query filters.

* extended_attributes($where, $attr); * extended_attribute($where,$attr);

I like the look of this and I think you have made a very good point to make it easier to use. This will help people creating notices, but also be generally useful. In your example code: $attr would be the attribute code. What is $where here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36505 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15278 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278 [Bug 15278] [Omnibus] Port default slips and notices from bespoke syntax to Template Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277 [Bug 15277] Add Template Toolkit syntax for slips and notices to editor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169049&action=edit Bug 30657: Unit tests This patch adds some basic unit tests for dynamically added accessors based on extended patron attributes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Bug 20443 adds Koha::Patron::get_extended_attribute_value which works for non-repeatable attributes fwiw. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169049|0 |1 is obsolete| | --- Comment #15 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 169056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169056&action=edit Bug 30657: Unit tests This patch adds some basic unit tests for dynamically added accessors based on extended patron attributes. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #17 from Brendan Lawlor <blawlor@clamsnet.org> --- Test notes: This worked but I found the name of the object was borrower instead of patron: [% borrower.party_mode | html %] The test Patron.t passed everything, but the qa script returned one failure: FAIL Koha/Patron.pm FAIL critic # TestingAndDebugging::ProhibitNoStrict: Got 1 violation(s). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36270 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36270 [Bug 36270] Remove special handling for <<borrower-attribute:CODE>> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- I'm going to be away the next few days, but I'll take a look at this next week -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Well.. I did actually have some code that does it in an autoload.. we stripped it from another submission recently.. I'll dig it out -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Ray Delahunty from comment #23)

(In reply to Martin Renvoize (ashimema) from comment #18)

...

We're really inconsistent in our notice variables unfortunately.. sometimes it's borrower, sometimes it's patron

[...] encourage end users to understand the relationships between things to be able to lookup the information they need via object traversal.

Am I off on a tangent here? This may be one of the reasons we librarians trying to use template toolkit to tidy up our notices struggle with TT. The table is borrowers in Koha but in template toolkit it is borrower. I'm gradually knowing what to use (not that I know why). Is there something like a schema for TT (probably a silly question), or can the TT variables (accessors??) gradually replace the alligator code on the left hand side of the notice design interface?

Unfortunately Ray it's not quite as simple as that :(. There's lots of history here.. and some technical challenges too. Notices are all generated by called to a method called 'GetPreparedLetter'.. that method is passed the template (which you define in your notices) and a "bunch of variables" the template can use. The challenge comes in identifying which variables are likely to get passed into the call to GetPreparedLetter so you can use them in your template.. it's a bit of a 'chicken and the egg' problem.. before we call the method we can't know what's in there.. but we can't call the method until we have a template to pass it.. but how does the person building the template know what variables that can use to build their template? I've been wanting for a long time to work on cleaning up our notice generation and write such a schema so the notice editor can definitely know what variables it's getting passed for each notice type and you can therefore build notices with more knowledge. (right now the <<>> helpers are a 'best guess' and often get it wrong). Back to this bug.. the aim here is to make extended patron attributes more accessible for any notice that pass passed a patron object.. said patron objects might be exposed with various variable names.. most often 'borrower'.. but I've also seen 'librarian', 'patron', 'user', 'author' etc etc in use... we need that schema writing and maintaining in the future. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169057|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173818&action=edit Bug 30657: Dynamically add attribute accessors This patch adds dynamic creation of accessors for extended patron attributes based on attribute code. It should work for Koha::Patron objects resulting from calls to Koha::Patron->new(), Koha::Patrons->search, Koha::Patrons->find and any relations that return a Koha::Patron object. We return a single value for non-repeatable attributes and an arrayref of values for repeatable ones. This should make it simple to access such attributes in Koha Notice Templates. Simply use the 'code' in your variables.. example: You've added a 'smartcard' extended attribute to your system, you would refer to it in your notice as [% patron.smartcard | html %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173819|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173901&action=edit Bug 30657: Move to AUTOLOAD -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173902&action=edit Bug 30657: Try parent method first This patch adds a try/catch inside the Koha::Patron AUTOLOAD to try and find the method on the parent, including it's AUTOLOAD, prior to running the local AUTOLOAD code to generate attribute accessors and then use the called method. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173818|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173911&action=edit Bug 30657: Dynamically add attribute accessors This patch adds dynamic creation of accessors for extended patron attributes based on attribute code. It should work for Koha::Patron objects resulting from calls to Koha::Patron->new(), Koha::Patrons->search, Koha::Patrons->find and any relations that return a Koha::Patron object. We return a single value for non-repeatable attributes and an arrayref of values for repeatable ones. This should make it simple to access such attributes in Koha Notice Templates. Simply use the 'code' in your variables.. example: You've added a 'smartcard' extended attribute to your system, you would refer to it in your notice as [% patron.smartcard | html %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173902|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173913&action=edit Bug 30657: Try parent method first This patch adds a try/catch inside the Koha::Patron AUTOLOAD to try and find the method on the parent, including it's AUTOLOAD, prior to running the local AUTOLOAD code to generate attribute accessors and then use the called method. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_05, | |roadmap_24_11, | |roadmap_25_05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #37 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #36)

Have you discussed adding a prefix to those accessors for safety? Something like `attr_$code`, for example.

For ILL that's exactly what we did.. but you also won't hit the attribute accessor here if you clash with an existing patron field name. Honestly, I wasn't sure which way to jump, but the basic code only felt nicer looking to me for end users. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- This is nice but could be confusing. I would prefer an explicit way to retrieve the extended attributes. patron.get_extended_attribute("attribute") patron.extended_attributes.get("attribute") patron.extended_attributes["attribute"] I don't think adding (black) magic for people writing template notices is a good idea. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #40 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #38)

This is nice but could be confusing. I would prefer an explicit way to retrieve the extended attributes.

patron.get_extended_attribute("attribute") patron.extended_attributes.get("attribute") patron.extended_attributes["attribute"]

I don't think adding (black) magic for people writing template notices is a good idea.

I talk about exactly that in comment #19. The general replies have been they prefer these as far as I can see. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173911|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178687&action=edit Bug 30657: Dynamically add attribute accessors This patch adds dynamic creation of accessors for extended patron attributes based on attribute code. It should work for Koha::Patron objects resulting from calls to Koha::Patron->new(), Koha::Patrons->search, Koha::Patrons->find and any relations that return a Koha::Patron object. We return a single value for non-repeatable attributes and an arrayref of values for repeatable ones. This should make it simple to access such attributes in Koha Notice Templates. Simply use the 'code' in your variables.. example: You've added a 'smartcard' extended attribute to your system, you would refer to it in your notice as [% patron.smartcard | html %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173913|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178689&action=edit Bug 30657: Try parent method first This patch adds a try/catch inside the Koha::Patron AUTOLOAD to try and find the method on the parent, including it's AUTOLOAD, prior to running the local AUTOLOAD code to generate attribute accessors and then use the called method. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Martin Renvoize (ashimema) from comment #40)

(In reply to Jonathan Druart from comment #38)

...

This is nice but could be confusing. I would prefer an explicit way to retrieve the extended attributes.

patron.get_extended_attribute("attribute") patron.extended_attributes.get("attribute") patron.extended_attributes["attribute"]

I don't think adding (black) magic for people writing template notices is a good idea.

I talk about exactly that in comment #19. The general replies have been they prefer these as far as I can see.

Ok but then we are now 2 to prefer something else, don't we? :D With this approach a clash is also possible with existing attributes (what you also said already). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- It is pretty easy for me to get in trouble when writing notices: -Created a attribute called 'TEST' -Called it like this in an ISSUESLIP, borrower.TEST -It works -Tried borrower.text -Get ERROR PROCESSING TEMPLATE: undef error - The method Koha::Patron->test is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #50 from Lisette Scheer <lisette@bywatersolutions.com> --- I think just doing borrower.{attr code} is too dangerous for future possibility of fields added. not sure if borrower_attr.{cod} or similar might be better? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #52 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This functionality would be helpful to get completed. I've just seen an example of a library using a script in their HOLD_SLIP to make the content differ based on a patron attribute. It would be simpler and more stable if they could do that with TT. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #54 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 209026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209026&action=edit Bug 30657: Make patron attributes available via Template Toolkit in notices Add Koha::Patron->extended_attribute_values, which returns a hashref of the patron's extended attribute values keyed by attribute type code. Repeatable types map to an arrayref (empty when there are no values), non-repeatable types to the single value (undef when unset). This makes the attributes easy to reach from notices: [% borrower.extended_attribute_values.UNCLE %] [% FOREACH nick IN borrower.extended_attribute_values.NICKNAMES %] [% nick | html %] [% END %] Earlier revisions of this patch added an accessor per attribute code (borrower.UNCLE), generated through AUTOLOAD. As noted in QA, that could collide with existing or future Koha::Patron methods and columns, and made every missing method call query the attribute types. Keeping the attributes under a single, explicitly named accessor avoids both, and needs no dynamic method generation. To test: 1. Run the unit tests inside KTD: ktd --shell --run 'prove t/db_dependent/Koha/Patron.t' 2. In Administration > Patron attribute types, create two types: - UNCLE, not repeatable - NICKNAMES, repeatable 3. Edit a patron and set UNCLE to BOB and two values for NICKNAMES, e.g. Al and Alex. 4. In Tools > Notices & slips, edit the HOLD_SLIP (or any slip that receives the patron as `borrower`) and add to its content: [% IF borrower.extended_attribute_values.UNCLE == 'BOB' %]Bob is your uncle[% END %] [% FOREACH nick IN borrower.extended_attribute_values.NICKNAMES %] Nickname: [% nick | html %] [% END %] 5. Place a hold for that patron and print the hold slip (or use the notice preview where available) and confirm the output shows "Bob is your uncle" and both nicknames. 6. Confirm that an attribute type that has no value for the patron renders as empty and does not cause an error. 7. Sign off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178687|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #55 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks Lisette and David. I agree that a bare `borrower.CODE` is too risky: attribute codes are free text and could shadow existing or future Koha::Patron methods and columns. I've reworked the patch (attachment 209026, replacing the earlier series, which I have obsoleted). The per-code accessors and AUTOLOAD are gone. Instead there is a single, explicitly named method, Koha::Patron->extended_attribute_values, which returns a hashref keyed by attribute code (repeatable types as an arrayref, always present; non-repeatable as the value or undef): [% borrower.extended_attribute_values.UNCLE %] [% FOREACH nick IN borrower.extended_attribute_values.NICKNAMES %] [% nick | html %] [% END %] A code like "surname" stays under the hash, so it can never shadow the patron's own accessor (there is a test for that), and there is no dynamic method generation or extra query on missing method calls. I also checked it by rendering a Template Toolkit snippet against a patron with both attribute kinds. If people would prefer a different name for the method, it is easy to change, so please say if so. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|25.05 |26.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #209026|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30657 --- Comment #57 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 209278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=209278&action=edit Bug 30657: Make patron attributes available via Template Toolkit in notices Add Koha::Patron->extended_attribute_values, which returns a hashref of the patron's extended attribute values keyed by attribute type code. Repeatable types map to an arrayref (empty when there are no values), non-repeatable types to the single value (undef when unset). This makes the attributes easy to reach from notices: [% borrower.extended_attribute_values.UNCLE %] [% FOREACH nick IN borrower.extended_attribute_values.NICKNAMES %] [% nick | html %] [% END %] Earlier revisions of this patch added an accessor per attribute code (borrower.UNCLE), generated through AUTOLOAD. As noted in QA, that could collide with existing or future Koha::Patron methods and columns, and made every missing method call query the attribute types. Keeping the attributes under a single, explicitly named accessor avoids both, and needs no dynamic method generation. To test: 1. Run the unit tests inside KTD: ktd --shell --run 'prove t/db_dependent/Koha/Patron.t' 2. In Administration > Patron attribute types, create two types: - UNCLE, not repeatable - NICKNAMES, repeatable 3. Edit a patron and set UNCLE to BOB and two values for NICKNAMES, e.g. Al and Alex. 4. In Tools > Notices & slips, edit the HOLD_SLIP (or any slip that receives the patron as `borrower`) and add to its content: [% IF borrower.extended_attribute_values.UNCLE == 'BOB' %]Bob is your uncle[% END %] [% FOREACH nick IN borrower.extended_attribute_values.NICKNAMES %] Nickname: [% nick | html %] [% END %] 5. Place a hold for that patron and print the hold slip (or use the notice preview where available) and confirm the output shows "Bob is your uncle" and both nicknames. 6. Confirm that an attribute type that has no value for the patron renders as empty and does not cause an error. 7. Sign off Signed-off-by: Anna Stalter <staltera@hamiltoneastpl.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.