[Bug 26540] New: Issue Credit with Cash Registers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Bug ID: 26540 Summary: Issue Credit with Cash Registers Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If a library system has enabled Cash Registers but one branch does not use this. When using the Issue Credit - CASH option from the Accounting Module, an Internal Server Error will occur. 1. Turn on Cash Registers 2. Set up a Cash Register for branch A 3. Log into Branch B and try to issue credit with CASH - this will not work and give an ISE. Other options, such as Check, Credit card, etc will work but not the option for Cash. Understandably, it is because there is not a place for the cash to come from if no cash register is enabled. But I can see this an issue for multi-branch systems where some want to use the Cash register option,but others do not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, you are indeed correct and the error is partially deliberate to ensure a cash register is set if the preference is set to use registers. So, are you suggesting that some branches may not want to use registers even though the global preference is set to require them. I'm just trying to understand how to correctly catch when one is missing but should be present... Should one be able to pay out in cash without a register but at a branch that does have at least one register for example? Should the 'UseCashRegisters' preference be set at the branch level? Or, should we just check for the presence of at least one register at a branch and fall into the required mode then? Happy to chat and code it up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #2 from Kelly McElligott <kelly@bywatersolutions.com> --- Martin, Thank you for commenting. I would say, making the 'UseCashRegisters' preference be set at the branch level would probably be ideal. Because I can see some branches not using cash registers and this would cause issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111137&action=edit Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction typy, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 [Bug 24786] Allow setting a cash register for a login session -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This first patch just adds appropriate alerts and disabled the CASH type from being selected if the branch does not yet have registers associated with it. I'm still contemplating how to set the preference at a branch level.. Options: Set the preference at the branch level so if enabled for a branch but a branch is lacking register definitions we alert and require at least one register to be added... or.. leave the preference at system level but drop the error message for if no registers are defined at a branch yet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Issue Credit with Cash |Server error when |Registers |aattempting to issue cash | |credit with | |UseCashRegisters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Server error when |Server error when |aattempting to issue cash |attempting to issue cash |credit with |credit with |UseCashRegisters |UseCashRegisters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Bug 26540 depends on bug 24786, which changed state. Bug 24786 Summary: Allow setting a cash register for a login session and configuring library-default cash registers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24786 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31513 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- no longer applies cleanly to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111137|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168234&action=edit Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction typy, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and ready for testing again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168234|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168239&action=edit Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction type, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch. Test plan 1) Enable 'UseCashRegisters' 2) Add a credit to a user account 3) Attempt to 'Issue payout' of the credit to the user and note 3a) A new blue info message appears in the modal letting you know that you cannot issue a payout of type 'Cash' to the user without first adding a cash register. (If you have the correct permissions, you will also see a button in that info box allowing you to add said register) 3b) You will not see either the payment type or registers pulldown in the modal 4) Add at least one new 'PAYMENT_TYPE' authorized value 5) Repeat step 3 5a) Note the blue info message still appears 5b) You may now select a payment type as defined in step 4, however the 'Cash' option is not available. 5c) There is still not an option to select a cash register 6) Add a cash register for your branch 7) Repeat step 3 7a) You will no longer see the blue info box 7b) You should be able to select 'Cash' from the 'Payment type' options 7c) You will be able to select your cash register Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Patch does not apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |unspecified -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168239|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173152&action=edit Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction type, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch. Test plan 1) Enable 'UseCashRegisters' 2) Add a credit to a user account 3) Attempt to 'Issue payout' of the credit to the user and note 3a) A new blue info message appears in the modal letting you know that you cannot issue a payout of type 'Cash' to the user without first adding a cash register. (If you have the correct permissions, you will also see a button in that info box allowing you to add said register) 3b) You will not see either the payment type or registers pulldown in the modal 4) Add at least one new 'PAYMENT_TYPE' authorized value 5) Repeat step 3 5a) Note the blue info message still appears 5b) You may now select a payment type as defined in step 4, however the 'Cash' option is not available. 5c) There is still not an option to select a cash register 6) Add a cash register for your branch 7) Repeat step 3 7a) You will no longer see the blue info box 7b) You should be able to select 'Cash' from the 'Payment type' options 7c) You will be able to select your cash register Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- When a quick fix isn't quick :S Another rebase for the mill -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173152|0 |1 is obsolete| | --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179011&action=edit Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction type, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch. Test plan 1) Enable 'UseCashRegisters' 2) Add a credit to a user account 3) Attempt to 'Issue payout' of the credit to the user and note 3a) A new blue info message appears in the modal letting you know that you cannot issue a payout of type 'Cash' to the user without first adding a cash register. (If you have the correct permissions, you will also see a button in that info box allowing you to add said register) 3b) You will not see either the payment type or registers pulldown in the modal 4) Add at least one new 'PAYMENT_TYPE' authorized value 5) Repeat step 3 5a) Note the blue info message still appears 5b) You may now select a payment type as defined in step 4, however the 'Cash' option is not available. 5c) There is still not an option to select a cash register 6) Add a cash register for your branch 7) Repeat step 3 7a) You will no longer see the blue info box 7b) You should be able to select 'Cash' from the 'Payment type' options 7c) You will be able to select your cash register Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 179012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179012&action=edit Bug 26540: (follow-up) Update patch with CSRF protections -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #14 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Rebased on main but CSRF protections and, I guess, modal rework broke the use of form inside the modal (which is a form). Hence I had rework the button/form into a single link. The rest is working as described, except the message is not blue /o/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179011|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187219&action=edit Bug 26540: Remove 'CASH' type from 'refund' and 'payout' This patch removes the 'CASH' transaction type, hides the register selection and adds an alert to the Payout and Refund modals on the boraccount page if there are no cash registers yet defined at the for the current branch. Test plan 1) Enable 'UseCashRegisters' 2) Add a credit to a user account 3) Attempt to 'Issue payout' of the credit to the user and note 3a) A new blue info message appears in the modal letting you know that you cannot issue a payout of type 'Cash' to the user without first adding a cash register. (If you have the correct permissions, you will also see a button in that info box allowing you to add said register) 3b) You will not see either the payment type or registers pulldown in the modal 4) Add at least one new 'PAYMENT_TYPE' authorized value 5) Repeat step 3 5a) Note the blue info message still appears 5b) You may now select a payment type as defined in step 4, however the 'Cash' option is not available. 5c) There is still not an option to select a cash register 6) Add a cash register for your branch 7) Repeat step 3 7a) You will no longer see the blue info box 7b) You should be able to select 'Cash' from the 'Payment type' options 7c) You will be able to select your cash register Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179012|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 187220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187220&action=edit Bug 26540: (follow-up) Update patch with CSRF protections Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- When I go to tidy this the script catches a stray </p> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- 3a) A new blue info message appears in the modal letting you know that you cannot issue a payout of type 'Cash' to the user without first adding a cash register. (If you have the correct permissions, you will also see a button in that info box allowing you to add said register) 3b) You will not see either the payment type or registers pulldown in the modal After this step I press confirm in the modal and get: Exception 'Koha::Exceptions::MissingParameter' thrown 'The payout_type parameter is mandatory' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26540 --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---
After this step I press confirm in the modal and get:
Exception 'Koha::Exceptions::MissingParameter' thrown 'The payout_type parameter is mandatory'
But at this point I have not configured a cash register for my logged in branch. So maybe this is wanted behavior? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org