https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Punctuation: Completeness |Punctuation: Completeness |of the reproduction code␠: |of the reproduction code␠:, | |... --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also: Number of units under embargo␠: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_325j.tt:121 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 Ben Foster <headtummy@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This removes spaces before release notes| |the colons for the | |unimarc_field_325h.pl and | |unimarc_field_325j.pl value | |builder form field labels. CC| |david@davidnind.com Comma delimited| |Catalyst list of Sponsors| | Sponsorship status|--- |Sponsored Assignee|oleonard@myacpl.org |headtummy@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 191847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191847&action=edit Bug 32285: (QA follow-up) Remove additional spaces before colons 325$j This removes two additional spaces before colons for the UNIMARC 325$j value builder (unimarc_field_325j.pl plugin). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Start up KTD with UNIMARC: KOHA_MARC_FLAVOUR=unimarc ktd 2. Update the default framwork so the 325$h and 325$j use the respective plugins: - Go to Administartion > Cataloging > MARC bibliographic frameworks - For the default framework select Actions > MARC structure - Search for the 325 tag - Edit the subfields: Actions > Edit subfields - For the 325$h subfield add the unimarc_field_325h.pl plugin - For the 325$j subfield add the unimarc_field_325j.pl plugin 3. Edit any record 4. For the 325 tag, click "Reproduction Note" to show all subfields 5. Click the tag builder icon next to the 325$h subfield 6. Notice that the label for teh field has a space before the colon: - Completeness of the reproduction code : 7. Repeat for the 325$j subfield, and note that all the labels have a space before the colon as well: - Terms of access to the reproduction : - Qualifier type : - Unit under embargo : - Number of units under embargo : 8. Apply the patch 9. Repeat steps 3-7 - there are now no space before the colon for any of the field labels. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 --- Comment #9 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32285 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.