[Bug 41586] New: Spacing problem in display of patron names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Bug ID: 41586 Summary: Spacing problem in display of patron names Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Under some circumstances there are extra or missing spaces around the information displayed by patron-title.inc, particularly the "othername" value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191216&action=edit Bug 41586: Fix spacing problem in display of patron names This patch updates patron-title.inc which generates the output of patron names throughout Koha. Some whitespace is added to the display of borrowers.othernames and spaces removed from the maybe_span WRAPPER. To test, apply the patch and create or edit a patron in the staff client. - Add a value to all the name fields: Surname, first name, preferred name, middle name, and other name. - Save the patron and check the display of their name on the patron detail page. The name in the page heading and sidebar should have correct spacing. - Place a hold for that patron to be picked up at the logged-in library. - Go to Circulation -> Holds to pull and confirm that the patron name is displayed correctly (this tests the display when the format is lastname, firstname). - Edit the same patron and change its category to an organizational one (Inter-Library Loan, Library, or School in the sample data). - View the same pages listed above and confirm that the name displays correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 manvisharma1006@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 manvisharma1006@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191216|0 |1 is obsolete| | --- Comment #2 from manvisharma1006@gmail.com --- Created attachment 191822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191822&action=edit Bug 41586: Fix spacing problem in display of patron names This patch updates patron-title.inc which generates the output of patron names throughout Koha. Some whitespace is added to the display of borrowers.othernames and spaces removed from the maybe_span WRAPPER. To test, apply the patch and create or edit a patron in the staff client. - Add a value to all the name fields: Surname, first name, preferred name, middle name, and other name. - Save the patron and check the display of their name on the patron detail page. The name in the page heading and sidebar should have correct spacing. - Place a hold for that patron to be picked up at the logged-in library. - Go to Circulation -> Holds to pull and confirm that the patron name is displayed correctly (this tests the display when the format is lastname, firstname). - Edit the same patron and change its category to an organizational one (Inter-Library Loan, Library, or School in the sample data). - View the same pages listed above and confirm that the name displays correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Manvi <manvisharma1006@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191822|0 |1 is obsolete| | --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 191962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191962&action=edit Bug 41586: Fix spacing problem in display of patron names This patch updates patron-title.inc which generates the output of patron names throughout Koha. Some whitespace is added to the display of borrowers.othernames and spaces removed from the maybe_span WRAPPER. To test, apply the patch and create or edit a patron in the staff client. - Add a value to all the name fields: Surname, first name, preferred name, middle name, and other name. - Save the patron and check the display of their name on the patron detail page. The name in the page heading and sidebar should have correct spacing. - Place a hold for that patron to be picked up at the logged-in library. - Go to Circulation -> Holds to pull and confirm that the patron name is displayed correctly (this tests the display when the format is lastname, firstname). - Edit the same patron and change its category to an organizational one (Inter-Library Loan, Library, or School in the sample data). - View the same pages listed above and confirm that the name displays correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Manvi <manvisharma1006@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41586 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org