[Bug 12131] New: C4/TmplToken.pm has an unnecessary dependency on Exporter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Bug ID: 12131 Summary: C4/TmplToken.pm has an unnecessary dependency on Exporter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: colin.campbell@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org TmplToken has a dependency on Exporter but does not export anything all subroutines being called via a TmplToken object looks like a bit of boilerplate got in the module. Lets remove that and the "burden" of compiling it every time -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 27477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27477&action=edit proposed patch Trivial patch does not affect functionality - removes an unused dependency. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27477|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 27518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27518&action=edit Bug 12131: Remove unused dependency on Exporter C4::TmplToken depends on Exporter but does not use any of its facilities. Removed the dead code so it does not clog up the source and waste compilation time Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Module still compiles correctly; t/TmplToken.t passes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27518|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27608&action=edit [PASSED QA] Bug 12131: Remove unused dependency on Exporter C4::TmplToken depends on Exporter but does not use any of its facilities. Removed the dead code so it does not clog up the source and waste compilation time Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Module still compiles correctly; t/TmplToken.t passes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12131 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org