[Bug 12118] New: Unnecessary YUI assets included in offline circ manifest
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Bug ID: 12118 Summary: Unnecessary YUI assets included in offline circ manifest Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org These files are not used by any page other than basketgroup.tt. They can be safely removed from the offline circ manifest. [% themelang %]/lib/yui/button/button-min.js [% themelang %]/lib/yui/container/container_core-min.js [% themelang %]/lib/yui/menu/menu-min.js [% themelang %]/lib/yui/utilities/utilities.js -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27367&action=edit Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I've never used the offline circulation methods. Can you use either the Firefox plugin or the desktop app? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- This bug is relevant only to the "Built-in offline circulation interface" (circ/offline.pl). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27367|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 27532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27532&action=edit Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=11218 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27532|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27615&action=edit [PASSED QA] Bug 12118 - Unnecessary YUI assets included in offline circ manifest The offline circulation asset manifest includes some YUI JavaScript files which are no longer used by any template in Koha except for acquisitions/basketgroup.tt. This patch removes them from the manifest. To test, apply the patch and test offline circulation. Everything should work correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> http://bugs.koha-community.org/show_bug.cgi?id=11218 Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12118 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org