[Bug 27521] New: Add new item type headset image for carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Bug ID: 27521 Summary: Add new item type headset image for carredart Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: liav@wgc.school.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 --- Comment #1 from Ava <liav@wgc.school.nz> --- Created attachment 115641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115641&action=edit Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Ava <liav@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |liav@wgc.school.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the itemtype images can be displayed in the OPAC and in the staff interface we currently need to add them in 2 places as one cannot access the image files of the other. Can you also add the files to koha-tmpl/opac-tmpl/bootstrap/itemtypeimg/carredart please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115708&action=edit Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115641|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115747&action=edit Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115708|0 |1 is obsolete| | --- Comment #5 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115748&action=edit Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #6 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. Test Plan 1. Go to Administration>item types>modify item type 2. There should be a headset item type under the carredart 3. Modify the item type so the headset icon is used 4. Search for an item using the above item type 5. Check that the icon displays properly in both the staff client and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add new item type headset |Adding new itemtype headset |image for carredart |image for carredart --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, please see comment on bug 27522 too. Can you please clear up where the icon was taken from before we add it to Koha? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 122932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122932&action=edit Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Projec... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|liav@wgc.school.nz |oleonard@myacpl.org Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115747|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 123272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123272&action=edit Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115748|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 123273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123273&action=edit Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122932|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 123274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123274&action=edit Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Projec... Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds a release notes| |headset image to the | |carredart icons for item | |types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds a |This enhancement adds a release notes|headset image to the |headset image to the |carredart icons for item |carredart icon set for item |types. |types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123272|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123927&action=edit Bug 27521: Add new item type headset image for carredart TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123273|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123928&action=edit Bug 27521: (follow-up) Add copy of image to carredart icons in the OPAC Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123274|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123929&action=edit Bug 27521: (follow-up) Adding new itemtype headset image for carredart This patch adds new version of the image which was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Projec... Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The question here is which icon to keep - I like Owen's a little better as it's not as heavy and matches the style of the other carredart icons a little better. But then we should possibly only add his to the repo and remove the first 2 patches? Owen, could you provide your icon as a 'only' patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123927|0 |1 is obsolete| | Attachment #123928|0 |1 is obsolete| | Attachment #123929|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123939&action=edit Bug 27521: Add new item type headset image for carredart The image added by this patch was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Projec... TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123939|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 123955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123955&action=edit Bug 27521: Add new item type headset image for carredart The image added by this patch was created based on a CC0-licensed public domain image: https://commons.wikimedia.org/wiki/File:Headphones_(17471)_-_The_Noun_Projec... TEST PLAN: 1) Go to administration 2) Go to item types 3) Click edit on one of the item types 4) Go to the category "carredart" 5) Check that there is a small headset icon Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27505 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Attachment #123955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115747|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115748|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Based on bug 27522 comment 22 I have decided to restore the original version of the icon -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27521 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org