[Bug 40953] New: marc_ordering_process.pl broken due to accidental newline
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Bug ID: 40953 Summary: marc_ordering_process.pl broken due to accidental newline Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Executing marc_ordering_process.pl will fail to run with the following errors: /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 21: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 23: marc_ordering_process.pl: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 25: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --confirm]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --verbose]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: ./marc_ordering_process.pl: No such file or directory /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 29: or,: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 31: 0: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 33: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 35: This: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 36: If: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 38: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 40: =over: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: syntax error near unexpected token `newline' /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: `=item B<-v|--verbose>' This is due to an inadvertent newline before the shebang of the script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 187429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187429&action=edit Bug 40953: marc_ordering_process.pl broken due to accidental newline Executing marc_ordering_process.pl will fail to run with the following errors: /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 21: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 23: marc_ordering_process.pl: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 25: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --confirm]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --verbose]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: ./marc_ordering_process.pl: No such file or directory /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 29: or,: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 31: 0: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 33: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 35: This: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 36: If: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 38: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 40: =over: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: syntax error near unexpected token `newline' /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: `=item B<-v|--verbose>' This is due to an inadvertent newline before the shebang of the script. Test Plan: 1) Run ./misc/cronjobs/marc_ordering_process.pl 2) Note the error 3) Apply this patch 4) Run ./misc/cronjobs/marc_ordering_process.pl 5) No error! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34355 [Bug 34355] Automated MARC record ordering process -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187429|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187430&action=edit Bug 40953: marc_ordering_process.pl broken due to accidental newline Executing marc_ordering_process.pl will fail to run with the following errors: /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 21: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 23: marc_ordering_process.pl: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 25: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --confirm]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: --verbose]: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 27: ./marc_ordering_process.pl: No such file or directory /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 29: or,: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 31: 0: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 33: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 35: This: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 36: If: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 38: =head1: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 40: =over: command not found /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: syntax error near unexpected token `newline' /usr/share/koha/bin/cronjobs/marc_ordering_process.pl: line 42: `=item B<-v|--verbose>' This is due to an inadvertent newline before the shebang of the script. Test Plan: 1) Run ./misc/cronjobs/marc_ordering_process.pl 2) Note the error 3) Apply this patch 4) Run ./misc/cronjobs/marc_ordering_process.pl 5) No error! Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Trivial fix to a big problem, straight PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.05 |25.11.00,25.05.05,24.11.11 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to stable |Pushed to oldstable --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.11 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40953 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org