[Bug 28488] New: Javascript error in self-checkout (__ is not defined)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Bug ID: 28488 Summary: Javascript error in self-checkout (__ is not defined) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org datatables_20.1200050.js:32 Uncaught ReferenceError: __ is not defined at datatables_20.1200050.js:32 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed on /cgi-bin/koha/sco/sco-main.pl I wonder if this could affect translations, as __( is used for Javascript translation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I was wondering that as well. What's the difference between __() and _()? I've noticed some cases where they'll both be used close to each other. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- __() is used in .js files, _() in TT files. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #3)
__() is used in .js files, _() in TT files.
Ahh interesting. I wish I remembered where I saw the combo.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 121687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121687&action=edit Bug 28488: Javascript error in self-checkout (__ is not defined) This patch adds inclusion of the internationalization JavaScript which is required by the newest version of the DataTables include. It references the double-underscore function provided by i18n.js. To test, apply the patch and log into the self-checkout system as a user with checkouts. The table of checkouts should display correctly and there should be no JavaScript errors in the console. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121687|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 121695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121695&action=edit Bug 28488: Javascript error in self-checkout (__ is not defined) This patch adds inclusion of the internationalization JavaScript which is required by the newest version of the DataTables include. It references the double-underscore function provided by i18n.js. To test, apply the patch and log into the self-checkout system as a user with checkouts. The table of checkouts should display correctly and there should be no JavaScript errors in the console. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121695|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121865&action=edit Bug 28488: Javascript error in self-checkout (__ is not defined) This patch adds inclusion of the internationalization JavaScript which is required by the newest version of the DataTables include. It references the double-underscore function provided by i18n.js. To test, apply the patch and log into the self-checkout system as a user with checkouts. The table of checkouts should display correctly and there should be no JavaScript errors in the console. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.01 released in| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.07 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28488 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32701 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32701 [Bug 32701] Self checkout help page lacks required I18N JavaScript -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org