[Bug 39587] New: Patron surname missing from Contact information list on moremember.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Bug ID: 39587 Summary: Patron surname missing from Contact information list on moremember.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Go to members/moremember.pl?borrowernumber=X where X is borrowernumber of a patron with a surname 2. Look under contact information and notice surname is missing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 180732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180732&action=edit Bug 39587: Add surname to contact infomration list on moremember.tt To test: 1. Go to members/moremember.pl?borrowernumber=X where X is borrowernumber of a patron with a surname 2. Look under contact information and notice surname is missing. 3. APPLY PATCH and look again. 4. Surname should be included. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180732|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 180733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180733&action=edit Bug 39587: Add surname to contact infomration list on moremember.tt To test: 1. Go to members/moremember.pl?borrowernumber=X where X is borrowernumber of a patron with a surname 2. Look under contact information and notice surname is missing. 3. APPLY PATCH and look again. 4. Surname should be included. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180733|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182188&action=edit Bug 39587: Add surname to contact infomration list on moremember.tt To test: 1. Go to members/moremember.pl?borrowernumber=X where X is borrowernumber of a patron with a surname 2. Look under contact information and notice surname is missing. 3. APPLY PATCH and look again. 4. Surname should be included. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Weird how I've never noticed that.. solid improvement. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron surname missing from |Patron surname missing from | Contact information list |contact information list on |on moremember.tt |patron details tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah surname is on several other places, so minor. I prefer not backport to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Depends on| |28633 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize (ashimema) from comment #4)
Weird how I've never noticed that.. solid improvement.
Passing QA
So the reason you probably didn't notice it is because "First name" is a relatively new addition. It was added by bug 28633 in 24.11 because the name shown on moremember.pl uses the preferred name. The way preferred name and first name have been handled is not great. However, we are where we are now. We were talking locally about adding surname (glad it's already been done - thanks Lucas!), and adding middle name and preferred name as labels to make it really clear which names are which in the contact information. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 [Bug 28633] Add a preferred name field to patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #6)
Ah surname is on several other places, so minor. I prefer not backport to 24.11.x
It might be a good idea to reconsider this for a 24.11.x backport because the "First name" was added in 24.11 by bug 28633 and it's been confusing people on 24.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
(In reply to Fridolin Somers from comment #6)
Ah surname is on several other places, so minor. I prefer not backport to 24.11.x
It might be a good idea to reconsider this for a 24.11.x backport because the "First name" was added in 24.11 by bug 28633 and it's been confusing people on 24.11.
That is, I get a lot of bug reports about the missing surname. It drives me crazy haha. (I'll fix it locally but I'm sure other people must get the same reports/complaints.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41986 [Bug 41986] Names in "Contact information" need more clarity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
We were talking locally about adding surname (glad it's already been done - thanks Lucas!), and adding middle name and preferred name as labels to make it really clear which names are which in the contact information.
See bug 41986 for patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- OK I follow bug 41986 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ahhh sorry I was mixing with some other bug id. This is a trivial patch. I backport to 24.11.x for v24.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39587 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.14 released in| | Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org