[Bug 37734] New: Insert runtime parameter button is not working in Reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Bug ID: 37734 Summary: Insert runtime parameter button is not working in Reports Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: blawlor@clamsnet.org QA Contact: testopia@bugs.koha-community.org To recreate: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. click on any of the drop down option 4. Nothing happens :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 170728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170728&action=edit Bug 37734: Fix insert runtime parameter button in reports To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170728|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 170734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170734&action=edit Bug 37734: Fix insert runtime parameter button in reports To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the 'Insert release notes| |runtime parameter' when | |creating reports from SQL - | |nothing was happening when | |selecting any of the | |parameters to insert. (This | |is related to the OPAC and | |staff interface Bootstrap 5 | |upgrade in Koha 24.11.) CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Could you please add a description to the commit message, as per the commit message guidelines? https://wiki.koha-community.org/wiki/Commit_messages#Bug.2Ffeature_descripti... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170734|0 |1 is obsolete| | --- Comment #4 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 170739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170739&action=edit Bug 37734: Fix insert runtime parameter button in reports The drop down item links had two class attributes which prevented javascript from opening the modal. This patch combines the classes into one class attribute. To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170739|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 170740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170740&action=edit Bug 37734: Fix insert runtime parameter button in reports To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170740|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 170741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170741&action=edit Bug 37734: Fix insert runtime parameter button in reports The drop down item links had two class attributes which prevented javascript from opening the modal. This patch combines the classes into one class attribute. To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 --- Comment #7 from David Nind <david@davidnind.com> --- Thanks Brendan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 --- Comment #8 from Brendan Lawlor <blawlor@clamsnet.org> --- (In reply to David Nind from comment #3)
Could you please add a description to the commit message, as per the commit message guidelines? https://wiki.koha-community.org/wiki/Commit_messages#Bug. 2Ffeature_description
Thanks for the reminder. I amended the commit and reattached, but I messed something up because it took off your sign off, so I tried again and think I did it correctly the second time around :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170741|0 |1 is obsolete| | --- Comment #9 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 170775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170775&action=edit Bug 37734: Fix insert runtime parameter button in reports The drop down item links had two class attributes which prevented javascript from opening the modal. This patch combines the classes into one class attribute. To test: 1. Go to Reports > Create from SQL 2. Click the Insert runtime parameter button 3. Click on any of the drop down options 4. Nothing happens :( 5. Apply patch 6. Repeat steps 2 and 3 for all different parameters 7. Notice the modal launches :) 8. Confirm the parameters are inserted as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #10 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Looks good - thanks for the fix! Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37734 Bug 37734 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org