[Bug 10504] New: C4::Acquisition::ModOrderItem is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Bug ID: 10504 Summary: C4::Acquisition::ModOrderItem is unused Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19220&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Comment on attachment 19220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19220 Bug 10504: Remove the unused C4::Acq::ModOrderItem routine Review of attachment 19220: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10504&attachment=19220) ----------------------------------------------------------------- C4/Acquistion.pm still is exporting ModOrderItem, so we need to clean that too. grep ModOrderItem -r * C4/Acquisition.pm: &NewOrderItem &ModOrderItem &ModItemOrder -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19220|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19305&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Test plan: - git grep ModOrderItem should return no result. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19305|0 |1 is obsolete| | --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 19537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19537&action=edit [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- koha-qa.pl gives this failure FAIL C4/Acquisition.pm FAIL pod *** WARNING: No items in =over / =back list in file C4/Acquisition.pm *** ERROR: Spurious text after =cut in file C4/Acquisition.pm I don't believe this is a result of your patch though. However, looking at the diff for your patch, I see file_not_specified_in_diff, which doesn't look like something we want to have in there! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, I cannot reproduce: $ git reset --hard origin/master $ git bz apply 10504 Bug 10504 - C4::Acquisition::ModOrderItem is unused 19537 - [SIGNED-OFF] Bug 10504: Remove the unused C4::Acq::ModOrderItem routine Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10504: Remove the unused C4::Acq::ModOrderItem routine $ qa -c 1 -v 2 testing 1 commit(s) (applied to 275f405 'Bug 10514: improve visibility of Add ') OK C4/Acquisition.pm OK pod OK forbidden patterns OK valid OK critic OK cataloguing/moveitem.pl OK pod OK forbidden patterns OK valid OK critic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19537|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19650&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Confirmed, I have no idea how I got that error. However, the more important issue to me is the file_not_specified_in_diff you can see looking here: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19650&action=diff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19650|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19652&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19650|1 |0 is obsolete| | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19652|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19653&action=edit Bug 10504: Remove the unused C4::Acq::ModOrderItem routine This routine has been introduced by commit 2d90fb22d43db986547bbaa945873d6dd78aab71. The only call has been removed by commit 9eba7dc594fc0d4698da5e791d5f6f8682b2712a. So now, this routine is useless. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Kyle, I edited the lines with the commit id's in the commit message. Now this display problem is gone. But this seems to not to worry git itself, just bugzilla.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Status back to Signed off ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Excellent! Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I have no errors while running koha-qa. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #15 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10504 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org