[Bug 10274] New: UT: Acquisition.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Bug ID: 10274 Summary: UT: Acquisition.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com t/db_dependent/Acquisition.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10273 Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10270 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18197&action=edit MT10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10273 Depends on|10273 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18197|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18251&action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am not sure this one is right. It looks like the DelOrder calls are hardcoded to expect the bib records to have biblionumbers 1-3, which doesn't make sense to me. Should it perhaps be DelOrder($biblionumber1, $ordernumber1) ... etc.? Setting to In Discussion in case I am misunderstanding the code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #3)
I am not sure this one is right. It looks like the DelOrder calls are hardcoded to expect the bib records to have biblionumbers 1-3, which doesn't make sense to me. Should it perhaps be DelOrder($biblionumber1, $ordernumber1) ... etc.?
Yes, of course! I will provide a new patch. Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18251|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18661&action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This looks better, but the bookseller is not getting deleted at the end of the run. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #6)
This looks better, but the bookseller is not getting deleted at the end of the run.
:-/ Did you get an error? It should be deleted, DelBookseller is called into the END block. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18661|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 18976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18976&action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tests pass and the bookseller is deleted. I tried again and this time it worked. I must not have applied the latest patch last time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10403 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18976|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19405&action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tests pass and the bookseller is deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19406&action=edit Bug 10274: Execute sql queries into a transaction -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19405|0 |1 is obsolete| | Attachment #19406|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19620&action=edit [PASSED QA] Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Tests pass and the bookseller is deleted. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19621&action=edit [PASSED QA] Bug 10274: Execute sql queries into a transaction Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #13 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- This does not apply cleanly to 3.10.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org