[Bug 33612] New: Staff with limited permissions don't always get an expanded catalog_search bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Bug ID: 33612 Summary: Staff with limited permissions don't always get an expanded catalog_search bar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Setup a staff member with staff access permission but no circulate permissions. 2. Log in as that and on the intranet-home page notice that 'Search patron' bar across the top is not visible by default. 3. Click the 'Search patrons' link at the top, now you see the search bar. 4. This is also true on the item search page. It is because we are using the old home-search.inc when it should be the cat-search.inc If you git grep 'home-search.inc' you'll see it on these two pages. koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt: [% INCLUDE 'home-search.inc' %] koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt: [% INCLUDE 'home-search.inc' %] We can change that to cat-search.inc and remove the unused home-search.inc, I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150225&action=edit Bug 33612: Fix cat-search.inc and remove home-search.inc To test: 1. Setup a staff member with staff access permission but no circulate permissions. 2. Log in as that and on the intranet-home page notice that 'Search patron' bar across the top is not visible by default. 3. Click the 'Search patrons' link at the top, now you see the search bar. 4. This is also true on the item search page. 5. Apply patch 6. Try looking at the intranet home and item search pages again, the search bar should be expanded by default. 7. git grep 'home-search.inc' , this include should be gone along with all references to it. 8. Log in as a superlibrarian and make sure the top search bars still seem correct and default to the correct ones. https://bugs.koha-community.org/show_bug.cgi?id=33584 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150225|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 150253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150253&action=edit Bug 33612: Fix cat-search.inc and remove home-search.inc To test: 1. Setup a staff member with staff access permission but no circulate permissions. 2. Log in as that and on the intranet-home page notice that 'Search patron' bar across the top is not visible by default. 3. Click the 'Search patrons' link at the top, now you see the search bar. 4. This is also true on the item search page. 5. Apply patch 6. Try looking at the intranet home and item search pages again, the search bar should be expanded by default. 7. git grep 'home-search.inc' , this include should be gone along with all references to it. 8. Log in as a superlibrarian and make sure the top search bars still seem correct and default to the correct ones. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I amended the commit message to remove the incorrect Bugzilla link at the bottom. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #3)
I amended the commit message to remove the incorrect Bugzilla link at the bottom.
Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 33536 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- You are changing the selected tab, is that expected? mainpage now has "search catalog", it was "Checkout". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Joubu is right, the first selected tab on the start page changes with this patch. I wonder if we could get away with that, but it's certainly a behavior change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #7)
Joubu is right, the first selected tab on the start page changes with this patch. I wonder if we could get away with that, but it's certainly a behavior change
We should not try to get away with that. I think we need to keep the behavior we have now, I will return to this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33612 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35657 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org