[Bug 15086] New: Creators layout and template sql has warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 Bug ID: 15086 Summary: Creators layout and template sql has warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org When doing a hacked install: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. TEST PLAN --------- (1) Run this BEFORE applying: truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/de-DE/optional/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/es-ES/optional/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/fr-FR/2-Optionel/sample_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/it-IT/necessari/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/ru-RU/optional/print_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/uk-UA/optional/print_labels.sql truncate creator_layouts; truncate creator_templates; truncate printers_profile; source installer/data/mysql/en/optional/sample_creator_data.sql --Notice the warnings show warnings; -- Most of them are the: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. (2) Apply the patch (3) Run the database update (4) Redo step (1) -- There should be no warnings or errors NOTE: fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 44180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44180&action=edit Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_i... In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn... Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15053 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15053 [Bug 15053] sample_creator_data.sql now fails during a fresh install -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Don't forget to apply 15053 first, before applying this. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- CONFLICT (content): Merge conflict in installer/data/mysql/it-IT/necessari/sample_creator_data.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44180|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 46233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46233&action=edit Bug 15086: Creators layout and template sql has warnings When doing a hacked install off the master branch: use ... {koha database name} truncate creator_layouts; truncate creator_templates; truncate printers_profiles; source installer/data/mysql/... {name of a sample_labels type file} Warnings are generated, which may not be visible in the UI. Most of the warnings were triggered by: -/*!40000 ALTER TABLE `creator_layouts` DISABLE KEYS */; -/*!40000 ALTER TABLE `creator_layouts` ENABLE KEYS */; http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_er_i... In the Russian, the layout_name was truncated, because the layout_name was only 20. An atomic update sql and kohastructure.sql update were provided to widen it to 25. http://dev.mysql.com/doc/refman/5.7/en/error-messages-server.html#error_warn... Also fr-FR, ru-RU, and uk-UA were slightly different in structure, so the structure was made the same as the other files. See comment #1 for the test plan. NOTE: pl-PL is likely very out of date, but is not affected in this regard. it-IT was updated in Bug 15178 which added a line feed causing conflict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15086 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org