[Bug 15304] New: Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Bug ID: 15304 Summary: Norwegian patron database: translatable strings added to all po files Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr The strings in nl-search.tt are picked up for translation, but a lot of those are in Norwegian. The file should either be all in English, or excluded from translation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |magnus@libriotech.no |ity.org | CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Sorry about that! I guess we are talking about strings like "hjemmebibliotek", "opprettet" and "opprettet_av" from lines like these: [% IF ( p.hjemmebibliotek ) %]<li><span class="label">hjemmebibliotek: </span>[% p.hjemmebibliotek | html_entity %]</li>[% END %] [% IF ( p.opprettet ) %]<li><span class="label">opprettet: </span>[% p.opprettet | html_entity %]</li>[% END %] [% IF ( p.opprettet_av ) %]<li><span class="label">opprettet_av: </span>[% p.opprettet_av | html_entity %]</li>[% END %] The trouble is, those Norwegian strings just echo the field names that we get from the Natonal patron database API. (The XML elements have Norwegian names.) So on the one hand translating those field names does not make a lot of sense, but on the other hand we need to be able to translate the page as such, especially when the day comes that someone revives the "nynorsk" translation. So... The ideal would be to be able to exclude just those strings from tranlsation. Since that is not possible, I guess I better translate them into English and make sure I translate them the right way back again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 45512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45512&action=edit Bug 15304 - Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45512|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45514&action=edit [SIGNED-OFF]Bug 15304: Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> nl-search.tt translated to English -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- paxed, do you agree with this patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #5 from paxed <pasi.kallinen@pttk.fi> --- If I eyeballed the patch correctly, all the changed lines are in the format: [% IF ( p.FOO ) %]<li><span class="label">FOO: </span>[% p.FOO | html_entity %]</li>[% END %] So, guessing it could be accomplished with something like this: [%BLOCK output_nlsearch_line %] [% IF ( p.$nlvar ) %]<li><span class="label">[% nlvar %]: </span>[% p.$nlvar | html_entity %]</li>[% END %] [% END %] and then called like [% PROCESS output_nhsearch_line nlvar="hjemmebibliotek" %] [% PROCESS output_nhsearch_line nlvar="opprettet" %] etc. That would prevent the texts from showing for translation up in the first place, and does look a bit cleaner to my eyes. But I haven't tested that, so perhaps it's not possible with Template Toolkit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Magnus suggested to add the string to the po and you suggest to remove them, it's not the same approach :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- In Norway, we have to versions of Norwegian: bokmål and nynorsk. Currently, only a bokmål translation of Koha is maintained, but hopefully the nynorsk translation will be revived in the not too distant future. I think the approach that makes the most sense is the one I have taken: To translate the humanly visible labels into English, so that they can be translated back into both bokmål and nynorsk. Hiding the labels from translation will mean they are stuck in bokmål, and the nynorsk users will be unhappy some time in the future. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Magnus Enger from comment #7)
In Norway, we have to versions of Norwegian: bokmål and nynorsk. Currently, only a bokmål translation of Koha is maintained, but hopefully the nynorsk translation will be revived in the not too distant future.
That's make a lot of sense and I agree with your patch. But could you please rewrite it to avoid as much as possible new strings in the po files? for instance "Birthdate:" should be "date of birth", so that it will be automatically translated for other languages and translators won't have to translate (unnecessarily) new strings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- (In reply to Jonathan Druart from comment #8)
But could you please rewrite it to avoid as much as possible new strings in the po files? for instance "Birthdate:" should be "date of birth", so that it will be automatically translated for other languages and translators won't have to translate (unnecessarily) new strings.
Will do! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45514|0 |1 is obsolete| | --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Created attachment 45608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45608&action=edit Bug 15304 - Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Version 2: Tweak a couple of labels to be more in line with labels used elsewhere in Koha, to avoid variants when translating. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hi Magnus, can I make a sugestion? Many of the new strings are already in other parts of the code, so translation will not be an issue, but some of them differs but just a space for example, if you change <span class="label">Address: </span>[% p.m_adresse1 | html_entity %] with <span class="label">Address:</span> [% p.m_adresse1 | html_entity %] i.e., space after </span>, we will have more matches. If not we get many new (but similar) strings like this example #. SCRIPT #: intranet-tmpl/prog/en/includes/cateditor-ui.inc:24 msgid "Last changed:" msgstr "Última actualización:" +#: intranet-tmpl/prog/en/modules/members/nl-search.tt:118 +#, fuzzy, c-format +msgid "Last changed: " +msgstr "Última actualización:" + -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Magnus Enger <magnus@libriotech.no> --- Bernardo: Cool, I'll do a followup as soon as I can! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45608|0 |1 is obsolete| | --- Comment #13 from Magnus Enger <magnus@libriotech.no> --- Created attachment 45905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45905&action=edit Bug 15304 - Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Version 2: Tweak a couple of labels to be more in line with labels used elsewhere in Koha, to avoid variants when translating. Version 3: Replace e.g. "Gender: </span>" with "Gender:</span> " to avoid similar-except-for-whitespace strings in translation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45905|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 45945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45945&action=edit [SIGNED-OFF] Bug 15304: Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Version 2: Tweak a couple of labels to be more in line with labels used elsewhere in Koha, to avoid variants when translating. Version 3: Replace e.g. "Gender: </span>" with "Gender:</span> " to avoid similar-except-for-whitespace strings in translation. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> A few new strings, all previous removed. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 45978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45978&action=edit Bug 15304: Remove Norwegian strings from nl-search.tt When nl-search.pl gets data from the Norwegian national patron database, it does so in an XML format that has Norwegian element names. nl-search.pl displays the data with the Noregian element names as labels. This means Norwegian words turn up in translations, which is messy. This patch replaces the Norwegian labels with English ones. To test: - Only Norwegian libraries and vendors get access to search against the national patron database, so a proper functional test is not possible - Alternative 1: Just have a look at the nl-search.tt template before and after the patch and verify that after the patch the Norwegian strings that would be visible to a user are gone - Alternative 2: - Verify that e.g. en-GB-staff-prog.po contains the Norwegian string "kjonn" - Apply the patch - Create new .po files with e.g. "./translate create en-GB" - Verify that "kjonn" is now gone from en-GB-staff-prog.po Version 2: Tweak a couple of labels to be more in line with labels used elsewhere in Koha, to avoid variants when translating. Version 3: Replace e.g. "Gender: </span>" with "Gender:</span> " to avoid similar-except-for-whitespace strings in translation. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> A few new strings, all previous removed. No koha-qa errors Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #45945|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - Knuckles -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #18 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org