https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use use a template block to |Remove obsolete category |output patron categories |markup from patron entry Severity|enhancement |minor --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I'm repurposing this bug because further investigation shows that the repeated section of markup is in fact obsolete. I will submit a patch to remove the obsolete markup. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92587&action=edit Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Bug 23536 depends on bug 23533, which changed state. Bug 23533 Summary: Reindent patron entry form (memberentrygen.tt) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92663|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99769&action=edit Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99769|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99827&action=edit Bug 23536: Remove obsolete category markup from patron entry This patch removes some obsolete markup from the patron entry template (memberentrygen.tt). The old markup was necessary in a long-gone version of Koha where it was possible to add patrons using built-in categories instead of defining your own. To test, apply the patch and test the process of adding or editing patrons. You should see the patron category displayed correctly in the page title, breadcrumbs, and main heading. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #8)

Not sure this is correct, here we wanted to make the "category_type" translatable. It is not possible to create new category types.

Hum weird, not from this patch, neither from previous bug that impacts it (bug 15407). So either it's super old, or it never worked as intended. -- You are receiving this mail because: You are watching all bug changes.