[Bug 23534] New: Use patron-title.inc on patron entry page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Bug ID: 23534 Summary: Use patron-title.inc on patron entry page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 23533 There are several places on the patron entry form where we could use patron-title.inc instead of outputting the patron name information directly in the template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 [Bug 23533] Reindent patron entry form (memberentrygen.tt) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92583&action=edit Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23536 [Bug 23536] Use use a template block to output patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92583|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92662&action=edit Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |BLOCKED --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Blocked by bug 23533 currently not applying - please switch back once this is resolved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Bug 23534 depends on bug 23533, which changed state. Bug 23533 Summary: Reindent patron entry form (memberentrygen.tt) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23533 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92662|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 99767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99767&action=edit Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99767|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 99826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99826&action=edit Bug 23534: Use patron-title.inc on patron entry page There are a few instances where we can simplify the patron entry template by using the patron-title include file instead of outputting patron name variables one by one. This patch does so in the page title, page breadcrumbs, and page heading. To test, apply the patch and edit a patron record. The page title, breadcrumbs, and main heading should all look correct. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100036&action=edit Bug 23534: Fix selenium tests The title of the page now contains lot of info (is it what we really want?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 paxed <pasi.kallinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@koha-suomi.fi --- Comment #9 from paxed <pasi.kallinen@koha-suomi.fi> --- This added an untranslatable "Print receipt" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to paxed from comment #9)
This added an untranslatable "Print receipt" button.
Hi paxed - I don't see it in the patch - can you point it out? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 --- Comment #11 from paxed <pasi.kallinen@koha-suomi.fi> --- (In reply to Katrin Fischer from comment #10)
(In reply to paxed from comment #9)
This added an untranslatable "Print receipt" button.
Hi paxed - I don't see it in the patch - can you point it out?
Blah, comment ended up on the wrong one, meant bug 23355 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23534 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x branch due to dependencies -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org