[Bug 8357] New: UNIMARCslim2OPACDetail.xsl, title without class and too links to views
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Priority: P5 - low Change sponsored?: --- Bug ID: 8357 Assignee: oleonard@myacpl.org Summary: UNIMARCslim2OPACDetail.xsl, title without class and too links to views Severity: minor Classification: Unclassified OS: All Reporter: tajoli@cilea.it Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha There are problems the xslt file for Unimarc Opac detailed dysplay. 1) The title has '<h1> ... </h1>' instead of ''<h1 class="title"> ... </h1>' (line 29). 2)There are lines (71-86) that create link to different views of the record. But those links are created also with template opac-detail.tt. So in the display you see two time the same links. Those problems are present also in master and in 3.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11154&action=edit Proposed patch Added "title" class. Removed view tabs. + Added exclude-result-prefixes in intranet UNIMARCslimUtils.xsl to avoid name spaces in HTML output (like in opac one). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Note that the "title" class is important because is sets the CSS float:none instead of float:left (like page without XSTL). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11154|0 |1 is obsolete| | --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 11188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11188&action=edit Proposed patch (2) Added removal of the variable on 'viewISBD' syspref. It is useless in OPAC, it is dedicated to staff client. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Zeno Tajoli <tajoli@cilea.it> --- I have test the patch with sandbox n.2. In fact the files are identical in 3.8.x and in master. No problem apply thr patch. With the patch the bug is over. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 11268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11268&action=edit Bug 8204: fix UNIMARC display UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|1 |0 is obsolete| | --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Comment on attachment 11188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11188 Proposed patch (2) This patch signed-off by zeno. The other obsoleted patch ( Bug 8204: fix UNIMARC display (13.66 KB, patch) ) is a mistake made by the sandbox system. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #8 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- But, signed-off patch is not in attachments. Zeno ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 11269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11269&action=edit Bug 8204: fix UNIMARC display UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Zeno Tajoli <tajoli@cilea.it> http://bugs.koha-community.org/show_bug.cgi?id=8357 Signed-off-by: Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #11 from Zeno Tajoli <tajoli@cilea.it> --- Sorry for the problem, I think there is same problem on sanboxes. I try to redo again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11269|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Zeno Tajoli <tajoli@cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 11270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11270&action=edit Bug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views Signed-off-by: Zeno Tajoli <tajoli@cilea.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #14 from Zeno Tajoli <tajoli@cilea.it> --- Hi to all, now the situation is OK. I don't know if is my work with sandbox number 3 or by Paul Poulain but it is OK. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #14)
Hi to all,
now the situation is OK. I don't know if is my work with sandbox number 3 or by Paul Poulain but it is OK.
Well, the explanation is the following: * there was a mistake in my sandbox setup that made the signoff script to badly fail to do anything. * 2 days later, when I fixed the problem, your pending "sign-off" has been applied. Except that ... the signoff is made on the top patch. As 2 days have ellapsed, the "head" patch was no more the correct one and another one was attached as signed off ! My fault, but now it's fixed. The patch, signed-off by you, is uploaded ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #16 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #10)
Created attachment 11269 [details] Bug 8204: fix UNIMARC display
UNIMARC display of authorities in the OPAC wasn't working due to changes in the BuildSummary function since the code was originally developed.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Zeno Tajoli <tajoli@cilea.it>
patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * 442dae6 Bug 8357: UNIMARCslim2OPACDetail.xsl, title without class and too links to views koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/prog/en/xslt/UNIMARCslim2OPACDetail.xsl - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- Pushed to master. Already on stable, setting status accordingly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org