[Bug 8637] New: Lack of control on mandatory in orderreveive.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Priority: P5 - low Change sponsored?: --- Bug ID: 8637 Assignee: koha-bugs@lists.koha-community.org Summary: Lack of control on mandatory in orderreveive.tt Severity: critical Classification: Unclassified OS: All Reporter: christophe.croullebois@biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha Just add a check in Jscript when the form is submited. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 11599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11599&action=edit proposed patch In orderreceive.tt if your syspref 'AcqCreateItem' is on receive, you have an item block with mandatory fields, when you submit the form no check is done. It is a complete lack in the code, so I have used the same check as in additem.tt. thx for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This looks like it works correctly, but I think it would be a good idea to pull a couple of things from the additem.pl template: <label class="required">[% ite.subfield %] - [% ite.marc_lib %]</label> ...and... [% IF ( ite.mandatory ) %] <span class="required">Required</span>[% END %] This would make the mandatory nature of the fields a little more obvious and make it consistent with other forms. Looking at this makes me wonder... Why don't we use services/itemrecorddisplay.pl for additem.pl too? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11599|0 |1 is obsolete| | --- Comment #3 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 11639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11639&action=edit rewrited patch ok, right Owen, I have added two styles in itemrecorddisplay.tt, red and italic and I have changed '*' by 'Required'. About additem effectively we should see, maybe a new report. Thx -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11639|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11673&action=edit Bug 8637: Lack of control on mandatory in orderreveive.tt Just add a check in Jscript when the form is submited, the same as in additem.tt On Owen's suggestion I have added the red color and 'Required', the same as in additem. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Works as described, signing off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Please use an existing class for style. There are .required and span.required in the staff-global.css file. + rename the alertString2 with alertString Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11673|0 |1 is obsolete| | --- Comment #7 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 11698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11698&action=edit this patch is finalised I have changed CSS class and a variable's name (alertString2 to alertString) on Jonathan's demand. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11698|0 |1 is obsolete| | --- Comment #8 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 11699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11699&action=edit patch finalized -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11699|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11735&action=edit [SIGNED-OFF] Bug 8637: Lack of control on mandatory in orderreveive.tt Just add a check in Jscript when the form is submited, the same as in additem.tt On Owen's suggestion I have added the red color and 'Required', the same as in additem. On Jonathan's suggestion I have used the CSS class for red and italic and I have changed a variable's name (alertString2). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Mandatory fields are now correctly checked on saving. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11735|0 |1 is obsolete| | --- Comment #10 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 11745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11745&action=edit proposed patch On Jonathan's suggestion I have created a new class "missing" and I have added the background to staff-global.css. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christophe - what is missing used for? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 --- Comment #12 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- hello Katrin, it is Jonathan who prefers to have style in css files, I have just created this class to point the background style on it. And I have done the some in additem. But I failed with the last patch, I'll put the right one in a minute. For testing, it changes nothing, just the patch must be ok as before. Thx Katrin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11745|0 |1 is obsolete| | --- Comment #13 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 11748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11748&action=edit proposed patch this one must be ok -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Cristophe, I remember when I tested this morning, that the mandatory fields that were missing values got highlighted in yellow. This does not seem to work for me now. Sorry! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Forgot to reload the CSS... works fine now - signing off! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11748|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 11755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11755&action=edit [SIGNED-OFF] Bug 8637: Lack of control on mandatory in orderreveive.tt Just add a check in Jscript when the form is submited, the same as in additem.tt On Owen's suggestion I have added the red color and 'Required', the same as in additem. On Jonathan's suggestion I have used the CSS class for red and italic and I have changed a variable's name (alertString2). Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Mandatory fields are now correctly checked on saving. On other Jonathan's suggestion I have created a new class "missing" and I have added the background to staff-global.css. The same for additem.tt. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Retested because of minor CSS change. Works nicely. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: Templates modifications only. Patch clean. It refactores some css style into a new class "missing". Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #18 from Paul Poulain <paul.poulain@biblibre.com> --- This patch fixes the problem (so i'll push), but it could be improved later: if you recieve more than one item, and click on "Add" before clicking on "Save", you'll be warned of a problem only when you click "Save". You should be warned on each "Add" (if you add more than 1 recieve, and only 1 lack a mandatory information, you won't know/see which item is wrong !) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5. I agree with Paul this could be improved, but it is a good start already. Kaizen! :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org