https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113264&action=edit Bug 26959: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113263|0 |1 is obsolete| | Attachment #113264|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116264&action=edit Bug 26959: Reindent batch item modification template This patch reindents the batch item modification template to make indentation consistent. Some lines have been split up. Some markup issues have been corrected: Removed script "type" attribute, removed obsolete "CDATA" markers, removed obsolete IE-specific conditional comment. To test, apply the patch and go to Tools -> Batch item modification. - Test the process of submitting a barcode file, and item number file, and a list of barcodes. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I've been known to leave my car keys in the refrigerator from time to time. The only changes you see should be split lines. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116265|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 117287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117287&action=edit Bug 26959: (follow-up) Add markup comments This patch adds comments to the template to highlight the markup structure. This patch should have no effect on the page's appearance or functionality. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117286|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117415&action=edit Bug 26959: Reindent batch item modification template This patch reindents the batch item modification template to make indentation consistent. Some lines have been split up. Some markup issues have been corrected: Removed script "type" attribute, removed obsolete "CDATA" markers, removed obsolete IE-specific conditional comment. To test, apply the patch and go to Tools -> Batch item modification. - Test the process of submitting a barcode file, and item number file, and a list of barcodes. - Confirm that everything works as expected. Use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I've been known to leave my car keys in the refrigerator from time to time. The only changes you see should be split lines. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's not a problem with this patch set, but I see probems with the batch item edit process. I am trying to change less than 20 items and it won't finish :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The span in the columns selection can be split on 2 lines: https://snipboard.io/NZ7IdA.jpg vs https://snipboard.io/4Wh0RO.jpg -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117622&action=edit Bug 26959: (follow-up) Fix CSS for column selection labels This patch modifies the staff interface SCSS in order to fix the display of column selection checkbox labels on the batch item modification page. Even though the style of the elements defines the "white-space" as "nowrap," adding whitespace within the element (as was done to correct indentation) still created problems. Changing the display property of the elements to "inline-block" corrects this. Current status: Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #12)

Created attachment 117622 [details] [review] Bug 26959: (follow-up) Fix CSS for column selection labels

Thanks! Sorry for being picky! :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.