[Bug 10630] New: DelBookseller's return value needs to be more explicit in C4::Bookseller.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Bug ID: 10630 Summary: DelBookseller's return value needs to be more explicit in C4::Bookseller.pm Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kenza.zaki@biblibre.com QA Contact: testopia@bugs.koha-community.org DelBookSeller always returns undef, even if nothing has been deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10628 Assignee|koha-bugs@lists.koha-commun |kenza.zaki@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10628 |10528 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 --- Comment #1 from kenza <kenza.zaki@biblibre.com> --- Created attachment 19927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19927&action=edit Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also adds some regression tests. To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=7, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.40 cusr 0.03 csys = 0.45 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kenza.zaki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19927|0 |1 is obsolete| | --- Comment #2 from kenza <kenza.zaki@biblibre.com> --- Created attachment 19937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19937&action=edit Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10640 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10640 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19937|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20203&action=edit Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20203|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20586&action=edit [PASSED QA] Bug 10630: DelBookseller's always returns undef in C4::Bookseller.pm This patch makes DelBookseller returns the number of supplier it has deleted or undef if nothing has been deleted. It also fixes a test which doesn't pass before in t/db_dependent/Bookseller.t To test: prove t/db_dependent/Bookseller.t t/db_dependent/Bookseller.t .. 1/54 All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.02 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Logical change and makes another test pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested with patch for 10528 applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10630 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kenza! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org