http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10630 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 --- Comment #1 from kenza <kenza.zaki@biblibre.com> --- Created attachment 19938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19938&action=edit ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove db_dependent/Bookseller. Bookseller.t .. 1/55 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=55, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 kenza <kenza.zaki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19938|0 |1 is obsolete| | --- Comment #2 from kenza <kenza.zaki@biblibre.com> --- Created attachment 19939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19939&action=edit ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove db_dependent/Bookseller. Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19939|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 19990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19990&action=edit [SIGNED-OFF] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove t/db_dependent/Bookseller.t Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10640 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19990|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20587&action=edit [PASSED QA] ModBookseller needs more explicit return values in C4::Bookseller.pm Before, ModBookseller always returns undef. This patch modifies it in order to be more explicit. Now it returns : 1 -> If a modification has been done 0E0 -> If the given id doesn't exist undef -> If no id given It also fix one of the tests which didn't pass before in t/db_dependent/Bookseller.t To Test: prove t/db_dependent/Bookseller.t Bookseller.t .. 1/54 [Some warnings about uninitialized values] t/db_dependent/Bookseller.t .. ok All tests successful. Files=1, Tests=54, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.04 csys = 0.53 CPU) Result: PASS http://bugs.koha-community.org/show_bug.cgi?id=10640 Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Change is logical and passes new and old tests. Fixed the author line to have Kenza's correct email address. -- You are receiving this mail because: You are watching all bug changes.