[Bug 5932] New: subroutine itemdata to be replaced in C4::Serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5932 Bug #: 5932 Summary: subroutine itemdata to be replaced in C4::Serials Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Serials AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: colin.campbell@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org C4::Serials has an internal subroutine itemdata which retrieves all the data from items and biblioitems for a given barcode. Its only use is as a boolean check of whether the given barcode has been assigned or not. The current functionality clearly does not belong in C4::Serials. Replace with a with a lighter function which only returns the info we are interested in, pending clean up of the Item interface. Should make code more maintainable/redeable and possibly save a couple of cpu cycles. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5932 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> 2011-03-22 15:07:18 UTC --- Created attachment 3398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3398 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5932 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5932 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Signed Off --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-24 09:49:58 UTC --- I don't see big performance improvement, but it works. Signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5932 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-27 08:21:19 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5932 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org