[Bug 5186] New: Setting a tax rate of zero for a vendor causes the tax value to become the default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Summary: Setting a tax rate of zero for a vendor causes the tax value to become the default Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: robin@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Instead, it should remain as zero, and if the field is made blank, then it should become the default. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |robin@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> 2010-08-31 00:51:27 UTC --- As part of this, the whole tax being ignored when creating a vendor thing will be fixed. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> 2010-08-31 03:04:37 UTC --- Created attachment 2587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2587 proposed patch Still has to go through internal QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2587|0 |1 is obsolete| | --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> 2010-09-01 02:48:41 UTC --- Created attachment 2592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2592 proposed patch This addresses some issues found in the previous patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> 2010-09-01 02:52:31 UTC ---
From the commit message:
Bug 5186 - allow tax rates to be set to zero This allows the tax rate for a vendor to be set to zero. Previously, a zero meant that the system default was used. Now, zero means no tax, and to have it be the default the field should simply be left empty. Additionally: * this will now show on the vendor display if the tax value is from the system default * this includes a database update that changes all the existing 0.00 tax settings to be NULL, which preserves existing behaviour. * this now saves the tax value supplied for new vendors * a message is shown telling people what'll happen if a field is left blank * tax is shown on a vendor even if it's zero, for clarity's sake (although all the other tax-related bits aren't) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2592|0 |1 is obsolete| | --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> 2010-12-20 05:39:32 UTC --- Created attachment 2886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2886 Rebased form of this patch that applies against v3.02.01 Patch against master coming up... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> 2010-12-20 06:18:07 UTC --- Created attachment 2887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2887 Patch that applies against master This version applies against master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2010-12-20 12:41:36 UTC --- master signed off (not updating status since I didn't do them both) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> 2010-12-21 01:35:00 UTC --- Master patch has been pushed to new/bug_5186 but not merged yet, can someone please test and let me know if its working ok. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 --- Comment #9 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-07 11:13:13 UTC --- This bug is mentioned in: Bug 5186 - allow tax rates to be set to zero (master) http://lists.koha-community.org/pipermail/koha-patches/2010-December/013433.... Bug 5186 - allow tax to be set to zero (3.2.1) http://lists.koha-community.org/pipermail/koha-patches/2010-December/013428.... Bug 5186 - allow tax rates to be set to zero (master) http://lists.koha-community.org/pipermail/koha-patches/2010-December/013429.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-09 20:14:34 UTC --- Merged to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 --- Comment #11 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-02-04 09:13:41 UTC --- This bug is mentioned in: Bug 5186: Follow-up - Fixing wrong database number http://lists.koha-community.org/pipermail/koha-patches/2011-January/013560.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |paul.poulain@biblibre.com Resolution| |FIXED --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-04-04 09:31:15 UTC --- tested, works as expected -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5186 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org