[Bug 28761] New: Item status shows incorrectly on opac-course-details.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Bug ID: 28761 Summary: Item status shows incorrectly on opac-course-details.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: - create a course in course reserves, add an item to it. - confirm your item shows Available for its status on opac-course-details.pl - give your item a notforloan status - reload opac-course-details.pl, confirm its still "available" - give your item a restricted user status - reload opac-course-details.pl, confirm its still "available" - give your item a lost, damaged, or withdrawn status - reload opac-course-details.pl, these statuses *are* reflected Filing a separate bug for the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28762 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123232&action=edit Bug 28762: Handle different item statuses in course details To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on course-details.pl 3. edit your item to be withdrawn, lost, damaged, notforloan, and restricted use 4. reload course-details.pl, confirm it still shows available 5. apply patch 6. repeat step 3 with each of the statuses and make sure it correctly shows on course-details.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Attachment #123232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123235&action=edit Bug 28761: better handle notforloan and restricted status in item.status.inc To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on opac-course-details.pl 3. give your item a notforloan status 4. reload opac-course-details.pl, confirm its still "available" 5. give your item a restricted user status 6. reload opac-course-details.pl, confirm its still "available" 7. give your item a lost, damaged, or withdrawn status 8. reload opac-course-details.pl, these statuses *are* reflected 9. apply patch 10. check notforloan and restricted, they should be reflect the correct status now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123235|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123246&action=edit Bug 28761: better handle notforloan and restricted status in item.status.inc To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on opac-course-details.pl 3. give your item a notforloan status 4. reload opac-course-details.pl, confirm its still "available" 5. give your item a restricted user status 6. reload opac-course-details.pl, confirm its still "available" 7. give your item a lost, damaged, or withdrawn status 8. reload opac-course-details.pl, these statuses *are* reflected 9. apply patch 10. check notforloan and restricted, they should be reflect the correct status now Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |Fixes a problem in the OPAC released in| |course reserves table where | |restricted and not for loan | |statues were not displaying | |properly in the Status | |column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- This patch also affects the details page on the opac, and the cart Before this patch a restricted item shows as: Available (Restricted Access) After it is: Restricted Access -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123246|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 123351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123351&action=edit Bug 28761: better handle notforloan and restricted status in item.status.inc To test: 1. create a course in course reserves, add an item to it. 2. confirm your item shows Available for its status on opac-course-details.pl 3. give your item a notforloan status 4. reload opac-course-details.pl, confirm its still "available" 5. give your item a restricted user status 6. reload opac-course-details.pl, confirm its still "available" 7. give your item a lost, damaged, or withdrawn status 8. reload opac-course-details.pl, these statuses *are* reflected 9. apply patch 10. check notforloan and restricted, they should be reflect the correct status now 11. restricted status should NOT cause the item to become unavailable 11. The item-status.inc also effects opac-detail and opac-cart 12. look at those and make sure everything looks correct and statuses are properly reflected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Nick Clemens from comment #4)
This patch also affects the details page on the opac, and the cart
Before this patch a restricted item shows as: Available (Restricted Access)
After it is: Restricted Access
Thanks Nick, I erroneously set the itemavailable flag to 0 for restricted items. They should be considered available. Reset the status of this one to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #7 from Kelly McElligott <kelly@bywatersolutions.com> --- I have signed off on this : Kelly McElligott kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I noticed this the other day.. should we also be falling back to item-type level not for loan values when the local not for loan is not set or set to allow loans.. which value should take precedence if both are set? Otherwise, this looks pretty reasonable to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #8)
I noticed this the other day.. should we also be falling back to item-type level not for loan values when the local not for loan is not set or set to allow loans.. which value should take precedence if both are set?
Otherwise, this looks pretty reasonable to me.
Not sure I understand the question correctly, do you mean item vs. record leven not for loan? Then I think if both are set, we should use the description from item level. To me it makes sense that the more specific should win. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a problem here with item type 'not for loan' set: Without the patch: - Mark an item type as not for loan in administration - Make sure one item of that item type is on course reserve - Check the detail page, it shows as: not for loan - Check course reserves: it shows as: available With the patch: - It shows as Available on both detail and course reserves page The correct behaviour would be to show "not for loan" on both, so this introduces a regression. Lucas - when you follow-up, can you please add Kelly's sign-off line? So we don't forget about it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this still on your list Lucas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Still an issue here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28761 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Time for this bug's annual checkup I guess! I don't think this is an issue anymore. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org