https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154880&action=edit Bug 34625: Fix search engine configuration tables header problem This patch corrects the JavaScript which allows DataTables to be created and destroyed based on which tab is clicked on the search engine configuration page. When you click from one tab to the other, the original tab's DataTable should be destroyed and the new tab's DataTable initialized. To test, apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - The page should load with the "Search fields" tab enabled and the DataTable initialized: Sorting and filtering should work. If you scroll down the page the floating table header should be correct. - Switch to the "Bibliographic records" tab. This table should have filtering enabled, and the floating table header should work when you scroll down the page. - The same should be true for the "Authorities" tab. - Return to the "Search fields" tab to confirm that the DataTable is still working as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154880|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 154894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154894&action=edit Bug 34625: Fix search engine configuration tables header problem This patch corrects the JavaScript which allows DataTables to be created and destroyed based on which tab is clicked on the search engine configuration page. When you click from one tab to the other, the original tab's DataTable should be destroyed and the new tab's DataTable initialized. To test, apply the patch and go to Administration -> Search engine configuration (Elasticsearch) - The page should load with the "Search fields" tab enabled and the DataTable initialized: Sorting and filtering should work. If you scroll down the page the floating table header should be correct. - Switch to the "Bibliographic records" tab. This table should have filtering enabled, and the floating table header should work when you scroll down the page. - The same should be true for the "Authorities" tab. - Return to the "Search fields" tab to confirm that the DataTable is still working as expected. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34504 [Bug 34504] Elasticsearch error when updating mappings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 34695 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34625 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.