[Bug 34641] New: Novelist content does not display on OPAC detail page if NovelistSelectView is set to below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Bug ID: 34641 Summary: Novelist content does not display on OPAC detail page if NovelistSelectView is set to below Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Have Novelist credentials: NovelistSelectProfile, NovelistSelectPassword. 2. Enable NovelistSelectEnabled 3. Set NovelistSelectView to 'below holdings table'. 4. Find a record on the OPAC that would have Novelist content. It does not display. 5. Set NovelistSelectView to any except 'below holdings table'. Notice it displays the content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- If this is set to display below the holdings table the 'WRAPPER tab_panel' is unnecessary. It won't be display in a tab/panel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154906&action=edit Bug 34641: Fix Novelist display when NovelistSelectView is set to below To test: 1. Have Novelist credentials: NovelistSelectProfile, NovelistSelectPassword. 2. Enable NovelistSelectEnabled 3. Set NovelistSelectView to 'below holdings table'. 4. Find a record on the OPAC that would have Novelist content. It does not display. 5. Set NovelistSelectView to any except 'below holdings table'. Notice it displays the content. 6. APPLY PATCH 7. Try steps 1 -5 again, this time when NovelistSelectView is set to 'below' the content should properly display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154906|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154911&action=edit Bug 34641: Fix Novelist display when NovelistSelectView is set to below To test: 1. Have Novelist credentials: NovelistSelectProfile, NovelistSelectPassword. 2. Enable NovelistSelectEnabled 3. Set NovelistSelectView to 'below holdings table'. 4. Find a record on the OPAC that would have Novelist content. It does not display. 5. Set NovelistSelectView to any except 'below holdings table'. Notice it displays the content. 6. APPLY PATCH 7. Try steps 1 -5 again, this time when NovelistSelectView is set to 'below' the content should properly display. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I still see: [% IF ( NovelistSelectProfile && NovelistSelectView == 'tab' && (normalized_isbn || normalized_upc) ) %] [% WRAPPER tab_panel tabname="NovelistSelect" %] <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> [% END # /tab_panel#NovelistSelect %] [% END # / IF NovelistSelectProfile && NovelistSelectView == 'tab' %] Indentation in the patch is odd btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #4)
I still see:
[% IF ( NovelistSelectProfile && NovelistSelectView == 'tab' && (normalized_isbn || normalized_upc) ) %] [% WRAPPER tab_panel tabname="NovelistSelect" %] <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> [% END # /tab_panel#NovelistSelect %] [% END # / IF NovelistSelectProfile && NovelistSelectView == 'tab' %]
Indentation in the patch is odd btw.
"NovelistSelectView == 'tab'" This goes in a tab, so I'm not sure what you see. Please elaborate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154911|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155122&action=edit Bug 34641: Fix Novelist display when NovelistSelectView is set to below To test: 1. Have Novelist credentials: NovelistSelectProfile, NovelistSelectPassword. 2. Enable NovelistSelectEnabled 3. Set NovelistSelectView to 'below holdings table'. 4. Find a record on the OPAC that would have Novelist content. It does not display. 5. Set NovelistSelectView to any except 'below holdings table'. Notice it displays the content. 6. APPLY PATCH 7. Try steps 1 -5 again, this time when NovelistSelectView is set to 'below' the content should properly display. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> ---
Indentation in the patch is odd btw.
Indentation is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #5)
(In reply to Marcel de Rooy from comment #4) This goes in a tab, so I'm not sure what you see. Please elaborate.
[% IF ( NovelistSelectProfile && NovelistSelectView == 'tab' && (normalized_isbn || normalized_upc) ) %] [% WRAPPER tab_panel tabname="NovelistSelect" %] <div data-novelist-novelistselect=[% IF normalized_isbn %][% normalized_isbn | html %][% ELSE %][% normalized_upc | html %][% END %]></div> [% END # /tab_panel#NovelistSelect %] [% END # / IF NovelistSelectProfile && NovelistSelectView == 'tab' %] This is line 656. You did not touch that part. But it contains the similar pattern with WRAPPER tab_panel. Does this also need adjustment ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155122|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155193&action=edit Bug 34641: Fix Novelist display when NovelistSelectView is set to below To test: 1. Have Novelist credentials: NovelistSelectProfile, NovelistSelectPassword. 2. Enable NovelistSelectEnabled 3. Set NovelistSelectView to 'below holdings table'. 4. Find a record on the OPAC that would have Novelist content. It does not display. 5. Set NovelistSelectView to any except 'below holdings table'. Notice it displays the content. 6. APPLY PATCH 7. Try steps 1 -5 again, this time when NovelistSelectView is set to 'below' the content should properly display. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8)
(In reply to Lucas Gass from comment #5)
(In reply to Marcel de Rooy from comment #4) This goes in a tab, so I'm not sure what you see. Please elaborate.
This is line 656. You did not touch that part. But it contains the similar pattern with WRAPPER tab_panel. Does this also need adjustment ?
At second glance, it probably does not. Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.04 released in| | --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.04 |23.11.00,23.05.04,22.11.10 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34641 --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org