[Bug 10731] New: IntranetSlipPrinterJS is not working for hold slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Bug ID: 10731 Summary: IntranetSlipPrinterJS is not working for hold slips Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20351&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silentl... 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20352&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [3.10.x] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silentl... 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20352|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20353&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silentl... 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- One patch is labeled "[v3.10/v3.12]" and the other is unlabeled. What's the difference? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- The unlabeled one is for master, the other applies to 3.10.x and 3.12.x (In reply to Owen Leonard from comment #4)
One patch is labeled "[v3.10/v3.12]" and the other is unlabeled. What's the difference?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20351|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20705&action=edit [SIGNED-OFF] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silentl... 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20706&action=edit [SIGNED-OFF] Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silentl... 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully in 3.10.x and 3.12.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20353|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20705|0 |1 is obsolete| | Attachment #20706|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20907&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silentl... 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20908&action=edit Bug 10731 - IntranetSlipPrinterJS is not working for hold slips [v3.10/v3.12] Hold slips aren't printing automatically with JS Print Setup because it appears the system preference IntranetSlipPrint is never being passed to the template. Test Plan: 1) Set up JSPrintSetup http://wiki.koha-community.org/wiki/Setting_up_slip_printer_to_print_silentl... 2) Place a hold 3) Check the item in to capture the hold 4) Click "Print and confirm" 5) Note the slip does not print automatically 6) Apply this patch 7) Repeat steps 2 through 4 8) Observe that the slip now prints automatically Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested successfully in 3.10.x and 3.12.x Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org