http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 20973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20973&action=edit Bug 10872 - C4::Items.pm has YAML::Load in GetHiddenItems but lacks use or require There should be a: "require YAML;" or "use YAML qw/Load/;" as the GetHiddenItems routine has a reference to YAML::Load. This was discovered while adding a GetHiddenItems() call into opac/opac-MARCdetail.pl. I believe this problem dates back to bug 6488 or bug 5984. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- It's not really an enhancement, as it should have been optimized in the first place. Changed to a "minor" bug as a result, since part of this wasn't even visible without another bug fix which is yet to come. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20977|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 21069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21069&action=edit Bug 10872 - C4::Items GetHiddenItems fix and optimization There should be a: "require YAML;" or "use YAML qw/Load/;" as the GetHiddenItems routine has a reference to YAML::Load. This was discovered while adding a GetHiddenItems() call into opac/opac-MARCdetail.pl. I believe this problem dates back to bug 6488 or bug 5984. I also added an optimization to GetHiddenItems to prevent processing if there is nothing in the system preference. Test by searching for a biblio which has some or all of its items hidden. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21069|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21075&action=edit Bug 10872 - C4::Items GetHiddenItems fix and optimization There should be a: "require YAML;" or "use YAML qw/Load/;" as the GetHiddenItems routine has a reference to YAML::Load. This was discovered while adding a GetHiddenItems() call into opac/opac-MARCdetail.pl. I believe this problem dates back to bug 6488 or bug 5984. I also added an optimization to GetHiddenItems to prevent processing if there is nothing in the system preference. Test by searching for a biblio which has some or all of its items hidden. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Maybe return () unless $yaml =~ /\S/; or return () if $yaml =~ /^\s*$/; would have been easier to read. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10876 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |gmcharlt@gmail.com --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Reviewed and passed QA on this, as it is part of a patch series that I want to push as a unit. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.