https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #1 from Florian <florian.bontemps@biblibre.com> --- Created attachment 127399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127399&action=edit Bug 29429: Cannot close budgets Adds GetBudgetHierarchy to the functions called by C4::Budgets Plan : 1. Create a budget with a random amount, save it. 2. Try to close the budget. 3. You should get an Error Trace. 4. Apply the patch 5. Close the budget again 6. It should work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127399|0 |1 is obsolete| | --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127408&action=edit Bug 29429: Cannot close budgets Adds GetBudgetHierarchy to the functions called by C4::Budgets Plan : 1. Create a budget with a random amount, save it. 2. Try to close the budget. 3. You should get an Error Trace. 4. Apply the patch 5. Close the budget again 6. It should work. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Florian, please have a look at this wiki page https://wiki.koha-community.org/wiki/Commit_messages The commit message is often different from the bug title. Your commit message must describe what your patch does, when the bug report title is describing the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #5 from Florian <florian.bontemps@biblibre.com> --- (In reply to Jonathan Druart from comment #4)

Florian, please have a look at this wiki page https://wiki.koha-community.org/wiki/Commit_messages The commit message is often different from the bug title. Your commit message must describe what your patch does, when the bug report title is describing the problem.

Ah, thank you Jonathan. Very new to Koha and Bugzilla here, I'll work on my mistakes! :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29429 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.