[Bug 29407] New: Make the pickup locations dropdown JS reusable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Bug ID: 29407 Summary: Make the pickup locations dropdown JS reusable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29404 Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 [Bug 29404] Add infinite scrolling to pickup location dropdowns -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127269&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29397 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29397 [Bug 29397] Add a select2 wrapper for the API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127269|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127277&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127277|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127278&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Small style fixes in the comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127278|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 127316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127316&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127316|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127319&action=edit Bug 29407: Make the pickup locations dropdown JS reusable This patch generates a function to be used in places where select2 dropdowns are usesd for choosing pickup locations. This cleans repeated/almost identical code introduced by different bugs. To test: 1. Make sure choosing pickup locations works 2. Apply this patch 3. Repeat 1 => SUCCESS: No functional changes 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice bit of code cleanup and DRYing out. No regressions found, QA script is happy, and code is clear. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Bug 29407 depends on bug 29404, which changed state. Bug 29404 Summary: Add infinite scrolling to pickup location dropdowns https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29407 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org