https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.05 |master Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 135736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135736&action=edit Bug 30585: Fix library options on table settings for course_reserves_table The table on course-details.pl has columns for both home library and jolding library, but course_reserves_table in the Table configuration admin area only has a single toggle for 'library'. Hiding 'library' hides the home library column. Anything after that is off by one. Hiding 'staff_note' actually hides the holding library column, 'link' hides Public note, etc. To test: - Add a course and some course reserves - Go to table configuration and hide 'staff note' - Look at the list of course reserves for your course - Verify the wrong column was hidden - Apply patch - The configuration area now shows holding_library and home_library as separate options. - Change the settings and verify everything now hides/displays correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |22630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 [Bug 22630] Add ability to change the homebranch in course reserves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135739|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135878&action=edit Bug 30585: Fix library options on table settings for course_reserves_table The table on course-details.pl has columns for both home library and jolding library, but course_reserves_table in the Table configuration admin area only has a single toggle for 'library'. Hiding 'library' hides the home library column. Anything after that is off by one. Hiding 'staff_note' actually hides the holding library column, 'link' hides Public note, etc. To test: - Add a course and some course reserves - Go to table configuration and hide 'staff note' - Look at the list of course reserves for your course - Verify the wrong column was hidden - Apply patch - The configuration area now shows holding_library and home_library as separate options. - Change the settings and verify everything now hides/displays correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30585 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.