[Bug 28273] New: Multi-holds allow invalid pickup locations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Bug ID: 28273 Summary: Multi-holds allow invalid pickup locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Steps to reproduce: 1. Perform a search 2. Select several biblios, that can have holds 3. Click on 'Place hold' 4. You are presented a list of biblios and some biblio-level hold options, including pickup location selection => FAIL: It presents the full list of pickup locations in the system 5. Place a hold with a pickup location that is invalid for some title => FAIL: The hold goes through! The solution for this is revamping this UI, probably calculating the pickup locations intersection for display, and allowing individual titles to be set a specific pickup location. (i.e. global or local setting based on intersection is null => only local, intersection is not null => use it as default, and allow override on specific titles). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27864 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120407&action=edit Bug 28273: Unit tests https://bugs.koha-community.org/show_bug.cgi?id=26273 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120408&action=edit Bug 28273: Add Koha::Biblios->pickup_locations https://bugs.koha-community.org/show_bug.cgi?id=26273 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120408|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120407|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120923&action=edit Bug 28273: Add Koha::Biblios->pickup_locations https://bugs.koha-community.org/show_bug.cgi?id=26273 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120924&action=edit Bug 28273: Multi-hold should not offer invalid pickup locations This patch makes the multi-hold page offer only valid pickup locations for the selected biblios. Prior to this, all system-wide pickup locations were offered. To test: 1. Set 'Hold pickup library match' to 'Item's home branch' so we put a constraint on the valid pickup locations for easier testing. 2. Choose two or more biblios from a search, which contain in total 2 or 3 item home branches. 3. Click 'Place hold' 4. Choose a patron => FAIL: The dropdown offers all system's pickup locations 5. Apply this patches 6. Reload the page => SUCCESS: Only valid pickup locations are offered 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120925&action=edit Bug 28273: Add form validation for pickup locations This patch introduces validation on the new pickup locations column. This way, if a selected title doesn't have a pickup location set, it will prevent form submission and a suitable error message will pop-up. To test: 1. Apply this patch 2. Attempt to place multi-title level holds 3. Make sure some selected titles don't have the pickup location set 4. Submit => SUCCESS: Form submission halts, an idiomatic error message shows. 5. Unselect all biblios and repeat 4 => SUCCESS: You are not allowed to proceed, a message is displayed. 6. Have all selected titles set a pickup location, submit => SUCCESS: Holds are placed as they should. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120926&action=edit Bug 28273: (follow-up) Remove unused variable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120923|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 120933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120933&action=edit Bug 28273: Add Koha::Biblios->pickup_locations https://bugs.koha-community.org/show_bug.cgi?id=26273 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120924|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 120934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120934&action=edit Bug 28273: Multi-hold should not offer invalid pickup locations This patch makes the multi-hold page offer only valid pickup locations for the selected biblios. Prior to this, all system-wide pickup locations were offered. To test: 1. Set 'Hold pickup library match' to 'Item's home branch' so we put a constraint on the valid pickup locations for easier testing. 2. Choose two or more biblios from a search, which contain in total 2 or 3 item home branches. 3. Click 'Place hold' 4. Choose a patron => FAIL: The dropdown offers all system's pickup locations 5. Apply this patches 6. Reload the page => SUCCESS: Only valid pickup locations are offered 7. Sign off :-D Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120925|0 |1 is obsolete| | --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 120935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120935&action=edit Bug 28273: Add form validation for pickup locations This patch introduces validation on the new pickup locations column. This way, if a selected title doesn't have a pickup location set, it will prevent form submission and a suitable error message will pop-up. To test: 1. Apply this patch 2. Attempt to place multi-title level holds 3. Make sure some selected titles don't have the pickup location set 4. Submit => SUCCESS: Form submission halts, an idiomatic error message shows. 5. Unselect all biblios and repeat 4 => SUCCESS: You are not allowed to proceed, a message is displayed. 6. Have all selected titles set a pickup location, submit => SUCCESS: Holds are placed as they should. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120926|0 |1 is obsolete| | --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 120936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120936&action=edit Bug 28273: (follow-up) Remove unused variable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120933|0 |1 is obsolete| | Attachment #120934|0 |1 is obsolete| | Attachment #120935|0 |1 is obsolete| | Attachment #120936|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120957&action=edit Bug 28273: Add Koha::Biblios->pickup_locations https://bugs.koha-community.org/show_bug.cgi?id=26273 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120957|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120958&action=edit Bug 28273: Add Koha::Biblios->pickup_locations https://bugs.koha-community.org/show_bug.cgi?id=26273 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120959&action=edit Bug 28273: Multi-hold should not offer invalid pickup locations This patch makes the multi-hold page offer only valid pickup locations for the selected biblios. Prior to this, all system-wide pickup locations were offered. To test: 1. Set 'Hold pickup library match' to 'Item's home branch' so we put a constraint on the valid pickup locations for easier testing. 2. Choose two or more biblios from a search, which contain in total 2 or 3 item home branches. 3. Click 'Place hold' 4. Choose a patron => FAIL: The dropdown offers all system's pickup locations 5. Apply this patches 6. Reload the page => SUCCESS: Only valid pickup locations are offered 7. Sign off :-D Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120960&action=edit Bug 28273: Add form validation for pickup locations This patch introduces validation on the new pickup locations column. This way, if a selected title doesn't have a pickup location set, it will prevent form submission and a suitable error message will pop-up. To test: 1. Apply this patch 2. Attempt to place multi-title level holds 3. Make sure some selected titles don't have the pickup location set 4. Submit => SUCCESS: Form submission halts, an idiomatic error message shows. 5. Unselect all biblios and repeat 4 => SUCCESS: You are not allowed to proceed, a message is displayed. 6. Have all selected titles set a pickup location, submit => SUCCESS: Holds are placed as they should. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120961&action=edit Bug 28273: (follow-up) Remove unused variable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |kyle@bywatersolutions.com --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Koha::Biblios::pickup_locations needs unit tests, but otherwise I'd consider it PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120407|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Kyle M Hall from comment #16)
Koha::Biblios::pickup_locations needs unit tests, but otherwise I'd consider it PQA.
The tests were there, but it seems I wrongly obsoleted them at some point! Please run them! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply on 20.11.x. Looks like it depends on Bug 27894 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28496 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28496 [Bug 28496] Club holds form broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7703 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7703 [Bug 7703] Don't block bulk hold action on search results if some items can't be placed on hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #20 from David Cook <dcook@prosentient.com.au> --- I'm looking into null branchcodes being used for reserves (and breaking the Reserves display in Circ), and I think that it's being caused by multiholds, since their default value for "Pickup location" is blank. I'm thinking that the solution is probably to remove the empty options... I am working on an instance with customized hold functionality, so it is possible that the customizations are preventing some error handling that is in master, but exploring currently... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #21 from David Cook <dcook@prosentient.com.au> --- Oh and it looks possible to nix the pickup location manually anyway... I'll have to test this on master... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 [Bug 28919] When placing a multi-hold from results in staff pickup location is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28919 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 [Bug 28919] When placing a multi-hold from results in staff pickup location is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28919 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28919 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28919 [Bug 28919] When placing a multi-hold from results in staff pickup location is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36872 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36872 [Bug 36872] Untranslatable "Please make sure all selected titles have a pickup location set" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org