https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28273 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 120925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120925&action=edit Bug 28273: Add form validation for pickup locations This patch introduces validation on the new pickup locations column. This way, if a selected title doesn't have a pickup location set, it will prevent form submission and a suitable error message will pop-up. To test: 1. Apply this patch 2. Attempt to place multi-title level holds 3. Make sure some selected titles don't have the pickup location set 4. Submit => SUCCESS: Form submission halts, an idiomatic error message shows. 5. Unselect all biblios and repeat 4 => SUCCESS: You are not allowed to proceed, a message is displayed. 6. Have all selected titles set a pickup location, submit => SUCCESS: Holds are placed as they should. 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.