http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9016 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9016 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20817|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20818&action=edit Bug 10832: Multi transport types for overdue notices -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #4 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 9016: DB changes: new table overduerules_transport_types Using index info to reconstruct a base tree... M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Patch failed at 0001 Bug 9016: DB changes: new table overduerules_transport_types The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to I'm just a bot from comment #5)

This bug depends on bug9016 which is in status Needs Signoff but the patches for it do not apply cleanly

bug 9016 rebased. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olli-antti.kivilahti@jns.fi --- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- ----------------------------------------------------------------------------- -- "git bz applying 10832" on top of "git bz apply all commits for 9016" -- ----------------------------------------------------------------------------- Auto-merging misc/cronjobs/overdue_notices.pl CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl Manually resolved the conflict. -------------------------- -- overdue_notices.pl -- -------------------------- overdue_notices.pl properly queues letters to koha.message_queue but the parse_letter() doesn't parse any letter placeholders <<branch.branchname>> atleast for email and sms transport type. Unsure if this is because of my merge. Placeholders work when triggering notifications from check-in/check-out for ex. Only tested the main path, unsure how to trigger secondary execution paths. Test plan works for the core test case. Yet to test the specific case, but based on my code review it should work :) Otherwise good work in such a complex application area. ------------------------- -- Failed QA because -- ------------------------- Merge conflict needs to be resolved. Placeholders do not work for some reason. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Olli-Antti Kivilahti from comment #8)

overdue_notices.pl properly queues letters to koha.message_queue but the parse_letter() doesn't parse any letter placeholders <<branch.branchname>> atleast for email and sms transport type. Unsure if this is because of my merge. Placeholders work when triggering notifications from check-in/check-out for ex.

The placeholder is not branch.branchname but branches.branchname :)

Merge conflict needs to be resolved.

Conflict resolved. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22815|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 23900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23900&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11603 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11696 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #14 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Yet another bug in overdue_notices.pl. For the overdue letter 2, if there are more than one borrower receiving a overdueletter2 from the same branch via $mtt = print. Only the firstly handled borrower gets his overdue letter, other print letters for the same branch and borrowertype and overdueletternumber are skipped because $print_sent == 1. overdue_notices.pl: 627 => $print_sent = 1 if $mtt eq 'print'; is the culprit, but overdue_notices.pl: 438 => my $print_sent = 0; # We never sent a print notice is instantiated too early, preventing iteration of extra borrowers. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25219&action=edit Bug 10832: FIX Some print notices may not be sent If overdues should be sent to some patron (on the same branch), only the first one was notified. This patch fixes this issue. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Olli-Antti, should this be signed off? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy@rijksmuseum.nl --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Does not apply anymore on top of 9016. Please rebase. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25223|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27469&action=edit Bug 10832: FIX Some print notices may not be sent If overdues should be sent to some patron (on the same branch), only the first one was notified. This patch fixes this issue. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27468|0 |1 is obsolete| | Attachment #27469|0 |1 is obsolete| | --- Comment #24 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 27496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27496&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- No circulation PREDUE letter at /usr/share/koha/testclone/C4/Letters.pm line 455 (Similar remark as on report 10845. Listing the mtt would be helpful too.) Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, I have a (late) question about this development:

- Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level.

Before the MTT patches were pushed there as an email send to the library containing all notices for patrons without email address. Is this still possible now? Is some additional configuration required? I have tested this and I can see the notices show up as 'print' in my message_queue. I think this fallback cannot be avoided, as I haven't set up any notices for print nor checked the print checkbox in notice triggers. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832

--- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> ---
(In reply to Katrin Fischer from comment #29)
> Hi, I have a (late) question about this development:
> 
> >- Specific case: If a user don't have a smsalertnumber and a sms is
> >  required or if a user don't have an email defined and an email is
> >  required, a print notice is generated.
> >  A print notice is generated only 1 time per borrower and per level.
> 
> Before the MTT patches were pushed there as an email send to the library
> containing all notices for patrons without email address. Is this still
> possible now? Is some additional configuration required?
> 
> I have tested this and I can see the notices show up as 'print' in my
> message_queue. I think this fallback cannot be avoided, as I haven't set up
> any notices for print nor checked the print checkbox in notice triggers.

>From the commit message:
- Specific case: If a user don't have a smsalertnumber and a sms is
  required or if a user don't have an email defined and an email is
  required, a print notice is generated.

I can provide a patch if everyone agrees on how we should manage this case.
Have a look at the wiki page
(http://wiki.koha-community.org/wiki/Message_transport_types), we (Olli and me)
explained the different behaviors.

-- 
You are receiving this mail because:
You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #32 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #30) Whaou, this comment was quite stupid, I quoted what you already quoted... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #34 from delaye <stephane.delaye@biblibre.com> --- In 3.18 -> if a user don't have an email defined and an email is required and print is not required, a print notice is generated with the content of email. -> if a user don't have an email defined and an email is required and print is required, a print notice is generated with the content of print. Print required ou not not required , we must have a print notice with content of print not content of email with a message_transport_type=print.... -- You are receiving this mail because: You are watching all bug changes.