http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> 2010-12-29 16:01:03 UTC --- Marking this as an enhancement. A review of the MARC21 and authority specs shows the following: - in many cases, one or both indicator values in the bib heading could in fact be set from the authority record's main heading field. - there are two main cases: 1. Directly copying an indicator value over, e.g., for the form of name or for non-filing characters. However, the indicator position in the authority record doesn't necessary correspond to the value used in the bib field; a good example of this is the nonfiling characters indicator for uniform title headings. Consequently, the indicator mapping should be configured somewhere. 2. Setting the thesaurus type (or source of term) based on the thesaurus specified in the authority record. For MARC21 subject headings, this could entail setting the 6xx indicator 2 *and* a subfield $2; for UNIMARC headings, setting $2 appears to be sufficient. The two cases could be treated as separate enhancements, of course. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #3 from Janusz Kaczmarek <januszop@gmail.com> --- Yes. According to my experience, for librarians it would be great to have this. (I was asked about it several times in different places.) I perfectly agree to what Galen wrote -- it's not as straightforward as it seemed to me 2,5 years ago. But seems not to be impossible (for instance, VTLS's Virtua does this). As to the subject headings in MARC-21, an association could be done between 008/11 from authority record and 2nd ind. in 6xx, i.e. 'a' -> 0, 'b' -> 1, 'c' -> 3 (cf. http://www.loc.gov/marc/authority/ad008.html vs. http://www.loc.gov/marc/bibliographic/bd600.html etc.) Indicators in UNIMARC bibliographics 6xx seem to be the same as the ones of authorities 2xx. (Subject heading system/thesaurus is defined elsewhere: in $2.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 17599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17599&action=edit Proposed patch With this patch Koha should Koha should correctly copy indicators (and create $2 subfield in MARC-21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC-21 flavors are covered. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17599|0 |1 is obsolete| | --- Comment #6 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 17850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17850&action=edit Improved patch Slightly improved version of the patch (with the previous version indicators didn't copy in some circumstances). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #8 from Janusz Kaczmarek <januszop@gmail.com> --- Test plan ========= The story with indicators, especially in MARC-21, is not straightforward, but one can point four main cases: 1. MARC-21 formal heading -- other than unified title 2. MARC-21 formal heading -- unified title 3. MARC-21 subject heading 4. UNIMARC 1. MARC-21 formal heading -- other than unified title 1st indicator from field 1XX (100/110/111) in the authority record should be copied to 1st indicator of controlled field in the bibliographic record, 2nd indicator is not defined (hence no action is taken) 2. MARC-21 formal heading -- unified title 1st indicator in authority record is not defined (hence no action is taken) 2nd indicator from field 130 in the authority record should be copied to 1st indicator of controlled field in the bibliographic record if it is 130 or 730 (or 630 – se bellow), or to 2nd indicator of controlled field in the bibliographic record, if it is 830 3. MARC-21 subject heading (6XX in bibliographic record) a) 1st indicator: 600, 610, 611: 1st indicator from field 1XX (100/110/111) in the authority record should be copied to 1st indicator of controlled field in the bibliographic record 630: 2nd indicator from field 130 in the authority record should be copied to 1st indicator of controlled field in the bibliographic record b) 2nd indicator – the thesaurus a mapping should be made from 008/11 in authority record (http://www.loc.gov/marc/authority/ad008.html) to the 2nd indictor (http://www.loc.gov/marc/bibliographic/bd600.html), e.g. 008/11=a --> 2nd. ind. = 0 In case when 008/11=~/[rsz]/ 2nd ind. should be set to 7, and subfield $2 should be added (for r --> aat, for s --> sears, for z the cataloger has to put a value by himself) 4. UNIMARC Indicators from the authority record should be copied directly to the controlled field in the bibliographic record. References: http://www.loc.gov/marc/bibliographic/ http://www.loc.gov/marc/authority/ http://archive.ifla.org/VI/3/p1996-1/sec-uni.htm http://www.ifla.org/files/assets/uca/unimarc-authorities-format.pdf -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Janusz, I don't know much about catalographic rules, but I can check if values verify expected behaviour. I tested every combination suggested by current mapping in Koha, could you check if those are the expected values? Test - Bug 5262 - MARC21 1) Add one authority for each kind, with values in both indicators (ind1=1, ind2=2) PERSO_NAME 100a CORPO_NAME 110a MEETI_NAME 111a UNIF_TITLE 130a CHRON_TERM 148a TOPIC_TERM 150a GENRE/FORM 155a GEOGR_NAME 151a 2) New biblio record, default framework all indicators clean 3) Use cases, mapping from default MARC21 framework, for each auth kind, results ( 1, 2, 7, - for empty) 008/11 = a and r (results separated by |) a) PERSO_NAME 100 BIB IND1 IND2 100 1 -|- 600 1 0|7 696 1 0|7 700 1 -|- 796 1 -|- 800 1 -|- 896 1 -|- b) CORPO_NAME 110 BIB IND1 IND2 110 1 -|- 610 1 0|7 697 1 0|7 710 1 -|- 797 1 -|- 810 1 -|- 897 1 -|- c) MEETI_NAME 111 BIB IND1 IND2 111 1 -|- 611 1 0|7 698 1 0|7 711 1 -|- 798 1 -|- 811 1 -|- 898 1 -|- d) CHRON_TERM 148 BIB IND1 IND2 648 1 0|7 e) GENRE/FOMR 155 BIB IND1 IND2 655 - 0|7 f) GEOGR_NAME 151 BIB IND1 IND2 651 1 0|7 662 1 0|7 691 1 0|7 h) UNIF_TITLE 130 BIB IND1 IND2 130 2 -|- 440 2 -|- 490 2 -|- 630 2 0|7 699 2 0|7 730 2 -|- 799 2 -|- 830 - 2|2 899 2 -|- i) TOPIC_TERM 150 BIB IND1 IND2 650 1 0|7 654 1 0|7 656 1 0|7 657 1 0|7 658 1 0|7 690 1 0|7 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #11 from Janusz Kaczmarek <januszop@gmail.com> --- Bernardo, Thank you for your efforts in testing this patch. In general, the results are correct, i.e. it is what I would expect—with one exception: e) GENRE/FOMR 155 BIB IND1 IND2 655 - 0|7 With your data set (GENRE/FORM 155a, ind1=1, ind2=2), according to my code and to my tests results, the 1st indicator should become 1. So, please, could you check it again. BUT in fact the 1st indicator in authority records 148, 150, 151, 158 is undefined by definition (and should be your records), so I do not pay attention on it (precisely speaking, a default action is taken, i.e. to copy). Now, I have omitted one case: it could be, that UNIF_TITLE authority will used to control bibliographic 240. In this case 2nd indicator from UNIF_TITLE authority should be copied to 2nd indicator of bibliographic 240. A modified patch has been provided. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17924|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17951&action=edit [SIGNED-OFF] Bug 5262 - authority plugin doesn't copy indicators -- ver. 0.3 With this patch Koha should Koha should correctly copy indicators (and create $2 subfield in MARC-21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC-21 flavors are covered. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: work as described, testing in comments 9 and 12. No errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Looks good to me but I prefer a MARC21 user does QA on this patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20090&action=edit [PASSED QA] Bug 5262 - authority plugin doesn't copy indicators -- ver. 0.3 With this patch Koha should Koha should correctly copy indicators (and create $2 subfield in MARC-21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC-21 flavors are covered. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: work as described, testing in comments 9 and 12. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Tested functionality repeating some of the tests noted by Bernardo - checking mostly 1xx, 490, and 7xx. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17951|0 |1 is obsolete| | Attachment #20090|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20091&action=edit [PASSED QA] Bug 5262 - authority plugin doesn't copy indicators -- ver. 0.3 With this patch Koha should Koha should correctly copy indicators (and create $2 subfield in MARC-21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC-21 flavors are covered. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: work as described, testing in comments 9 and 12. No errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Tested functionality repeating some of the tests noted by Bernardo - checking mostly 1xx, 490, and 7xx. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Janusz, just seeing your comment - I have added Magnus to the cc list, he will know :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.