https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- I suggest this being an option, because some libraries might require fees or a view of a current ID before renewing. Maybe the option can include whether certain patron categories allow self renewal. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26357 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357 [Bug 26357] Create preference for staff notification of patron self-renewals -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org --- Comment #3 from Martha Fuerst <mfuerst@hmcpl.org> --- We're also interested in this enhancement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Martha Fuerst from comment #4)

I'd also like the option to be able to review the request for renewal before granting it. Seems like a reasonable option for a potential syspref.

Martha, see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26357, which depends on this bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Jaki <jaki.frisina@leblibrary.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaki.frisina@leblibrary.com --- Comment #6 from Jaki <jaki.frisina@leblibrary.com> --- We would love to see this as the majority of our emails for the past few months have been patrons requesting to renew their accounts. If they could do it themselves without going through us, that would be great! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #7 from George Williams (NEKLS) <george@nekls.org> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Sarah Fletcher <sfletcher@ncrl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfletcher@ncrl.org --- Comment #8 from Sarah Fletcher <sfletcher@ncrl.org> --- NCW Libraries is extremely interested in this enhancement as well! It would save us a lot of staff time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #9 from Christopher Brannon <cbrannon@cdalibrary.org> --- A more detailed workflow was requested for this idea. So, here it is. 1. A setting is created to determine if self renewals will be allowed, and if so, what patron categories and patron home libraries will allow this (using the dropdown checkbox method for each). Additionally, an option in this setting to set whether new patron categories or libraries added after this setting is set will default to enabled or disabled. 2. A setting is created to determine if renewals with no changes can be automatic. If so, once the patron submits the form with no changes, other than the checkbox, the account is renewed, and the request is recorded as a modification request, but already approved (with notation in the log or table noting that this was a renewal). 3. A setting is created to determine if renewals with fines can be automatic. Similar method as #1. 4. Notification goes out to patron that their account will expire soon. We provide a link in the notification, and other places on the OPAC where that reminder shows, that links to the patron modification request page (opac-memberentry.pl) (I would suggest this be renamed to something like opac-membermodifications.pl, for consistancy, but this is arbitrary). 5. Specific definable instructions are displayed at the top of the page if the patron account is close to expiration (as defined in MembershipExpiryDaysNotice). I will refer to this as the renewal period from this point out. 6. A new checkbox appears and is required during the renewal period which a patron must check in order to submit. The checkbox states that they have reviewed the information above, and everything is up-to-date or modified as needed. This is needed so that we know they are looking things over (as much as we can tell) and if there are no changes, we at least know why the modification was submitted (if needing staff intervention). 7. Modification requests for renewals with or without field changes that require moderation should show along with other regular modification requests, but show a renewal badge in the request table, but otherwise function as usual. 8. The "Patrons requesting modifications" description on the staff home page (mnainpage.pl) and patron search page (members-home.pl) should be relabeled as "Patron modification/renewal requests". I think this is a fairly good plan. If anyone sees any flaws in this plan, or other needed elements, please speak up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25063 [Bug 25063] [OMNIBUS] OPAC Renewal Option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #10 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- This would be really useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28688 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #13 from Rebecca Coert <rcoert@arlingtonva.us> --- This would be very useful! +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com --- Comment #15 from Lisette Scheer <lisette@bywatersolutions.com> --- *** Bug 37514 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #16 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191781&action=edit Bug 26355: Add new columns to the patron categories and attributes tables -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #18 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191783&action=edit Bug 26355: Update API specs for categories Adds the new db columns to the category specs and adds a POST endpoint for patron categories. Also adds a check for self renewal eligibility to the patron definition -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191785&action=edit Bug 26355: Add a Vue island for the self renewal modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191787&action=edit Bug 26355: Update opac-user and opac-memberentry to support the renewal workflow This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add additional verification steps. This was a requirement for our customer and to enable it I’ve opted to use Patron attribute types because these are already configurable by category and library. This means you can add additional verification questions such as ‘Do you still live within X miles of the library?” - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to 0 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the Intranet, navigate to Admin > Patron attribute types 40. Click to create a new attribute 41. The code isn’t important here but we do need a description - this can be anything for the plan, for example “Do you still live locally to this library?” 42. Tick the new checkbox - Self-renewal verification check 43. Create a second attribute, this time set the description to something like “We don’t want to see this one!”. Do NOT click the self-renewal checkbox this time 44. In the OPAC, refresh the page and then click the renewal link again 45. You should be met with the modal, this time asking the verification question we just set up in the patron attributes 46. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 47. The second attribute that we set up without the self-renewal checkbox selected should not appear 48. This time when prompted with the “Are you sure” message, click “Yes” 49. The page should refresh and display a confirmation with the new expiry date. 50. In the intranet, view the patron’s record - the date should have been updated 51. In the Modification log tab, there should be a log entry for “Membership renewed” 52. Change the patron’s expiry date again, this time to be yesterday’s date 53. In the OPAC, click on “Personal detail”, the new expiry date should show there 54. Now set the OPACPatronDetails syspref to be “Allow” 55. Click on “Summary” again, the self-renewal link should be there again 56. Click into the self-renewal process and click “Yes” on your verification step 57. This time you should be met with a message that says “Confirm your account details” 58. Click “Continue” - you will be redirected to the OPAC details form 59. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 60. Update a field somewhere on the patron form 61. Scroll to the bottom - the button should say “Submit renewal request” 62. Click this button 63. You will be shown the renewal confirmation message 64. In the intranet, on the homepage you should now see a modification request 65. Check the request, it should match the fields you changed - don’t approve or deny for now 66. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 67. Reset your patron’s expiry date to today’s date 68. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 69. The renewal link will be visible again - go through the process again 70. On the form, you should see an alert that you have already sent a modification request 71. This time, change a different field to the previous attempt 72. Submit the form 73. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 74. prove t/db_dependent/Koha/Patron.t 75. prove t/db_dependent/api/v1/patrons_self_renewal.t 76. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 77. Sign off! Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: LibraryOn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191789&action=edit Bug 26355: Add cypress tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tie account renewals to |Allow patrons to self-renew |patron modification |through the OPAC |requests | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hdunne-howrie@westminster.g | |ov.uk, | |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191789|0 |1 is obsolete| | --- Comment #26 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 192440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192440&action=edit Bug 26355: Add cypress tests Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191781|0 |1 is obsolete| | --- Comment #27 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 192441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192441&action=edit Bug 26355: Add new columns to the patron categories and attributes tables Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191783|0 |1 is obsolete| | --- Comment #29 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 192443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192443&action=edit Bug 26355: Update API specs for categories Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Adds the new db columns to the category specs and adds a POST endpoint for patron categories. Also adds a check for self renewal eligibility to the patron definition -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191785|0 |1 is obsolete| | --- Comment #31 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 192445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192445&action=edit Bug 26355: Add a Vue island for the self renewal modal Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191787|0 |1 is obsolete| | --- Comment #33 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 192447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192447&action=edit Bug 26355: Update opac-user and opac-memberentry to support the renewal workflow This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add additional verification steps. This was a requirement for our customer and to enable it I’ve opted to use Patron attribute types because these are already configurable by category and library. This means you can add additional verification questions such as ‘Do you still live within X miles of the library?” - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to 0 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the Intranet, navigate to Admin > Patron attribute types 40. Click to create a new attribute 41. The code isn’t important here but we do need a description - this can be anything for the plan, for example “Do you still live locally to this library?” 42. Tick the new checkbox - Self-renewal verification check 43. Create a second attribute, this time set the description to something like “We don’t want to see this one!”. Do NOT click the self-renewal checkbox this time 44. In the OPAC, refresh the page and then click the renewal link again 45. You should be met with the modal, this time asking the verification question we just set up in the patron attributes 46. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 47. The second attribute that we set up without the self-renewal checkbox selected should not appear 48. This time when prompted with the “Are you sure” message, click “Yes” 49. The page should refresh and display a confirmation with the new expiry date. 50. In the intranet, view the patron’s record - the date should have been updated 51. In the Modification log tab, there should be a log entry for “Membership renewed” 52. Change the patron’s expiry date again, this time to be yesterday’s date 53. In the OPAC, click on “Personal detail”, the new expiry date should show there 54. Now set the OPACPatronDetails syspref to be “Allow” 55. Click on “Summary” again, the self-renewal link should be there again 56. Click into the self-renewal process and click “Yes” on your verification step 57. This time you should be met with a message that says “Confirm your account details” 58. Click “Continue” - you will be redirected to the OPAC details form 59. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 60. Update a field somewhere on the patron form 61. Scroll to the bottom - the button should say “Submit renewal request” 62. Click this button 63. You will be shown the renewal confirmation message 64. In the intranet, on the homepage you should now see a modification request 65. Check the request, it should match the fields you changed - don’t approve or deny for now 66. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 67. Reset your patron’s expiry date to today’s date 68. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 69. The renewal link will be visible again - go through the process again 70. On the form, you should see an alert that you have already sent a modification request 71. This time, change a different field to the previous attempt 72. Submit the form 73. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 74. prove t/db_dependent/Koha/Patron.t 75. prove t/db_dependent/api/v1/patrons_self_renewal.t 76. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 77. Sign off! Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: LibraryOn Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #35 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Sandbox sign-off doesn't seem to have worked correctly, only one commit was attached and the bug status wasn't changed. I've added SO lines to the rest of the commits and added them on Hannah's behalf -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192441|0 |1 is obsolete| | --- Comment #37 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193066&action=edit Bug 26355: Add new columns to the patron categories and attributes tables Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192443|0 |1 is obsolete| | --- Comment #39 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193068&action=edit Bug 26355: Update API specs for categories Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> Adds the new db columns to the category specs and adds a POST endpoint for patron categories. Also adds a check for self renewal eligibility to the patron definition -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192445|0 |1 is obsolete| | --- Comment #41 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193070&action=edit Bug 26355: Add a Vue island for the self renewal modal Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192447|0 |1 is obsolete| | --- Comment #43 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193072&action=edit Bug 26355: Update opac-user and opac-memberentry to support the renewal workflow This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add additional verification steps. This was a requirement for our customer and to enable it I’ve opted to use Patron attribute types because these are already configurable by category and library. This means you can add additional verification questions such as ‘Do you still live within X miles of the library?” - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to 0 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the Intranet, navigate to Admin > Patron attribute types 40. Click to create a new attribute 41. The code isn’t important here but we do need a description - this can be anything for the plan, for example “Do you still live locally to this library?” 42. Tick the new checkbox - Self-renewal verification check 43. Create a second attribute, this time set the description to something like “We don’t want to see this one!”. Do NOT click the self-renewal checkbox this time 44. In the OPAC, refresh the page and then click the renewal link again 45. You should be met with the modal, this time asking the verification question we just set up in the patron attributes 46. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 47. The second attribute that we set up without the self-renewal checkbox selected should not appear 48. This time when prompted with the “Are you sure” message, click “Yes” 49. The page should refresh and display a confirmation with the new expiry date. 50. In the intranet, view the patron’s record - the date should have been updated 51. In the Modification log tab, there should be a log entry for “Membership renewed” 52. Change the patron’s expiry date again, this time to be yesterday’s date 53. In the OPAC, click on “Personal detail”, the new expiry date should show there 54. Now set the OPACPatronDetails syspref to be “Allow” 55. Click on “Summary” again, the self-renewal link should be there again 56. Click into the self-renewal process and click “Yes” on your verification step 57. This time you should be met with a message that says “Confirm your account details” 58. Click “Continue” - you will be redirected to the OPAC details form 59. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 60. Update a field somewhere on the patron form 61. Scroll to the bottom - the button should say “Submit renewal request” 62. Click this button 63. You will be shown the renewal confirmation message 64. In the intranet, on the homepage you should now see a modification request 65. Check the request, it should match the fields you changed - don’t approve or deny for now 66. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 67. Reset your patron’s expiry date to today’s date 68. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 69. The renewal link will be visible again - go through the process again 70. On the form, you should see an alert that you have already sent a modification request 71. This time, change a different field to the previous attempt 72. Submit the form 73. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 74. prove t/db_dependent/Koha/Patron.t 75. prove t/db_dependent/api/v1/patrons_self_renewal.t 76. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 77. Sign off! Sponsored-by: Westminster City Council <https://www.westminster.gov.uk/> Sponsored-by: Royal Borough of Kensington and Chelsea <https://www.rbkc.gov.uk/> Sponsored-by: LibraryOn Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #45 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193074&action=edit Bug 26355: Pass a patron id rather than using the stashed patron This is to allow integration with external discovery systems that may use an API user rather than the specific patron account -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Christopher Brannon <cbrannon@cdalibrary.org> --- There are a few problems I came across on these steps: Step 18 should make the renewal link disappear regardless of NotifyBorrowerDeparture. Step 37 requires a refresh for the new message to show up. Step 46 is not recorded in patron record or modifications anywhere. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193073|0 |1 is obsolete| | --- Comment #49 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193250&action=edit Bug 26355: Add unit and API tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193074|0 |1 is obsolete| | --- Comment #51 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193252&action=edit Bug 26355: Pass a patron id rather than using the stashed patron This is to allow integration with external discovery systems that may use an API user rather than the specific patron account -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #53 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- (In reply to Christopher Brannon from comment #47)

There are a few problems I came across on these steps:

Step 18 should make the renewal link disappear regardless of NotifyBorrowerDeparture.

Yes it should, I've amended this

Step 37 requires a refresh for the new message to show up.

No refresh is required for me - the message displays directly in the modal when "No" is pressed

Step 46 is not recorded in patron record or modifications anywhere.

There isn't anything to store for these verification checks, they are simply for the library to be able to preempt the user with any questions that may cause issues with their renewal and then follow-up with the customised error message with further instructions. Detail changes etc are handled through the user details form if OPACPatronDetails is switched on. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #56 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193522&action=edit Bug 26355: DBIC file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #58 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193524&action=edit Bug 26355: Add the new category fields to the UI -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #60 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193526&action=edit Bug 26355: Add the class methods and endpoint to handle renewal This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add information to display to the patron at the start of the process. - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to be blank 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the category, set a message in the “Self-renewal information message” 40. In the OPAC, refresh the page and then click the renewal link again 41. You should be met with the modal, this time displaying the information message we just set up in the patron attributes 42. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 43. This time when prompted with the “Are you sure” message, click “Yes” 44. The page should refresh and display a confirmation with the new expiry date. 45. In the intranet, view the patron’s record - the date should have been updated 46. In the Modification log tab, there should be a log entry for “Membership renewed” 47. Change the patron’s expiry date again, this time to be yesterday’s date 48. In the OPAC, click on “Personal detail”, the new expiry date should show there 49. Now set the OPACPatronDetails syspref to be “Allow” 50. Click on “Summary” again, the self-renewal link should be there again 51. Click into the self-renewal process and click “Yes” on your verification step 52. This time you should be met with a message that says “Confirm your account details” 53. Click “Continue” - you will be redirected to the OPAC details form 54. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 55. Update a field somewhere on the patron form 56. Scroll to the bottom - the button should say “Submit renewal request” 57. Click this button 58. You will be shown the renewal confirmation message 59. In the intranet, on the homepage you should now see a modification request 60. Check the request, it should match the fields you changed - don’t approve or deny for now 61. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 62. Reset your patron’s expiry date to today’s date 63. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 64. The renewal link will be visible again - go through the process again 65. On the form, you should see an alert that you have already sent a modification request 66. This time, change a different field to the previous attempt 67. Submit the form 68. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 69. prove t/db_dependent/Koha/Patron.t 70. prove t/db_dependent/api/v1/patrons_self_renewal.t 71. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 72. Sign off! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193251|0 |1 is obsolete| | --- Comment #62 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193528&action=edit Bug 26355: Add cypress tests Adds categories to the db insertion mechanics and allows values to be passed to the patron insertion method -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193070|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193249|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #64 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- (In reply to Christopher Brannon from comment #54)

(In reply to Matt Blenkinsop from comment #53)

...

...

Step 46 is not recorded in patron record or modifications anywhere.

There isn't anything to store for these verification checks, they are simply for the library to be able to preempt the user with any questions that may cause issues with their renewal and then follow-up with the customised error message with further instructions. Detail changes etc are handled through the user details form if OPACPatronDetails is switched on.

I think this is problematic. If it is not meant to show the answer, then it should not show in the list of borrower attributes in the patron account. I think if the Self-renewal verification check is checked, it should exclude it from being shown with the other attributes. Otherwise, I think this could cause problems down the road. Again, this could lead to problems down the road, especially with reports and other borrower field requirements/exclusions.

This setting also does not specify that this attribute does not record input, nor does it specify that this is a yes/no question, nor does it specify what the result of either answer will do. It is extremely vague on the surface.

I think that this setting should also disable all other settings that can't apply if this setting is checked.

I've removed patron extended attributes from the concept and replaced it with an information message that can be defined in the category and displayed to the user if required as part of a yes/no information and verification step. I've updated the test plan and have set the status back to NSO to check the new changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #66 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193635&action=edit Bug 26355: (follow-up) Allow the setting of multiple information messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193654|0 |1 is obsolete| | --- Comment #68 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193699&action=edit Bug 26355: (follow-up) Allow the setting of multiple information messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193522|0 |1 is obsolete| | --- Comment #70 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193757&action=edit Bug 26355: DBIC file -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193524|0 |1 is obsolete| | --- Comment #72 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193759&action=edit Bug 26355: Add the new category fields to the UI -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193526|0 |1 is obsolete| | --- Comment #74 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193761&action=edit Bug 26355: Add the class methods and endpoint to handle renewal This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add information to display to the patron at the start of the process. - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to be blank 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the category, set a message in the “Self-renewal information message” 40. In the OPAC, refresh the page and then click the renewal link again 41. You should be met with the modal, this time displaying the information message we just set up in the patron attributes 42. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 43. This time when prompted with the “Are you sure” message, click “Yes” 44. The page should refresh and display a confirmation with the new expiry date. 45. In the intranet, view the patron’s record - the date should have been updated 46. In the Modification log tab, there should be a log entry for “Membership renewed” 47. Change the patron’s expiry date again, this time to be yesterday’s date 48. In the OPAC, click on “Personal detail”, the new expiry date should show there 49. Now set the OPACPatronDetails syspref to be “Allow” 50. Click on “Summary” again, the self-renewal link should be there again 51. Click into the self-renewal process and click “Yes” on your verification step 52. This time you should be met with a message that says “Confirm your account details” 53. Click “Continue” - you will be redirected to the OPAC details form 54. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 55. Update a field somewhere on the patron form 56. Scroll to the bottom - the button should say “Submit renewal request” 57. Click this button 58. You will be shown the renewal confirmation message 59. In the intranet, on the homepage you should now see a modification request 60. Check the request, it should match the fields you changed - don’t approve or deny for now 61. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 62. Reset your patron’s expiry date to today’s date 63. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 64. The renewal link will be visible again - go through the process again 65. On the form, you should see an alert that you have already sent a modification request 66. This time, change a different field to the previous attempt 67. Submit the form 68. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 69. prove t/db_dependent/Koha/Patron.t 70. prove t/db_dependent/api/v1/patrons_self_renewal.t 71. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 72. Sign off! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193528|0 |1 is obsolete| | --- Comment #76 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193763&action=edit Bug 26355: Add cypress tests Adds categories to the db insertion mechanics and allows values to be passed to the patron insertion method -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193699|0 |1 is obsolete| | --- Comment #78 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 193765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193765&action=edit Bug 26355: (follow-up) Allow the setting of multiple information messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #80 from Christopher Brannon <cbrannon@cdalibrary.org> --- If you fix this, I am happy to sign off. :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #82 from Christopher Brannon <cbrannon@cdalibrary.org> --- Created attachment 193921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193921&action=edit Clear link doesn't work. The link to clear the message box in step 39 doesn't work for existing and new boxes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #83 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 194435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194435&action=edit Bug 26355: (follow-up) Allow the 'Clear' button to remove empty messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|barbara.johnson@bedfordtx.g | |ov | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193757|0 |1 is obsolete| | --- Comment #86 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 194465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194465&action=edit Bug 26355: DBIC file Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193759|0 |1 is obsolete| | --- Comment #88 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 194467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194467&action=edit Bug 26355: Add the new category fields to the UI Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193761|0 |1 is obsolete| | --- Comment #90 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 194469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194469&action=edit Bug 26355: Add the class methods and endpoint to handle renewal This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add information to display to the patron at the start of the process. - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to be blank 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the category, set a message in the “Self-renewal information message” 40. In the OPAC, refresh the page and then click the renewal link again 41. You should be met with the modal, this time displaying the information message we just set up in the patron attributes 42. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 43. This time when prompted with the “Are you sure” message, click “Yes” 44. The page should refresh and display a confirmation with the new expiry date. 45. In the intranet, view the patron’s record - the date should have been updated 46. In the Modification log tab, there should be a log entry for “Membership renewed” 47. Change the patron’s expiry date again, this time to be yesterday’s date 48. In the OPAC, click on “Personal detail”, the new expiry date should show there 49. Now set the OPACPatronDetails syspref to be “Allow” 50. Click on “Summary” again, the self-renewal link should be there again 51. Click into the self-renewal process and click “Yes” on your verification step 52. This time you should be met with a message that says “Confirm your account details” 53. Click “Continue” - you will be redirected to the OPAC details form 54. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 55. Update a field somewhere on the patron form 56. Scroll to the bottom - the button should say “Submit renewal request” 57. Click this button 58. You will be shown the renewal confirmation message 59. In the intranet, on the homepage you should now see a modification request 60. Check the request, it should match the fields you changed - don’t approve or deny for now 61. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 62. Reset your patron’s expiry date to today’s date 63. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 64. The renewal link will be visible again - go through the process again 65. On the form, you should see an alert that you have already sent a modification request 66. This time, change a different field to the previous attempt 67. Submit the form 68. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 69. prove t/db_dependent/Koha/Patron.t 70. prove t/db_dependent/api/v1/patrons_self_renewal.t 71. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 72. Sign off! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193763|0 |1 is obsolete| | --- Comment #92 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 194471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194471&action=edit Bug 26355: Add cypress tests Adds categories to the db insertion mechanics and allows values to be passed to the patron insertion method Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193765|0 |1 is obsolete| | --- Comment #94 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 194473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194473&action=edit Bug 26355: (follow-up) Allow the setting of multiple information messages Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #96 from Christopher Brannon <cbrannon@cdalibrary.org> --- Not a blocker, but I don't know if when adding a new Self-renewal information message box is supposed to duplicate the information in the box or not. But everything works as described. Great work! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194464|0 |1 is obsolete| | --- Comment #97 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 194753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194753&action=edit Bug 26355: Add new columns to the patron categories table Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194466|0 |1 is obsolete| | --- Comment #99 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 194755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194755&action=edit Bug 26355: Update the API specs Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194468|0 |1 is obsolete| | --- Comment #101 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 194757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194757&action=edit Bug 26355: Add a Vue island for the self-renewal modal Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194470|0 |1 is obsolete| | --- Comment #103 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 194759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194759&action=edit Bug 26355: Update the OPAC templates to support the Vue island Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194472|0 |1 is obsolete| | --- Comment #105 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 194761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194761&action=edit Bug 26355: Add unit tests Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194474|0 |1 is obsolete| | --- Comment #107 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 194764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194764&action=edit Bug 26355: (follow-up) Allow the 'Clear' button to remove empty messages Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #110 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Matt Blenkinsop from comment #109)

Created attachment 194780 [details] [review] Bug 26355: (follow-up) Fix handling of extended attributes

Extended attributes weren't being identified as changes and so need to be checked to see if any of them have changed

(cherry picked from commit 830a98fe8ce0b0562ffbaed84a3182b89c6840b4)

Good catch! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow patrons to self-renew |Allow patron account |through the OPAC |renewals through the OPAC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194753|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #113 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 195756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195756&action=edit Bug 26355: DBIC file Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #115 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 195758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195758&action=edit Bug 26355: Add the new category fields to the UI Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #117 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 195760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195760&action=edit Bug 26355: Add the class methods and endpoint to handle renewal This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add information to display to the patron at the start of the process. - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to be blank 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the category, set a message in the “Self-renewal information message” 40. In the OPAC, refresh the page and then click the renewal link again 41. You should be met with the modal, this time displaying the information message we just set up in the patron attributes 42. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 43. This time when prompted with the “Are you sure” message, click “Yes” 44. The page should refresh and display a confirmation with the new expiry date. 45. In the intranet, view the patron’s record - the date should have been updated 46. In the Modification log tab, there should be a log entry for “Membership renewed” 47. Change the patron’s expiry date again, this time to be yesterday’s date 48. In the OPAC, click on “Personal detail”, the new expiry date should show there 49. Now set the OPACPatronDetails syspref to be “Allow” 50. Click on “Summary” again, the self-renewal link should be there again 51. Click into the self-renewal process and click “Yes” on your verification step 52. This time you should be met with a message that says “Confirm your account details” 53. Click “Continue” - you will be redirected to the OPAC details form 54. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 55. Update a field somewhere on the patron form 56. Scroll to the bottom - the button should say “Submit renewal request” 57. Click this button 58. You will be shown the renewal confirmation message 59. In the intranet, on the homepage you should now see a modification request 60. Check the request, it should match the fields you changed - don’t approve or deny for now 61. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 62. Reset your patron’s expiry date to today’s date 63. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 64. The renewal link will be visible again - go through the process again 65. On the form, you should see an alert that you have already sent a modification request 66. This time, change a different field to the previous attempt 67. Submit the form 68. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 69. prove t/db_dependent/Koha/Patron.t 70. prove t/db_dependent/api/v1/patrons_self_renewal.t 71. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 72. Sign off! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #119 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 195762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195762&action=edit Bug 26355: Add cypress tests Adds categories to the db insertion mechanics and allows values to be passed to the patron insertion method Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #121 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 195764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195764&action=edit Bug 26355: (follow-up) Allow the setting of multiple information messages Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #123 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 195766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195766&action=edit Bug 26355: (QA follow-up) perl tidy to address qa tool errors Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195755|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195757|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195765|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195767|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #126 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 197418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197418&action=edit Bug 26355: DBIC file Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #128 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 197420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197420&action=edit Bug 26355: Add the new category fields to the UI Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #130 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 197422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197422&action=edit Bug 26355: Add the class methods and endpoint to handle renewal This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add information to display to the patron at the start of the process. - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to be blank 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the category, set a message in the “Self-renewal information message” 40. In the OPAC, refresh the page and then click the renewal link again 41. You should be met with the modal, this time displaying the information message we just set up in the patron attributes 42. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 43. This time when prompted with the “Are you sure” message, click “Yes” 44. The page should refresh and display a confirmation with the new expiry date. 45. In the intranet, view the patron’s record - the date should have been updated 46. In the Modification log tab, there should be a log entry for “Membership renewed” 47. Change the patron’s expiry date again, this time to be yesterday’s date 48. In the OPAC, click on “Personal detail”, the new expiry date should show there 49. Now set the OPACPatronDetails syspref to be “Allow” 50. Click on “Summary” again, the self-renewal link should be there again 51. Click into the self-renewal process and click “Yes” on your verification step 52. This time you should be met with a message that says “Confirm your account details” 53. Click “Continue” - you will be redirected to the OPAC details form 54. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 55. Update a field somewhere on the patron form 56. Scroll to the bottom - the button should say “Submit renewal request” 57. Click this button 58. You will be shown the renewal confirmation message 59. In the intranet, on the homepage you should now see a modification request 60. Check the request, it should match the fields you changed - don’t approve or deny for now 61. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 62. Reset your patron’s expiry date to today’s date 63. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 64. The renewal link will be visible again - go through the process again 65. On the form, you should see an alert that you have already sent a modification request 66. This time, change a different field to the previous attempt 67. Submit the form 68. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 69. prove t/db_dependent/Koha/Patron.t 70. prove t/db_dependent/api/v1/patrons_self_renewal.t 71. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 72. Sign off! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #132 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 197424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197424&action=edit Bug 26355: Add cypress tests Adds categories to the db insertion mechanics and allows values to be passed to the patron insertion method Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #134 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 197426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197426&action=edit Bug 26355: (follow-up) Allow the setting of multiple information messages Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #136 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 197428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197428&action=edit Bug 26355: (QA follow-up) perl tidy to address qa tool errors Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #138 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Sorry Matt, these tests are failing for me and I think it is because I pushed Bug 41733 yesterday. Also: [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt FAIL forbidden_patterns forbidden pattern: <script> elements must have a "src" or "nonce" attribute (line 1024) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197417|0 |1 is obsolete| | Attachment #197418|0 |1 is obsolete| | Attachment #197419|0 |1 is obsolete| | Attachment #197420|0 |1 is obsolete| | Attachment #197421|0 |1 is obsolete| | Attachment #197422|0 |1 is obsolete| | Attachment #197423|0 |1 is obsolete| | Attachment #197424|0 |1 is obsolete| | Attachment #197425|0 |1 is obsolete| | Attachment #197426|0 |1 is obsolete| | Attachment #197427|0 |1 is obsolete| | Attachment #197428|0 |1 is obsolete| | Attachment #197429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #140 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197897&action=edit Bug 26355: DBIC file Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #142 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197899&action=edit Bug 26355: Add the new category fields to the UI Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #144 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197902&action=edit Bug 26355: Add the class methods and endpoint to handle renewal This is part of a sponsored piece of development from one of our customers. There was a specification of requirements but I was conscious of the ideas already discussed on this bug and wanted to try and develop a solution that would balance both sets of requirements. The concept works as follows: - Self-renewal can be enabled and controlled at a category level - The window within which it is available is customisable (both pre and post-expiry) - Defaults to the NotifyBorrowerDeparture syspref - The amount in fines that block self-renewal is customisable - Defaults to the category level charges and then the noissescharge preference - The message to display if renewal fails is customisable - Libraries can also add information to display to the patron at the start of the process. - The self-renewal process will also respect the OPACPatronDetails and AutoApprovePatronProfileSettings sysprefs. If OPACPatronDetails is enabled, the renewal will redirect the patron to the OPAC details form and ask them to confirm their details are still correct. Any changes will be logged as patron modifications and approved in line with the auto approval syspref - Renewal happens regardless of whether OPACPatronDetails is enabled, only the details changes are logged as modification requests - Notifications are sent to the patron in line with their messaging preferences Test plan: 1. Apply all patches and reset_all 2. In the intranet, navigate to patron categories and edit the ‘Patron’ category 3. Scroll to the bottom, there should be a section called ‘Account expiry and self-renewal’ 4. Set ‘Allow self-renewal’ to Yes 5. Set Self-renewal availability period to be 10 days 6. Set Self-renewal availability post-expiry’ to also be 10 days and save 7. In system preferences, set the OPACPatronDetails preference to ‘Don’t allow’ 8. Choose a patron that has the ‘Patron’ type category 9. Edit that patron so that you can log into the OPAC and set their expiry date to be yesterday’s date 10. Log into the OPAC as that patron (it may be easiest to do this in incognito as we will be swapping between the intranet and OPAC throughout the test plan and it will remove the need to keep logging out and in) 11. You should see a message that says “You are eligible for self-renewal. Please click here to renew your account.” 12. Click that link - you will be presented with a modal that says “Are you sure you want to renew your account?” 13. Click “Close” - we don’t want to complete renewal yet as there is more functionality available to test 14. Navigate to the patron category again, set ‘Self-renewal availability post-expiry’ to be 0 15. Refresh the OPAC, the self-renewal link should not be there as we are now outside the patron self-renewal window 16. Undo that change in the patron category, the link should reappear when refreshing the OPAC 17. Now set the patron’s expiry date to be tomorrow 18. In the category, set ‘Self-renewal availability period’ to be blank 19. Refresh the OPAC, it should still show the link as it is defaulting to NotifyBorrowerDeparture 20. Set NotifyBorrowerDeparture to 0 21. Refresh the OPAC, the link should vanish 22. In the category, restore ‘Self-renewal availability period’ to 10 days 23. Refresh the OPAC, the link should reappear 24. In the intranet, set the patron to be debarred using a manual restriction 25. In the OPAC refresh the page - self-renewal should no longer be available 26. Remove the restriction - the renewal link will be visible again 27. Set a fine on the patron record of 6 USD 28. Refresh the OPAC, the self-renewal link will be gone because we are over the global ‘noissuescharge’ preference value of 5 29. In the category, set ‘Checkout charge limit’ to 7 30. Refresh the OPAC, the link will be visible because we are now under the category charge 31. Add an additional fine of 2 to the patron account 32. Refresh the OPAC, the self-renewal link is gone 33. In the category, set ‘Self-renewal charge limit’ to be 10 34. Refresh the OPAC, the link will be visible again 35. In the category, set ‘Self-renewal failure message’ to be whatever you want 36. In the OPAC, refresh the page and then click into the self-renewal process 37. This time, click “No” - you should see the failure message you have just set 38. Click “Close” and refresh the page to reset this message 39. In the category, set a message in the “Self-renewal information message” 40. In the OPAC, refresh the page and then click the renewal link again 41. You should be met with the modal, this time displaying the information message we just set up in the patron attributes 42. Click “Yes” - you should see the “Are you sure you want to renew your account?” message again 43. This time when prompted with the “Are you sure” message, click “Yes” 44. The page should refresh and display a confirmation with the new expiry date. 45. In the intranet, view the patron’s record - the date should have been updated 46. In the Modification log tab, there should be a log entry for “Membership renewed” 47. Change the patron’s expiry date again, this time to be yesterday’s date 48. In the OPAC, click on “Personal detail”, the new expiry date should show there 49. Now set the OPACPatronDetails syspref to be “Allow” 50. Click on “Summary” again, the self-renewal link should be there again 51. Click into the self-renewal process and click “Yes” on your verification step 52. This time you should be met with a message that says “Confirm your account details” 53. Click “Continue” - you will be redirected to the OPAC details form 54. There should be a message at the top that says “Please verify your details to proceed with your self-renewal.” 55. Update a field somewhere on the patron form 56. Scroll to the bottom - the button should say “Submit renewal request” 57. Click this button 58. You will be shown the renewal confirmation message 59. In the intranet, on the homepage you should now see a modification request 60. Check the request, it should match the fields you changed - don’t approve or deny for now 61. Set ‘AutoApprovePatronProfileSettings’ in sysprefs to “Enable” 62. Reset your patron’s expiry date to today’s date 63. In the OPAC, click into Personal details and then back into Summary again (we need to do this to remove the success parameter from the URL) 64. The renewal link will be visible again - go through the process again 65. On the form, you should see an alert that you have already sent a modification request 66. This time, change a different field to the previous attempt 67. Submit the form 68. In the intranet there should be no modification this time and the change should be visible in the patron record as it has been automatically approved and handled as per the syspref 69. prove t/db_dependent/Koha/Patron.t 70. prove t/db_dependent/api/v1/patrons_self_renewal.t 71. yarn cypress run --spec t/cypress/integration/Islands/SelfRenewal.ts 72. Sign off! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #146 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197904&action=edit Bug 26355: Add cypress tests Adds categories to the db insertion mechanics and allows values to be passed to the patron insertion method Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #148 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197906&action=edit Bug 26355: (follow-up) Allow the setting of multiple information messages Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #150 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197908&action=edit Bug 26355: (QA follow-up) perl tidy to address qa tool errors Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #152 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197910&action=edit Bug 26355: (QA follow-up) Add CSP nonce to inline module script The forbidden_patterns QA check requires <script> elements to have either a "src" or "nonce" attribute. The inline module script that hydrates the Vue island in opac-user.tt was missing a nonce. Test plan: 1. Run the QA tool against opac-user.tt; forbidden_patterns should no longer report the inline <script> on line 1024. 2. Load the OPAC user summary page and confirm the Vue island still hydrates (no CSP violation in the browser console). Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 --- Comment #154 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 197912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197912&action=edit Bug 26355: (QA follow-up) Strip self_renewal_available in EmailPatronRegistrations tests to_api now returns the derived self_renewal_available field, so reusing a to_api'd patron as the POST body for /api/v1/patrons fails with 500 (the value has no matching DB column). Adjacent subtests already delete this read-only field before POSTing; do the same in the EmailPatronRegistrations subtest. Test plan: 1. prove t/db_dependent/api/v1/patrons.t — all tests pass. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197896|0 |1 is obsolete| | Attachment #197897|0 |1 is obsolete| | Attachment #197898|0 |1 is obsolete| | Attachment #197899|0 |1 is obsolete| | Attachment #197901|0 |1 is obsolete| | Attachment #197902|0 |1 is obsolete| | Attachment #197903|0 |1 is obsolete| | Attachment #197904|0 |1 is obsolete| | Attachment #197905|0 |1 is obsolete| | Attachment #197906|0 |1 is obsolete| | Attachment #197907|0 |1 is obsolete| | Attachment #197908|0 |1 is obsolete| | Attachment #197909|0 |1 is obsolete| | Attachment #197910|0 |1 is obsolete| | Attachment #197911|0 |1 is obsolete| | Attachment #197912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.