[Bug 21608] New: Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Bug ID: 21608 Summary: Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1 - Find a record with multiple items 2 - Place 4 holds (or more) 3 - Capture one ohld as waiting, one as in transit 4 - View the holds on the record - switch the last to priority one 5 - Waiting and transit statuses get confused -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19636 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- This seems to be the changes on 19636 that doesn't account for waiting and transit holds when renumbering Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19636 [Bug 19636] Hold priority changes incorrectly via dropdown select -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80933&action=edit Bug 21608: WIP - attempt to fix priority dropdowns (18.05 based) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80933|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81131&action=edit Bug 21608: Disable dropdown for found holds - add button to revert To test: 1 - Find a record with multiple items 2 - Place 4 holds (or more) 3 - Capture one ohld as waiting, one as in transit 4 - View the holds on the record - switch the last to priority one 5 - Waiting and transit statuses get confused 6 - Apply patch 7 - Observe dropdown is now disabled for waiting holds 8 - Confirm other holds operate as expected 9 - Confirm 'Revert found status' resets hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate, | |rel_18_11_candidate Depends on| |21611 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|normal |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 [Bug 21611] Priority in request.pl shows 1 instead of Waiting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- While this patch depends on 21611 we will need an 18.05 version which does not. Can provide once this one is through QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81131|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81134&action=edit Bug 21608: Disable dropdown for found holds - add button to revert This patch disables the dropdown for found holds, and adds a new button to revert the waiting status, setting the hold to priority 1 Additionally we remove some changes from 19469 and update the JS to skip found holds when updating priority To test: 1 - Find a record with multiple items 2 - Place 4 holds (or more) 3 - Capture one ohld as waiting, one as in transit 4 - View the holds on the record - switch the last to priority one 5 - Waiting and transit statuses get confused 6 - Apply patch 7 - Observe dropdown is now disabled for waiting holds 8 - Confirm other holds operate as expected 9 - Confirm 'Revert found status' resets hold -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81134|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81272&action=edit Bug 21608: Disable dropdown for found holds - add button to revert This patch disables the dropdown for found holds, and adds a new button to revert the waiting status, setting the hold to priority 1 Additionally we remove some changes from 19469 and update the JS to skip found holds when updating priority To test: 1 - Find a record with multiple items 2 - Place 4 holds (or more) 3 - Capture one ohld as waiting, one as in transit 4 - View the holds on the record - switch the last to priority one 5 - Waiting and transit statuses get confused 6 - Apply patch 7 - Observe dropdown is now disabled for waiting holds 8 - Confirm other holds operate as expected 9 - Confirm 'Revert found status' resets hold Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, Signing Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only thing I am not sure about is the label: Revert found status I am not sure if that is easy to understand/translate, but haven't found a better description yet. (not blocker) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The revert "feature to found" doesn't work correctly for me. I had 2 items in transit and one waiting. I reverted 1 transit and 1 waiting. On the holds page, everything looks like expected. BUT: the items are all wrong on normal view. All items are still in transit or waiting. As this is also marked for backporting, maybe we should have a patch without the revert to found button? I'd also suggest to add at least an id to it, so libraries can hide it if necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, might have missed a reload, display is now correct for the items. I see some problems with reverting: If the patron has chosen an expiration date on placing the hold, it will be overwritten by the pickup date when the hold is found. So all we can do now is revert to "empty" as there is no way to tell the old expiration date. These 2 things should be 2 different fields in db. If the hold was formerly a record level hold, it's a item level hold after reverting. The only indicator if we have an item level or record level hold is the itemnumber field being set or not. As it's always set after the hold has been found, there is no clean way to revert from this either. Without this patch you can only change the hold from "Waiting" to "del" - which means you can only cancel it. I am not sure about the the changed behaviour, especially as this is marked for backporting to 18.05. Maybe we should fix the display here but leave the new button for a separate bug report? We could still lock the pull down maybe - the hold can still be deleted using the red X. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
Sorry, might have missed a reload, display is now correct for the items.
I see some problems with reverting:
If the patron has chosen an expiration date on placing the hold, it will be overwritten by the pickup date when the hold is found. So all we can do now is revert to "empty" as there is no way to tell the old expiration date. These 2 things should be 2 different fields in db.
If the hold was formerly a record level hold, it's a item level hold after reverting. The only indicator if we have an item level or record level hold is the itemnumber field being set or not. As it's always set after the hold has been found, there is no clean way to revert from this either.
This has been existing behaviour through 17.11 - with bug 19636 we saw the dropdowns begin to work incorrectly
Without this patch you can only change the hold from "Waiting" to "del" - which means you can only cancel it.
I think this was accidental change of behaviour in 21611
I am not sure about the the changed behaviour, especially as this is marked for backporting to 18.05. Maybe we should fix the display here but leave the new button for a separate bug report?
I am happy to split this on a bug report, but if we remove this feature/don't repair it I expect there will be complaints from the user Use case example: 1 - Item arrives at library for a next available hold 2 - Hold is triggered, item is set to 'waiting' 3 - Patron calls, "Can you please send the book to library X/" 4 - We revert hold to priority 1, change pickup location, check in and route to correct library I can split the revert to its own bug, but I would be inclined to file it as a bug and consider for backport
We could still lock the pull down maybe - the hold can still be deleted using the red X.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I wasn't aware it has ever worked (changing priority once waiting). So only one fix needed then: When you revert, you need to clear the expiration date, or the reverted hold will expire way too soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21729 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #12)
Hm, I wasn't aware it has ever worked (changing priority once waiting).
So only one fix needed then: When you revert, you need to clear the expiration date, or the reverted hold will expire way too soon.
Katrin and I discussed this today - while the expiration date reset may be desirable this bug restores existing behaviour from 17.11 New bug 21729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21729 [Bug 21729] When reverting a hold the expirationdate should be reset? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- *** Bug 21752 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 81835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81835&action=edit Bug 21608: (follow-up) Use RevertWaitingStatus and do not alter _FixPriority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|Trivial patch |Small patch --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Time too short, not trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Bug 21608 depends on bug 21611, which changed state. Bug 21611 Summary: Priority in request.pl shows 1 instead of Waiting https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21611 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc FAIL filters missing_filter at line 194 ( <input type="button" value="Revert found status" onclick="window.location.href='request.pl?action=move&where=down&first_priority=[% first_priority | html %]&last_priority=[% last_priority | html %]&prev_priority=0&next_priority=1&borrowernumber=[% hold.borrowernumber | html %]&biblionumber=[% hold.biblionumber | html %]&itemnumber=[% hold.itemnumber %]&reserve_id=[% hold.reserve_id | html %]&date=[% hold.date | html %]'">) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Having another try -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #14)
Tests missing.
Definitely! Interventions in Reserves need tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #20)
(In reply to Jonathan Druart from comment #14)
Tests missing.
Definitely! Interventions in Reserves need tests.
And reverting change A in patch B is not my favorite either. Squash them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. If I have one waiting and one on pos 1, I can select pos 2 in the priority box and it automatically selects pos 1 again. This is sort of OK but still confusing. Pos 2 should not be there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81272|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82157&action=edit Bug 21608: Disable dropdown for found holds - add button to revert This patch disables the dropdown for found holds, and adds a new button to revert the waiting status, setting the hold to priority 1 Additionally we remove some changes from 19469 and update the JS to skip found holds when updating priority To test: 1 - Find a record with multiple items 2 - Place 4 holds (or more) 3 - Capture one ohld as waiting, one as in transit 4 - View the holds on the record - switch the last to priority one 5 - Waiting and transit statuses get confused 6 - Apply patch 7 - Observe dropdown is now disabled for waiting holds 8 - Confirm other holds operate as expected 9 - Confirm 'Revert found status' resets hold Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 21608: (follow-up) Use RevertWaitingStatus and do not alter _FixPriority [EDIT] Squashed. Completely removed the changes to Reserves.pm by adding module prefix in the request.pl script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is a Passed QA with some reservation (as is appropriate for holds patches indeed :) I do not feel completely comfortable with the patch somehow. Intuitively. But I cant say that it is wrong. And the region is a bit buggy. So I pass it on to the RM. He will be able to view it as objectively as possible ;) Leaning a bit here on the tests by Martin and Katrin too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Oops forgot this suggestion: Rename: Revert found status => Revert waiting status And two functional questions: Should someone be informed about this revert? Or should we make the button preference controlled ? Have fun ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #25)
Oops forgot this suggestion: Rename: Revert found status => Revert waiting status
This affects 'In-transit' holds too, I will add an id to the button
And two functional questions: Should someone be informed about this revert? Or should we make the button preference controlled ?
I think yes, on both of these, however, we are restoring behvaiour (buggy, but existing) so it should be a new report
Have fun !
:-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82322&action=edit Bug 21608: Add ID and fix filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- If no adjustments are made and 'Update holds' is clicked then any waiting holds are reverted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82652&action=edit Bug 21608: Add value for 'rank-request' when dropdwn disabled When a field is disabled no value is submitted in the form - this was causing found holds to be reverted To test: 1 - Apply all patches except this one 2 - PLace several holds on one bib 3 - Set at least one waiting or intransit 4 - Making no adjustments hit "Update holds" 5 - Waiting/intransit holds are all reset 6 - Mark them waiting/intransit again 7 - Apply this patch 8 - Click 'update holds' 9 - Found status is not accidentally reverted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82157|0 |1 is obsolete| | Attachment #82322|0 |1 is obsolete| | Attachment #82652|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82956&action=edit Bug 21608: Disable dropdown for found holds - add button to revert This patch disables the dropdown for found holds, and adds a new button to revert the waiting status, setting the hold to priority 1 Additionally we remove some changes from 19469 and update the JS to skip found holds when updating priority To test: 1 - Find a record with multiple items 2 - Place 4 holds (or more) 3 - Capture one ohld as waiting, one as in transit 4 - View the holds on the record - switch the last to priority one 5 - Waiting and transit statuses get confused 6 - Apply patch 7 - Observe dropdown is now disabled for waiting holds 8 - Confirm other holds operate as expected 9 - Confirm 'Revert found status' resets hold Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Bug 21608: (follow-up) Use RevertWaitingStatus and do not alter _FixPriority [EDIT] Completely removed the changes to Reserves.pm by adding module prefix in the request.pl script. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82957&action=edit Bug 21608: Add ID and fix filters Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82958&action=edit Bug 21608: Add value for 'rank-request' when dropdwn disabled When a field is disabled no value is submitted in the form - this was causing found holds to be reverted To test: 1 - Apply all patches except this one 2 - PLace several holds on one bib 3 - Set at least one waiting or intransit 4 - Making no adjustments hit "Update holds" 5 - Waiting/intransit holds are all reset 6 - Mark them waiting/intransit again 7 - Apply this patch 8 - Click 'update holds' 9 - Found status is not accidentally reverted Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 82959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82959&action=edit Bug 21608: (QA follow-up) Rename revert button The label 'Revert found status' is replaced by 'Revert waiting status' or 'Revert transit status' depending on hold.found/hold.intransit. Note that hold comes from reserveloop in request.pl. The columns/keys found and intransit are just booleans. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #36 from Jesse Maseto <jesse@bywatersolutions.com> --- Will not be backported to 18.05. Merge conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 83541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83541&action=edit Bug 21608: [18.05.X] disable dropdown and add revert button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #37)
Created attachment 83541 [details] [review] Bug 21608: [18.05.X] disable dropdown and add revert button
Please test thoroughly - dropdown counts are higher that they should be, but I think this exists in master too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 rkuiper@roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23502 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23502 [Bug 23502] Staff client "revert status" buttons should not depend on SuspendHoldsIntranet preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #39 from David Cook <dcook@prosentient.com.au> --- _FixPriority seems horrifically broken. I was really hoping that someone else had already fixed it... heh -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |18.11.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org