https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
Sorry, might have missed a reload, display is now correct for the items.
I see some problems with reverting:
If the patron has chosen an expiration date on placing the hold, it will be overwritten by the pickup date when the hold is found. So all we can do now is revert to "empty" as there is no way to tell the old expiration date. These 2 things should be 2 different fields in db.
If the hold was formerly a record level hold, it's a item level hold after reverting. The only indicator if we have an item level or record level hold is the itemnumber field being set or not. As it's always set after the hold has been found, there is no clean way to revert from this either.
This has been existing behaviour through 17.11 - with bug 19636 we saw the dropdowns begin to work incorrectly
Without this patch you can only change the hold from "Waiting" to "del" - which means you can only cancel it.
I think this was accidental change of behaviour in 21611
I am not sure about the the changed behaviour, especially as this is marked for backporting to 18.05. Maybe we should fix the display here but leave the new button for a separate bug report?
I am happy to split this on a bug report, but if we remove this feature/don't repair it I expect there will be complaints from the user Use case example: 1 - Item arrives at library for a next available hold 2 - Hold is triggered, item is set to 'waiting' 3 - Patron calls, "Can you please send the book to library X/" 4 - We revert hold to priority 1, change pickup location, check in and route to correct library I can split the revert to its own bug, but I would be inclined to file it as a bug and consider for backport
We could still lock the pull down maybe - the hold can still be deleted using the red X.
-- You are receiving this mail because: You are watching all bug changes.