[Bug 38307] New: Make overdue_notices.pl quiet if there are no branches with active overdue rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Bug ID: 38307 Summary: Make overdue_notices.pl quiet if there are no branches with active overdue rules Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 173742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173742&action=edit Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25635 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- *** Bug 25635 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Anke Bruns <anke.bruns@gwdg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anke.bruns@gwdg.de --- Comment #3 from Anke Bruns <anke.bruns@gwdg.de> --- Not testable in a sandbox. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Keywords| |no-sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173742|0 |1 is obsolete| | --- Comment #4 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 176383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176383&action=edit Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176383|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178476&action=edit Bug 38307: Make overdue_notices.pl die quietly if no branches have overdue rules If no patron categories require overdue notices, then there will be no overdue rules/status triggers. This isn't necessarily a bad thing and shouldn't be noisy. To test: 1. Go to Administration -> Patron categories 2. Set all your category types to have overdue notice required: No 3. Go to Tools -> Overdue notices/status triggers 4. Notice you're unable to set any overdue rules 5. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error about no overdue rules is printed 6. Apply the patch and restart services 7. Run the cronjob misc/cronjobs/overdue_notices.pl and notice the error is not printed 8. Run the cronjob misc/cronjobs/overdue_notices.pl --verbose and notice the error is printed Sponsored-by: Catalyst IT Signed-off-by: Imani Thomas <imani.thomas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make overdue_notices.pl |Make overdue_notices.pl |quiet if there are no |quiet if there are no |branches with active |libraries with active |overdue rules |overdue rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38307 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org