[Bug 41604] New: Impossible to hide Checkin column in issues-table in circ/circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Bug ID: 41604 Summary: Impossible to hide Checkin column in issues-table in circ/circulation.pl Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. We had complaints about this following our first wave of upgrades from 24.05(.05) to 25.05(.06). To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check "Is hidden by default" for "checkin" 1.3. Click "Save" 2. Checkout an item to a patron 2.1. In the search bar, set to Checkout, search for Henry 2.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default I personally find the checkin column particularly dangerous as staff don't need to scan the item to return it, leading to potentially checking in items that weren't actually returned by the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Depends on| |41314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 [Bug 41314] Column visibility broken on the checkouts table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #1 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 191480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191480&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191480|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 191482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191482&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- I have decided to force the visibility of columns depending on syspref's setting. Otherwise the column visibility state is broken when the syspref's value is modified. However here it depends on permission, but the problem is the same. Try to: add superlibrarian permission to edna login with edna check an item out, and on "Details" tab (moremember, not circulation!) you can see the "check in" column. Now restrict the permission to only catalogue+borrowers Refresh moremember => With this patch the checkin column is displayed So this can be considered a bug, and that's why I forced the visibility. In discussion to get an answer from Caroline, we need to discuss if we are ready for those bugs. Also if we go with this solution I don't see a good reason to not apply the same change to the "Renew" column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Jonathan Druart from comment #3)
I have decided to force the visibility of columns depending on syspref's setting.
Which syspref controls the checkin column? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Caroline Cyr La Rose from comment #4)
(In reply to Jonathan Druart from comment #3)
I have decided to force the visibility of columns depending on syspref's setting.
Which syspref controls the checkin column?
"However here it depends on permission, but the problem is the same." I meant that in case of the "Checkin" column the visibility does not depend on a syspref, but on a permission (circulate:circulate_remaining_permissions). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Would these be all the cases? Permission Column visibility setting Column toggle Result Toggle Superlibrarian visible by default can be toggled visible enabled Superlibrarian visible by default cannot be toggled visible disabled Superlibrarian hidden by default can be toggled hidden enabled Superlibrarian hidden by default cannot be toggled hidden disabled circulate_remaining_permissions visible by default can be toggled visible enabled circulate_remaining_permissions visible by default cannot be toggled visible disabled circulate_remaining_permissions hidden by default can be toggled hidden enabled circulate_remaining_permissions hidden by default cannot be toggled hidden disabled none of the above visible by default can be toggled hidden disabled none of the above visible by default cannot be toggled hidden disabled none of the above hidden by default can be toggled hidden disabled none of the above hidden by default cannot be toggled hidden disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I think if the column is hidden in the table settings, that should trump the permissions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with Caroline: We need a way to keep the column hidden and table configuration should take precedence. And the longer comment: The checkin column is known to have problems with transports and other messages that are lost when you return from this screen. A lot of libraries have chosen not to allow this action from this page because of this. On the other hand it's needed for some use cases, like ItemfallbackSearch (no barcodes in the items) for example to have a good way to return the items. My stance would be that if you set the table configuration to: - Do not display by default - Don't allow to toggle That the column should not display and one should not be able to make it visible. I believe the permission here is just "circulate", but the higher priority should be the table configuration in this case and the more logical one. You can still circulate, but not return (a small part of it) from this page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 192316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192316&action=edit Bug 41604: Centralize visibility condition in datatables.js We want to hide column if: * the feature is not accessible (pref disabled or insufficient permissions) or * the column is hidden in the settings or * the column has been hidden by the user -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- I think this patch introduces consistent behaviour in the different situations. Can you please test it? It's not ready for inclusion, other occurrences of 'force_visibility' (in other views) will need adjustements, but the checkouts table can be tested. It affects the 4 columns: checkin, renew, claims and export. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org --- Comment #11 from Jason Robb <jrobb@sekls.org> --- This is causing major issues for us. We have the check in column hidden, as we do not want staff to check anything in unless they are physically holding an item in their hand and scan the barcode. Otherwise, bad things happen. Removing the circulate_remaining_permissions appears to remove the staff member's ability to access a patron's check out screen completely, so the only option presently is to keep the check in column visible if I want a staff account to be able to conduct checkouts. I tested the patch and it appears to restore the desired behavior. Table settings to hide the check in column are respected even when the account has the circulate_remaining_permissions ticked or the account is a superlibrarian. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194641&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Hi Jason, I have (quickly) written a patch to adjust the other occurrences. Feel free to test. However the test plan is a bit vague, it won't be easy to test if you don't look at the code to know the conditions of the visibility of the different columns. I am lacking time at the moment to provide a full test plan, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #14 from Jason Robb <jrobb@sekls.org> --- (In reply to Jonathan Druart from comment #13)
Hi Jason,
I have (quickly) written a patch to adjust the other occurrences. Feel free to test. However the test plan is a bit vague, it won't be easy to test if you don't look at the code to know the conditions of the visibility of the different columns.
I am lacking time at the moment to provide a full test plan, sorry!
Thanks for working on this! It's a lot to look at so I've not gotten too far, but I wanted to point out a mispelling in modborrowers.tt that may be impactful (https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194641&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt_sec1) At line 505 visibility_condition is spelled visility_condition: selections_column.visility_condition = selections_column_available; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #15 from Jason Robb <jrobb@sekls.org> --- There's a lot to look at here. I'm not getting through it all today so leaving some notes as reference. issues-table at circulation & moremember - checkin_column: AllowCirculate requires edit_borrowers and circulate_remaining_permissions to visit the proper pages - claims_returned_column: requires ClaimReturnedLostValue syspref enabled - export_column: requires ExportCircHistory syspref enabled orders table at basket - supplier_report_column: requires EDIFACT syspref enabled and an EDI account to exist - modify_column: basket must be open - cancel_column: basket must be open, or CancelOrdersInClosedBaskets syspref is enabled holdhistory-table at holdhistory - item_type_column: AllowHoldItemTypeSelection must be enabled borrowerst at batch_patron_modifications - selections_column (checkboxes): shown while editing, hidden on results - password_expiration_date_column: only visible to superlibrarians - protected_column: only visible to superlibrarians Table locations: - issues-table: Search a patron and click on "Check out" and/or "Details" tab on the left - orders table: Acquisitions > Search for "My vendor" > Click 1 basket > click "My basket" > Add an order if it doesn't have one - holdhistory-table: Search a patron and click on "Holds history" tab on the left - borrowerst (batch patron mod): Tools > Batch patron modification > enter a cardnumber (i.e. 42) To be able to see and test visibility of the various columns: * A superlibrarian account * A limited permission account with: - catalogue - edit_borrowers - circulate_remaining_permissions - all acquisitions permissions - view_holds_history - edit_patrons * These system preferences set: - ClaimReturnedLostValue: Lost (or other non-null value) - ExportCircHistory: Enable - EDIFACT: Enable - CancelOrdersInClosedBaskets: Enable - AllowHoldItemTypeSelection: Enable * An EDI account -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194998&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #17 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jason Robb from comment #14)
(In reply to Jonathan Druart from comment #13)
Hi Jason,
I have (quickly) written a patch to adjust the other occurrences. Feel free to test. However the test plan is a bit vague, it won't be easy to test if you don't look at the code to know the conditions of the visibility of the different columns.
I am lacking time at the moment to provide a full test plan, sorry!
Thanks for working on this! It's a lot to look at so I've not gotten too far, but I wanted to point out a mispelling in modborrowers.tt that may be impactful (https://bugs.koha-community.org/bugzilla3/attachment. cgi?id=194641&action=diff#a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/ modborrowers.tt_sec1)
At line 505 visibility_condition is spelled visility_condition: selections_column.visility_condition = selections_column_available;
Oops, fixed! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 ryanb@dubcolib.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ryanb@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #18 from Jason Robb <jrobb@sekls.org> --- The visibility of the checkbox column for batch patron modification appears broken with the patch applied. Without the patch, the checkbox column is visible on the edit page, but not on the results page. After the patch is applied, the checkbox column is visible on both the edit and results pages (which gives the results confusing checkboxes with no purpose). Without the patch: 1. Disable "Save configuration state on page change" for the batch patron mod table: a. Administration > Table settings > Tools > batch_patron_modification b. Uncheck "Save configuration state..." and click Save 2. Go to Tools > Batch patron modification 3. Give the tool a cardnumber (i.e. 42) and click Continue 4. Note the checkbox column is present on the far left 5. Click Save 6. Note the checkbox column is gone With the patch: 1. Repeat steps 2-4 above 2. Note the checkbox column is present on both the edit page and the results page Everything else seems to be testing well as far as I can tell. I made some messy notes, will try to clean them up and add the different steps I took to test in another comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Kristi Krueger <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #19 from Jason Robb <jrobb@sekls.org> --- The column visibility for non-superlibrarian staff on batch patron modification also seems to be broken. Before applying the patch, a non-superlibrarian will *not* see "Password expiration date" and "Protected" columns due to permissions. After applying the patch, if the columns are not hidden in table settings, non-superlibrarians *will* see the columns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #20 from Jason Robb <jrobb@sekls.org> --- These are the steps I took to verify table column settings were taking priority when hiding columns, while also demonstrating that syspref-controlled columns that aren't configurable in table settings continue to display correctly. This likely doesn't cover everything. Everything was done as the superlibrarian unless otherwise noted. Setup before testing: 1.) Set permissions & login for Henry - catalogue (staff access) - edit_patrons (in tools) 2.) Set system preferences so columns display in various places - ClaimReturnedLostValue: Lost (or other non-null value) - ExportCircHistory: Enable - EDIFACT: Enable - CancelOrdersInClosedBaskets: Enable - AllowHoldItemTypeSelection: Enable Check current behaviors: --Checkouts table (circulation & moremember)-- 1.) Check an item out to Henry 2.) Note the "Check in" and "Return claims" columns are visible 3.) Click "Configure" in the upper right of the table to get to table settings 4.) Check "Is hidden by default" for "checkin" and "claims_returned" 5.) Uncheck "Save configuration state on page change" (this can cause inconsistent/confusing behavior when testing) 6.) Save table settings 7.) Return to Henry's checkout screen, note those two columns are still visible 8.) Repeat steps 2-6 on Henry's Details page 9.) Navigate back to Henry's Details page, note those two columns are still visible --Holds history table-- 1.) Place a hold on a record for Henry 2.) Go to Henry's "Holds history" tab 3.) Note the "Requested item type" column 4.) Click "Configure" in the upper right of the table to get to table settings 5.) Check "Is hidden by default" for "itemtype" 6.) Uncheck "Save configuration state on page change" 7.) Save table settings 8.) Return to Henry's Holds history page, note the column is still visible --Orders table in baskets-- 1.) Add an EDI account a.) Administration > EDI accounts > New account > Submit 2.) Add an item to the existing basket a.) Acquisitions b.) Search "My vendor" c.) Click "1 basket(s)" > "My Basket" d.) Add to basket e.) Choose "From new (empty) record" > Add item > Save 3.) Note the "Supplier report" column 4.) Close the basket 5.) Note the "Supplier report" column 6.) Click "Configure" in the upper right of the table to get to table settings 7.) Check "Is hidden by default" for "supplier_report" 8.) Uncheck "Save configuration state on page change" 9.) Save 10.) Go back to the basket, note the "Supplier report" column 11.) Reopen the basket, note the "Supplier report" column --Patron batch modification table-- Note: The table settings seem to overtake permissions before the patch is applied. Logged in as Henry: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) Note the absence of the "Password expiration date" and "Protected" columns 4.) Note the checkbox column on the left 5.) Click Save 6.) Note the absence of the checkbox column on the left Logged in as superlibrarian: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) Note the "Password expiration date" and "Protected" columns 4.) Click "Configure" in the upper right of the table to get to table settings 5.) Check "Is hidden by default" for "batch_patron_edit_password_expiration_date" and "batch_patron_edit_protected" 6.) Uncheck "Save configuration state on page change" 7.) Repeat 1-2, columns are hidden 8.) Note the checkbox column on the left 9.) Click Save 10.) Note the absence of the checkbox column on the left ---> APPLY THE PATCH <--- Check new behaviors: --Checkouts table (circulation & moremember)-- 1.) Pull up Henry's circulation page 2.) "Check in" and "Return claims" columns should be hidden 3.) Pull up Henry's Details page 4.) "Check in" and "Return claims" columns should be hidden 5.) Unhide columns in the table settings and verify they display again --Holds history table-- 1.) Pull up Henry's Holds history page 2.) "Requested item type" column should be hidden 3.) Unhide column in the table settings and verify it displays again --Orders table in baskets-- 1.) Pull up the basket 2.) "Supplier report" column should be hidden 3.) Close the basket 4.) "Supplier report" column should be hidden 5.) Unhide column in the table settings and verify it displays again --Patron batch modification table-- Logged in as Henry: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) "Password expiration date" and "Protected" should still be hidden 4.) Note the checkbox column on the left 5.) Click Save 6.) Note the absence of the checkbox column on the left <-- currently not working, see comment 18 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604#c18) 7.) Unhide columns in the table settings and verify they are still hidden (Henry doesn't have permission to see them) <-- currently not working, see comment 19 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604#c19) Log in as superlibrarian: 1.) Go to Tools > Batch patron modification 2.) Enter a card number (i.e. 23529000035676) and Continue 3.) "Password expiration date" and "Protected" should still be hidden 4.) Note the checkbox column on the left 5.) Click Save 6.) Note the absence of the checkbox column on the left <-- currently not working, see comment 18 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604#c18) 7.) Unhide columns in the table settings and verify they display again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42063 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 42063 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid@gmail.com --- Comment #22 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 41468 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195313&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195314&action=edit Bug 41604: take visibility_condition when save state is disabled Patch from commit 35c8292 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jason Robb from comment #18) Good catch, I had forgotten to test with save state disabled. The last patch should take care of that now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Raina <raina@flo.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raina@flo.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30221 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Jason, do you think you will have time to have another try? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195314|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #27 from Jason Robb <jrobb@sekls.org> --- Created attachment 196275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196275&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #28 from Jason Robb <jrobb@sekls.org> --- Created attachment 196276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196276&action=edit Bug 41604: Centralize visibility condition in datatables.js We want to hide column if: * the feature is not accessible (pref disabled or insufficient permissions) or * the column is hidden in the settings or * the column has been hidden by the user Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #29 from Jason Robb <jrobb@sekls.org> --- Created attachment 196277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196277&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #30 from Jason Robb <jrobb@sekls.org> --- Created attachment 196278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196278&action=edit Bug 41604: take visibility_condition when save state is disabled Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #31 from Jason Robb <jrobb@sekls.org> --- I ran through all the scenarios in comment #20 and everything seems to work now! A few testing notes: - I had to restart_all after applying the patch - It took a hard refresh to see the changes after the restart - For testing as a non-superlibrarian specifically in batch patron mod, I used a private browser when logging in and had to close and reopen a new browser to see the changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 42183 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hammat.wele@inlibro.com |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Thanks a lot, Jason! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42332 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332 [Bug 42332] Remove conditional TT tags from tables thead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |victor@tuxayo.net --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> --- QA script fails with [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL filters missing_filter at line 1427 ( const cancel_column_available = [% !closedate || Koha.Preference('CancelOrdersInClosedBaskets') ? 1 : 0 %]) [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The conditions refactoring looks good. No unintended flip. The one using ediaccount is even fixed, it was wrong before ^^" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198514&action=edit Bug 41604: QA fixes Patch from commit 27f4a86 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Victor Grousset/tuxayo <victor@tuxayo.net> --- 1. With the patches 2. go the existing acquisitions basket 3. add an order 4. close the basket 5. the Modify and Cancel columns are still visible even if empty (bug) 6. supplier report also (bug) 7. go back to main, restart_all 8. the 3 columns are not shown anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #38 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198925&action=edit Bug 41604: Fix typo Patch from commit 3f7498e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #39 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #37)
1. With the patches 2. go the existing acquisitions basket 3. add an order 4. close the basket 5. the Modify and Cancel columns are still visible even if empty (bug) 6. supplier report also (bug) 7. go back to main, restart_all 8. the 3 columns are not shown anymore
Oops, there was a typo. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #40 from Victor Grousset/tuxayo <victor@tuxayo.net> --- With the patches, when I close and reopen a basket, I need to logout and login to see again the Modify and Cancel order columns. Without the patches, the columns are immediately available again. Same issue but with more details: When toggling AllowHoldItemTypeSelection and looking at a patron's Holds history page (with a hold pending): to make the column reappear I have to logout and login. But it's not needed for making it disappear. (mind the syspref page silently failing due to CSRF mismatch when testing this so you need to refresh it) Without the patches, toggling the syspref is effective without relogging. On another topic, what are the condition to see the supplier report column on page load? (see the effect of force_visibility) Default config is "Is hidden by default" => false. So having the edifact syspref and an EDI account for the vendor should be enough. Even if I hardcode: supplier_report_column.visibility_condition = 1; It's not enough to see it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199223&action=edit Bug 41604: Fix force display of a column If a column must be displayed but was hidden before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #42 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Victor Grousset/tuxayo from comment #40)
With the patches, when I close and reopen a basket, I need to logout and login to see again the Modify and Cancel order columns. Without the patches, the columns are immediately available again.
Good catch, there was a problem when we forced the display of a column.
Same issue but with more details: When toggling AllowHoldItemTypeSelection and looking at a patron's Holds history page (with a hold pending): to make the column reappear I have to logout and login. But it's not needed for making it disappear. (mind the syspref page silently failing due to CSRF mismatch when testing this so you need to refresh it) Without the patches, toggling the syspref is effective without relogging.
Same problem, same fix :)
On another topic, what are the condition to see the supplier report column on page load? (see the effect of force_visibility) Default config is "Is hidden by default" => false. So having the edifact syspref and an EDI account for the vendor should be enough. Even if I hardcode: supplier_report_column.visibility_condition = 1; It's not enough to see it.
Should also be fixed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- Can we move forward here please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 [Bug 42279] Tidy all script tags - acqui -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39592 [Bug 39592] requestspecific table on reserve/request.pl should be column configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #44 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Victor.. are you going to re-test now Jonathan has submitted follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196275|0 |1 is obsolete| | Attachment #196276|0 |1 is obsolete| | Attachment #196277|0 |1 is obsolete| | Attachment #196278|0 |1 is obsolete| | Attachment #198514|0 |1 is obsolete| | Attachment #198925|0 |1 is obsolete| | Attachment #199223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199943&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #46 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199944&action=edit Bug 41604: Centralize visibility condition in datatables.js We want to hide column if: * the feature is not accessible (pref disabled or insufficient permissions) or * the column is hidden in the settings or * the column has been hidden by the user Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #47 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199945&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199946&action=edit Bug 41604: take visibility_condition when save state is disabled Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199947&action=edit Bug 41604: QA fixes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #50 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199948&action=edit Bug 41604: Fix typo Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #51 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199949&action=edit Bug 41604: Fix force display of a column If a column must be displayed but was hidden before Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #52 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199995&action=edit Bug 41604: (follow-up) Fix the visibility when visibility_condition is 0 or null, instead of false Patch from commit d6ed804 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #53 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi guys, if I refresh the page, the Check in column comes back for me: To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible 6. Refresh the page, access: http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=19 7. Click 'Show checkouts': The 'Check in' column is back again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #54 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #53)
Hi guys, if I refresh the page, the Check in column comes back for me:
I have to admit this one drives me crazy, but thanks for catching that before it's pushed! I will work on it tomorrow, and adjust the tree if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #55 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200503&action=edit Bug 41604: Add Cypress tests Patch from commit 8ef27ef -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #56 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200504&action=edit Bug 41604: Add one more Cypress test Patch from commit 4e37f26 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #57 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200505&action=edit Bug 41604: Save user decision per column when visibility changes - Modify column-visibility.dt event handler to store the visibility preference of the user - Improve _dt_force_visibility() to correctly pick the correctly visibility value depending on visibility_condition, is_hidden, and the user preference - Add _dt_get_expected_column_visibility() to guess what's the expected visibility - Force boolean true/false (vs 1/0) using !! - Rely on a global variable kohaTableUserChoices to store the user choice. It will be part of the state and store in localStorage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #58 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200506&action=edit Bug 41604: Hide column if the feature is disabled Example: supplier_report on the basket page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- It was tricky to get back to this one, but I think it was necessary: I have found again more bug and I think I have found a good solution. Now the preference of the user will be saved and flag as it, explicitly, in the state. It brings more flexibility to pick the correct the decision in the code. Unfortunately I will need to require another round of SO and QA. Please test ASAP! This is a priority for me (there are more work on top of this) and I will provide fast feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199943|0 |1 is obsolete| | Attachment #199944|0 |1 is obsolete| | Attachment #199945|0 |1 is obsolete| | Attachment #199946|0 |1 is obsolete| | Attachment #199947|0 |1 is obsolete| | Attachment #199948|0 |1 is obsolete| | Attachment #199949|0 |1 is obsolete| | Attachment #199995|0 |1 is obsolete| | Attachment #200503|0 |1 is obsolete| | Attachment #200504|0 |1 is obsolete| | Attachment #200505|0 |1 is obsolete| | Attachment #200506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #60 from Jason Robb <jrobb@sekls.org> --- Created attachment 200685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200685&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #61 from Jason Robb <jrobb@sekls.org> --- Created attachment 200686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200686&action=edit Bug 41604: Centralize visibility condition in datatables.js We want to hide column if: * the feature is not accessible (pref disabled or insufficient permissions) or * the column is hidden in the settings or * the column has been hidden by the user Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #62 from Jason Robb <jrobb@sekls.org> --- Created attachment 200687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200687&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #63 from Jason Robb <jrobb@sekls.org> --- Created attachment 200688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200688&action=edit Bug 41604: take visibility_condition when save state is disabled Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #64 from Jason Robb <jrobb@sekls.org> --- Created attachment 200689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200689&action=edit Bug 41604: QA fixes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #65 from Jason Robb <jrobb@sekls.org> --- Created attachment 200690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200690&action=edit Bug 41604: Fix typo Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #66 from Jason Robb <jrobb@sekls.org> --- Created attachment 200691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200691&action=edit Bug 41604: Fix force display of a column If a column must be displayed but was hidden before Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #67 from Jason Robb <jrobb@sekls.org> --- Created attachment 200692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200692&action=edit Bug 41604: (follow-up) Fix the visibility when visibility_condition is 0 or null, instead of false Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #68 from Jason Robb <jrobb@sekls.org> --- Created attachment 200693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200693&action=edit Bug 41604: Add Cypress tests Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #69 from Jason Robb <jrobb@sekls.org> --- Created attachment 200694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200694&action=edit Bug 41604: Add one more Cypress test Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #70 from Jason Robb <jrobb@sekls.org> --- Created attachment 200695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200695&action=edit Bug 41604: Save user decision per column when visibility changes - Modify column-visibility.dt event handler to store the visibility preference of the user - Improve _dt_force_visibility() to correctly pick the correctly visibility value depending on visibility_condition, is_hidden, and the user preference - Add _dt_get_expected_column_visibility() to guess what's the expected visibility - Force boolean true/false (vs 1/0) using !! - Rely on a global variable kohaTableUserChoices to store the user choice. It will be part of the state and store in localStorage. Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #71 from Jason Robb <jrobb@sekls.org> --- Created attachment 200696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200696&action=edit Bug 41604: Hide column if the feature is disabled Example: supplier_report on the basket page Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #72 from Jason Robb <jrobb@sekls.org> --- I ran back through my steps in comment 20 as well as the steps in comment 53 and everything worked perfectly for me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42910 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42910 [Bug 42910] Restore ability to save state for holdings table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200685|0 |1 is obsolete| | Attachment #200686|0 |1 is obsolete| | Attachment #200687|0 |1 is obsolete| | Attachment #200688|0 |1 is obsolete| | Attachment #200689|0 |1 is obsolete| | Attachment #200690|0 |1 is obsolete| | Attachment #200691|0 |1 is obsolete| | Attachment #200692|0 |1 is obsolete| | Attachment #200693|0 |1 is obsolete| | Attachment #200694|0 |1 is obsolete| | Attachment #200695|0 |1 is obsolete| | Attachment #200696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #73 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201150&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #74 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201151&action=edit Bug 41604: Centralize visibility condition in datatables.js We want to hide column if: * the feature is not accessible (pref disabled or insufficient permissions) or * the column is hidden in the settings or * the column has been hidden by the user Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #75 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201152&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #76 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201153&action=edit Bug 41604: take visibility_condition when save state is disabled Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #77 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201154&action=edit Bug 41604: QA fixes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #78 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201155&action=edit Bug 41604: Fix typo Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #79 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201156&action=edit Bug 41604: Fix force display of a column If a column must be displayed but was hidden before Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #80 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201157&action=edit Bug 41604: (follow-up) Fix the visibility when visibility_condition is 0 or null, instead of false Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #81 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201158&action=edit Bug 41604: Add Cypress tests Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #82 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201159&action=edit Bug 41604: Add one more Cypress test Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #83 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201160&action=edit Bug 41604: Save user decision per column when visibility changes - Modify column-visibility.dt event handler to store the visibility preference of the user - Improve _dt_force_visibility() to correctly pick the correctly visibility value depending on visibility_condition, is_hidden, and the user preference - Add _dt_get_expected_column_visibility() to guess what's the expected visibility - Force boolean true/false (vs 1/0) using !! - Rely on a global variable kohaTableUserChoices to store the user choice. It will be part of the state and store in localStorage. Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #84 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201161&action=edit Bug 41604: Hide column if the feature is disabled Example: supplier_report on the basket page Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #85 from Jonathan Druart <jonathan.druart@gmail.com> --- Yet another rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #86 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201170&action=edit Bug 41604: Correctly restore alert when bKohaColumnsUseNames is off If we define visibility_condition we must have implemented bKohaColumnsUseNames correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #87 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Looks good, test coverage is OK, everything seems to work when I test in the UI. One minor thing I found: function _dt_force_visibility() sets the variable "var columns_settings" but it is not used in the function. Do we need it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #88 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201444&action=edit Bug 41604: (QA follow-up) Add a semicolon Patch from commit 03579e0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201150|0 |1 is obsolete| | Attachment #201151|0 |1 is obsolete| | Attachment #201152|0 |1 is obsolete| | Attachment #201153|0 |1 is obsolete| | Attachment #201154|0 |1 is obsolete| | Attachment #201155|0 |1 is obsolete| | Attachment #201156|0 |1 is obsolete| | Attachment #201157|0 |1 is obsolete| | Attachment #201158|0 |1 is obsolete| | Attachment #201159|0 |1 is obsolete| | Attachment #201160|0 |1 is obsolete| | Attachment #201161|0 |1 is obsolete| | Attachment #201170|0 |1 is obsolete| | Attachment #201444|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #89 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201449&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #90 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201450&action=edit Bug 41604: Centralize visibility condition in datatables.js We want to hide column if: * the feature is not accessible (pref disabled or insufficient permissions) or * the column is hidden in the settings or * the column has been hidden by the user Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #91 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201451&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #92 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201452&action=edit Bug 41604: take visibility_condition when save state is disabled Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #93 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201453&action=edit Bug 41604: QA fixes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #94 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201454&action=edit Bug 41604: Fix typo Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #95 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201455&action=edit Bug 41604: Fix force display of a column If a column must be displayed but was hidden before Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #96 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201456&action=edit Bug 41604: (follow-up) Fix the visibility when visibility_condition is 0 or null, instead of false Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #97 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201457&action=edit Bug 41604: Add Cypress tests Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #98 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201458&action=edit Bug 41604: Add one more Cypress test Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #99 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201459&action=edit Bug 41604: Save user decision per column when visibility changes - Modify column-visibility.dt event handler to store the visibility preference of the user - Improve _dt_force_visibility() to correctly pick the correctly visibility value depending on visibility_condition, is_hidden, and the user preference - Add _dt_get_expected_column_visibility() to guess what's the expected visibility - Force boolean true/false (vs 1/0) using !! - Rely on a global variable kohaTableUserChoices to store the user choice. It will be part of the state and store in localStorage. Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #100 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201460&action=edit Bug 41604: Hide column if the feature is disabled Example: supplier_report on the basket page Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #101 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201461&action=edit Bug 41604: Correctly restore alert when bKohaColumnsUseNames is off If we define visibility_condition we must have implemented bKohaColumnsUseNames correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #102 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201462&action=edit Bug 41604: (QA follow-up) Add a semicolon Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #103 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 201463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201463&action=edit Bug 41604: (QA follow-up) Remove unused JS variable Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201449|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201450|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201451|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201452|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201454|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201455|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201456|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201459|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201461|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201463|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #104 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201515&action=edit Bug 41604: Impossible to hide Checkin column in issues-table in circ/circulation.pl Bug 41314 caused a regression, making it impossible to hide the Checkin column in the issues table in the patron's circulation page. To recreate: 1. Hide the checkin column by default in circulation issues-table 1.1. Go to Administration > Table settings > Circulation tab > Jump to page : circulation > Table id: issues-table 1.2. Check 'Is hidden by default' for 'checkin' 1.3. Click 'Save' 2. logout and login 3. Checkout an item to a patron 3.1. In the search bar, set to Checkout, search for Henry 3.2. In the checkout field, enter the barcode 39999000010114 and press enter --> In the table of issues, Checkin column is visible, it should be hidden by default 4. Apply the patch 5. Repeat step 2, 3 --> In the table of issues, Checkin column is not visible Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #105 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201516&action=edit Bug 41604: Centralize visibility condition in datatables.js We want to hide column if: * the feature is not accessible (pref disabled or insufficient permissions) or * the column is hidden in the settings or * the column has been hidden by the user Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #106 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201517&action=edit Bug 41604: Use visibility_condition in other places There are 3 other places where we force the visibility of columns. They must als use this new visibility_condition flag, so they are all using it. Test plan: The 3 tables are: 1. basket with the columns edifact, modify, cancel 2. hold history with the column itemtype 3. batch edit patron with the columns checkbox, password expiration, protected Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #107 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201518&action=edit Bug 41604: take visibility_condition when save state is disabled Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #108 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201519&action=edit Bug 41604: QA fixes Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #109 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201520&action=edit Bug 41604: Fix typo Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #110 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201521&action=edit Bug 41604: Fix force display of a column If a column must be displayed but was hidden before Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #111 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201522&action=edit Bug 41604: (follow-up) Fix the visibility when visibility_condition is 0 or null, instead of false Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #112 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201523&action=edit Bug 41604: Add Cypress tests Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #113 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201524&action=edit Bug 41604: Add one more Cypress test Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #114 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201525&action=edit Bug 41604: Save user decision per column when visibility changes - Modify column-visibility.dt event handler to store the visibility preference of the user - Improve _dt_force_visibility() to correctly pick the correctly visibility value depending on visibility_condition, is_hidden, and the user preference - Add _dt_get_expected_column_visibility() to guess what's the expected visibility - Force boolean true/false (vs 1/0) using !! - Rely on a global variable kohaTableUserChoices to store the user choice. It will be part of the state and store in localStorage. Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #115 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201526&action=edit Bug 41604: Hide column if the feature is disabled Example: supplier_report on the basket page Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #116 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201527&action=edit Bug 41604: Correctly restore alert when bKohaColumnsUseNames is off If we define visibility_condition we must have implemented bKohaColumnsUseNames correctly. Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #117 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201528&action=edit Bug 41604: (QA follow-up) Add a semicolon Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #118 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 201529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201529&action=edit Bug 41604: (QA follow-up) Remove unused JS variable Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #119 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hello, very sorry that I was Away From Koha lately. Until going offline, I was able to retest most workflows mentioned in the commit messages. Plus those where I previously found issues. And so far I hadn't found issues. But didn't make it to the end to report on it here :( Now I tested all of them on the current code and no issues found :) Thanks Lucas for the help. I also checked that a non superlibrarian staff doesn't see "Password expiration date" and "Protected" column in patron batch modification. And the effect of ExportCircHistory in the checkout list of a patron. And I confirm the error "Cannot force column visibility without bKohaColumnsUseNames!" comes up when expected. Thanks Jonathan for the comments in _dt_force_visibility(), it really helps. And various combinations of user pref/Is hidden by default/Cannot be toggled seems to work as expected of their priorities :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #120 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #121 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 202208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202208&action=edit Bug 41604: (follow-up) Wait for the page to be ready before searching in patrons_search.t Bug 41604 made every page do a bit more work when it loads. This Selenium test didn't wait for that work to finish before typing into the search box, so sometimes it searched too early and got the wrong results. This adds a short wait after each page load so the test only searches once the page is actually ready. Introduced by: Bug 41604: Save user decision per column when visibility changes Test plan: prove t/db_dependent/selenium/patrons_search.t Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #122 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 202211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202211&action=edit Bug 41604: (follow-up) Wait for the page to be ready before searching in patrons_search.t Bug 41604 made every page do a bit more work when it loads. This Selenium test didn't wait for that work to finish before typing into the search box, so sometimes it searched too early and got the wrong results. This adds a short wait after each page load so the test only searches once the page is actually ready. Introduced by: Bug 41604: Save user decision per column when visibility changes Test plan: prove t/db_dependent/selenium/patrons_search.t Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #123 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Follow up pushed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43174 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43174 [Bug 43174] Regressions: Staff interface patron search on a record details page - lists patrons by default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 --- Comment #124 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #122)
Created attachment 202211 [details] [review] Bug 41604: (follow-up) Wait for the page to be ready before searching in patrons_search.t
Something else was hidden behind this failure, see bug 43174. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30144 [Bug 30144] Add support for EDI GIR:LVT and/or GIR:LVC, Servicing instructions, segment -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org